From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2778DC433E2 for ; Mon, 14 Sep 2020 09:20:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C658620719 for ; Mon, 14 Sep 2020 09:20:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DFueFGyb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fRBlYh4v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C658620719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=52Doa34aaaiuOgZJWrwISwZIcEBWGT28ZYbHmvoT8cI=; b=DFueFGybg1PcQuMVRgHjWRoF5 MibDLRATc5vSbJiwtJtY9w2QoQsPLrhDnyt3s8PNwNpeCq+yo0pYRUoUqtrFMhQhQtD5xxOpmhGN9 i2Es2sJ0oeQjBUvw5W9Z395CzqMP1H/CmHK8/wsrg9A63jIfGFN/+xrlh8L0pZgnOai/wra/Ogidi MQVs7f+u+TjE3FVkL7w7ZVoDlbK+GVfYbr9968Sm7JX5cEinha94iYU6FL9Xakwsh+98gYTsovU02 AmMASVpiDL3HNN3QqhIjB9gVbSC4rA/k2rEdCiEmZ3Dincy+0kf3tuls8pXebYh8G+erxBx11svWH 3mUku/fcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHkeD-0003dO-8K; Mon, 14 Sep 2020 09:19:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHke7-0003bi-Ec; Mon, 14 Sep 2020 09:19:37 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3C66206B2; Mon, 14 Sep 2020 09:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600075173; bh=QIiumx2JgDWAeVENHTZwWAcYfrAyrHP97J76nujl4Lc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fRBlYh4vlRVBxg8PRKUd/4YOW0n7fYV9AuR4UAgsGazkfmNcWwk9nQDXnAa5SD4iO HzzxQYroptknH8L0QELBuvP6jCjkeTS8G3f48aUV5AeGddMFtRFZySqoruOjxW66zz bFMjdStegwim2MQCJcvSyhiCK8T7MC59RjoWvdp0= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kHke3-00BdhW-OV; Mon, 14 Sep 2020 10:19:31 +0100 MIME-Version: 1.0 Date: Mon, 14 Sep 2020 10:19:31 +0100 From: Marc Zyngier To: Cristian Ciocaltea Subject: Re: [PATCH v6 2/3] irqchip: Add Actions Semi Owl SIRQ controller In-Reply-To: <20200914085154.GA8474@BV030612LT> References: <1167b847f6fe1da3834aeaadf5710ddac54f06a0.1599552438.git.cristian.ciocaltea@gmail.com> <20200914070227.GA4491@BV030612LT> <20200914085154.GA8474@BV030612LT> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <0cdd2fd4e09c7e51b8b48be914c6846f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: cristian.ciocaltea@gmail.com, robh+dt@kernel.org, manivannan.sadhasivam@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, afaerber@suse.de, parthiban@linumiz.com, sravanhome@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, pn@denx.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_051935_656579_7BDD1373 X-CRM114-Status: GOOD ( 29.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, parthiban@linumiz.com, Parthiban Nallathambi , Jason Cooper , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Manivannan Sadhasivam , Thomas Gleixner , =?UTF-8?Q?Andreas_F=C3=A4rber?= , linux-arm-kernel@lists.infradead.org, Saravanan Sekar Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-09-14 09:51, Cristian Ciocaltea wrote: > On Mon, Sep 14, 2020 at 09:07:18AM +0100, Marc Zyngier wrote: >> Cristian, >> >> On 2020-09-14 08:02, Cristian Ciocaltea wrote: >> > Hi Marc, >> > >> > On Fri, Sep 11, 2020 at 05:22:41PM +0100, Marc Zyngier wrote: >> > > On 2020-09-08 09:20, Cristian Ciocaltea wrote: >> > > > This interrupt controller is found in the Actions Semi Owl SoCs (S500, >> > > > S700 and S900) and provides support for handling up to 3 external >> > > > interrupt lines. >> > > > >> > > > Each line can be independently configured as interrupt and triggers on >> > > > either of the edges or either of the levels. Additionally, each line >> > > > can also be masked individually. >> > > > >> > > > The patch is based on the work started by Parthiban Nallathambi: >> > > > https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@denx.de/ >> > > > >> > > > Signed-off-by: Parthiban Nallathambi >> > > > Signed-off-by: Saravanan Sekar >> > > > [cristi: optimized DT, various fixes/cleanups/improvements] >> > > > Signed-off-by: Cristian Ciocaltea >> > > >> > > Who is the author of these patches? If this is a co-development, >> > > please >> > > use the relevant tags. Otherwise, the author of the patch must come as >> > > the first SoB. >> > >> > I took the authorship for the driver patch, as mentioned in the cover >> > letter. So, if I understand correctly, my SoB should be moved on top and >> > I assume I also need to drop the related comment line. >> >> Not quite. Please look at >> Documentation/process/submitting-patches.rst. > > Yes, I have read it, but most probably I missed the information that > clarifies this authorship change handling. > >> If Parthiban and Saravanan haven't authored anything in this patch, >> then drop them from the SoB list. > > Sorry I haven't properly explained this before! > > Their contributions to the driver code stopped in 2018, when v3 of the > patch series has been submitted. > >> If they have contributed to the >> patch (which I expect), then their SoB must be preceded by their own >> Co-developed-by: tag. > > Starting with v4, the work has been done exclusively by myself. > >> To sum it up, it probably should look like: >> >> Co-developed-by: Parthiban Nallathambi >> Signed-off-by: Parthiban Nallathambi >> Co-developed-by: Saravanan Sekar >> Signed-off-by: Saravanan Sekar >> Signed-off-by: Cristian Ciocaltea >> >> This is of course an assumption, and you should check it with the >> individuals above. > > I have recently contacted Parthiban and he agreed that I can take the > authorship. So I should proceed with the 1st approach? The authorship of the patch is one thing, acknowledging the work done by others is another. As you said above, you started by contributing to an existing series, instead of writing it from scratch. You changed it to a degree where it makes sense for you to be the author of the patches, but it doesn't invalidate the contributions made by others before you. Unless the two other contributors explicitly say they'd rather not be named, I don't see how you can avoid mentioning them. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel