From: Dragan Simic <dsimic@manjaro.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Rock 5 ITX board
Date: Wed, 03 Jul 2024 23:11:25 +0200 [thread overview]
Message-ID: <0d1b1a5fbe97d27ee54513261d77df0e@manjaro.org> (raw)
In-Reply-To: <20240703210524.776455-2-heiko@sntech.de>
Hello Heiko,
Please see a few comments below.
On 2024-07-03 23:05, Heiko Stuebner wrote:
> Add devicetree binding for the Rock 5 ITX board, build around the
> rk3588.
s/Rock/ROCK/
s/build/built/
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index d2e887415d5dc..7ddb008f52d1a 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -826,6 +826,11 @@ properties:
> - const: radxa,rock-5b
> - const: rockchip,rk3588
>
> + - description: Radxa ROCK 5ITX
s/5ITX/5 ITX/
> + items:
> + - const: radxa,rock-5itx
s/5itx/5-itx/
> + - const: rockchip,rk3588
> +
> - description: Radxa ROCK S0
> items:
> - const: radxa,rock-s0
next prev parent reply other threads:[~2024-07-03 21:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:05 [PATCH 0/2] Rock 5 ITX devicetree Heiko Stuebner
2024-07-03 21:05 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add Rock 5 ITX board Heiko Stuebner
2024-07-03 21:11 ` Dragan Simic [this message]
2024-07-04 6:26 ` Krzysztof Kozlowski
2024-07-03 21:05 ` [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board Heiko Stuebner
2024-07-03 21:16 ` Dragan Simic
2024-07-04 6:28 ` Krzysztof Kozlowski
2024-07-04 9:38 ` Diederik de Haas
2024-07-04 10:05 ` Heiko Stübner
2024-07-04 11:43 ` Alex Bee
2024-07-04 12:05 ` Heiko Stübner
2024-07-04 13:04 ` Alex Bee
2024-07-04 10:52 ` Alex Bee
2024-07-04 11:21 ` Heiko Stübner
2024-07-04 12:04 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d1b1a5fbe97d27ee54513261d77df0e@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).