From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B2B7C31D97 for ; Wed, 3 Jul 2024 21:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g4RrLkCB33hOEMUGwheKRpmYM3thvQih+jMVkGH4nZE=; b=oPzp5VD6F5o2hn6EViMMU+EiWH L7+bReyvLoR9bDGIt+DOaBlM+99O6ZeZbUdEQsQdX7n5yXD+TBVfT82Kvm5iZoCCYDh3S5v13zRzJ xqxW/GbutMf5VJvu/f3d3H4R4rwQuKyJKfHxUMupe1v28Q2D0XGQ+Bbw3S2EnmSHOB4dedZ7dF5gm ZB8vJFjZMq/2Z+9VocVhjYPlI5BGQaG3OJruh8y+QP/9di9U6s8dcXiST26kcJ0hVR9oRr8wE63G1 kPtkXuWTTnHgR0PqOtohYAeLC0NufabLrol0I19wyb0E8jfTbrMaxVnlr4wry8R6tnEflZkrWrBEM HCMALzbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP7GS-0000000BSqp-0See; Wed, 03 Jul 2024 21:11:44 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP7GE-0000000BSni-3xuh; Wed, 03 Jul 2024 21:11:32 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1720041086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g4RrLkCB33hOEMUGwheKRpmYM3thvQih+jMVkGH4nZE=; b=DuOh7xfkxgyG1FedaGH2jYO/BnzbrT9FMBNQfg+lfFSfQXR8ukKwto5ZcBdzwZL5LDjy7C wvyrUPlxzJMri0QnA46pQ1o7ERRBldSbiXksEzTTwr/5xgndcuiQgadXmC9Xxghw8xXjkI Xu0WTcYSkD/fFMo6lwShJaf6PVSQRTd+NQIEDV6zT0lzZh4Lk3FaKiq15eDia2a434Ul89 QL2neb15dCAIIyn5/AfT2joXEyOuBkUCoqNBoLjBXBleeiMrms3ylfychSSBRIL6UPWMy3 Fpg6eVlJAiXM0wcBz5Ldri1RPJlyt2dqRDOjHCIQ7ZqezyfqxvyVoMHNz4j61w== Date: Wed, 03 Jul 2024 23:11:25 +0200 From: Dragan Simic To: Heiko Stuebner Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Rock 5 ITX board In-Reply-To: <20240703210524.776455-2-heiko@sntech.de> References: <20240703210524.776455-1-heiko@sntech.de> <20240703210524.776455-2-heiko@sntech.de> Message-ID: <0d1b1a5fbe97d27ee54513261d77df0e@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_141131_474748_E97AC98F X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Heiko, Please see a few comments below. On 2024-07-03 23:05, Heiko Stuebner wrote: > Add devicetree binding for the Rock 5 ITX board, build around the > rk3588. s/Rock/ROCK/ s/build/built/ > Signed-off-by: Heiko Stuebner > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml > b/Documentation/devicetree/bindings/arm/rockchip.yaml > index d2e887415d5dc..7ddb008f52d1a 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -826,6 +826,11 @@ properties: > - const: radxa,rock-5b > - const: rockchip,rk3588 > > + - description: Radxa ROCK 5ITX s/5ITX/5 ITX/ > + items: > + - const: radxa,rock-5itx s/5itx/5-itx/ > + - const: rockchip,rk3588 > + > - description: Radxa ROCK S0 > items: > - const: radxa,rock-s0