Re: [PATCH 1/5] dt-bindings: remoteproc: add imx-rproc-psci binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/04/2026 11:08, Jiafei Pan wrote:
> Add compatible string "fsl,imx-rproc-psci" for i.MX Cortex-A Core's
> remoteproc support.

A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18


Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

Not doing full review - lack of usage of tools disqualifies the patchset
for review to me.

> +
> +examples:
> +  - |
> +    / {
> +        reserved-memory {
> +            #address-cells = <2>;
> +            #size-cells = <2>;
> +            ranges;
> +
> +            rtos_ca55_reserved: rtos-ca55@d0000000 {
> +                reg = <0 0xd0000000 0 0x10000000>;
> +                no-map;
> +            };
> +        };

Drop all above, I am pretty sure this will have failures, so test ALL
BINDINGS.

> +
> +        remoteproc-ca55-1 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).


> +            compatible = "fsl,imx-rproc-psci";
> +            /* bitmask: 0b10, assign A55 Core 1 */
> +            fsl,cpus-bits = <0x2>;
> +            memory-region = <&rtos_ca55_reserved>;
> +        };
> +    };


Best regards,
Krzysztof