From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98DE0FF8850 for ; Sun, 26 Apr 2026 07:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:Subject:References:Cc:To:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1J7QaMP0mZ3aZ8Q7RosVs43+dysGw9YCcECBDq5aN5M=; b=UMDFsURyae2SaFtHq8nkXgAU5x 8WP5t8SEE7NoUmqcm+87p2FQglB8kKbxIE6z5lOoHEHXt5MvcfZ4/xJ8o/PF2/i7kxm2flDDzo/xF SCvdERkdVnfMKDnToUxVvCWub+1Y/I4hx2cr+XeX+nWaV2z4VU1TfulXrk0jUJLwOzkKzgKudkQne QqRaRxP3FHeeS7ajtOVwVITnGsTRr9mekZiyMBbY09EJix7MdDBnn1w5zDTzQI1BT9Ptjc724jmEM XawGvFX7ugbZMW3X1A5vwn6zsCZ16g97wigvTCtcgGkCCqS1y6XiANITrbevJq8j5gOPM+9Y57iI1 Rbntqn9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGtnc-0000000FKNS-0ga8; Sun, 26 Apr 2026 07:21:04 +0000 Received: from mout.web.de ([217.72.192.78]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wGtnY-0000000FKN9-3kHk for linux-arm-kernel@lists.infradead.org; Sun, 26 Apr 2026 07:21:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1777188035; x=1777792835; i=markus.elfring@web.de; bh=1J7QaMP0mZ3aZ8Q7RosVs43+dysGw9YCcECBDq5aN5M=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=M/i2nYK5RJ8STuTRvbqRv6hlWQ5ek8mE69rx3YIJI1r2qhezP9TOWDE8NeLn0jYh MtEDZ3eWLkCOKQRxeBN0eSYA4cIaiv7BT71ZuMusQma/LMDX0vW61AVvJSVwnVXwb ToGjGC5d+i52FkHmDJ57HcSwTTvVxhyjVm/z8tj3u2JNNxB6nczji7hOvxqIv79Nb 8mb0GE/alp8w320Sl3R1a8Z9nWwaSk6U4WaeyEBB8FEmGhz27SzI7KFM09Nc2Tnap ommgdkEQoejXhNoxezt4C5Rjyk+CvUKBFpcHHZbetTnthYtof5ddf6cx+DbOAqFLG QAH2v0VUJB5f1qymgw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from client.hidden.invalid by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M8C09-1wLYlE1kQN-00CgZx; Sun, 26 Apr 2026 09:20:35 +0200 Message-ID: <0d7be98e-ab66-46ab-a729-b344500356a6@web.de> Date: Sun, 26 Apr 2026 09:20:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Frank Li , vulab@iscas.ac.cn, imx@lists.linux.dev, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Cc: stable@vger.kernel.org, LKML , Fabio Estevam , Georgi Djakov , Sascha Hauer , Shawn Guo References: Subject: Re: [v2] interconnect: imx: fix use-after-free in imx_icc_node_init_qos() Content-Language: en-GB, de-DE From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:N/4aGxbZaLhQPHDsNJDRc9fAJLd2rnfZaqh6cCek3W6t7UqtXI2 71Yupdo9R/76uUwcYO0axILb1yzXnh4omLaAnh2xBKzE5wh/zKaBMANKRkT85lXs4aKXDvR dXXYWgtRYIY8NMWe/sfS6Sbj/i9TXul+FruoSeqJy9XQJeYHzX8LFcvqj0LwiNVtattsWZ9 zmmxMJNeJkifPbJkvHE6A== UI-OutboundReport: notjunk:1;M01:P0:V08j8qviItc=;gVl/wHb8+mccE1Qmw1FD3z/j3Ew aaPX1hlOmVlRyoWMWvxsiVjzzFgY+1K9wZ9wkv1D98b5DMmAlqfAXIMsjJPbt0EmbWUv18jJb fW+r5Nf9Ngc44U6uZdivm47DchjJd6cuwPG/MrZjXIfe134v+dGD7zS2KSMhti/N8ETq77/QA nbLhhSWqn07IFhgvYxDeZfaWh7pXybRkzHfIPTcYYMICGhdymvkuwQKWCiR8jAJ2VKeiWB2oo q2Wi4M/Bhk0xUD/gE8zsyOXuYWroFMPa5x+Baujn5X9lsqNj4x4ndchcI3awta2nkrhR+jeWe oy184yTQyTj6k7PvK210AVAcyJdmsJcvugBb/CVpZVXAyfYM5s7gTHYe+QqvK6FO3erzagvzU kCuJ/L5LzcXpyAxPwSY0Ivc3pUUL/+t+75Mt1tpBRbwxB+tl8LXDDoWc7zaE6FDI+Szhid/q1 BgZmBidTxpp5vp0As2G/E87RRMixsduLTa0uZeuWZiW17kI8JhfewE9QCP1CGgPRkCiwcWgt5 k2Y0v/IL7mLuI7S6WZT5WQDtEtl4BSZTYG+pzdVwLQEO5VgEXdFhOz2MD+MiHmkmysjeDoCPE VQk7TYd2ZRRu50dGCSbw863g0ZlhUoeB9UsZKjLPtKY990Dl/6OdiNbFYTKbf131sjZm/3fii SWTMovSehvXwIK010tDWiWTo59x3veABo9Qu2w5wpA5vDrY1SPiGw8CMChL2wapir8oAQaJ9H V6LD3SKFt2KubKoUG8mm/MXjcBCZpJe3JQH1OqtaMT6VCubKm6pzhwTWk6CTbMXQhEbdNWDCk p+/nAXB0t/MVIlWr2ktISwwp9dkn7T7L4UsXH/EsOXkBeOHbSesqa1w/9R1ioHPD9Z8oPzzer pre+eZ/h8XKG01LJv1eTHHwJvGhuaV7mfJymr7oiana/7u1EKrAXGIgVdNugLT+qmgE3Dn8H4 Mz3wGK6xtxR55aNgNKVlI4zGOb4awvcTJ5mjFngPUHw6hwE1ih+e5NEpl7HnQ4lnM9K1UR9h3 Xww3D9QL+rOpKAnL1xroQ6goQF1hRQSp2GLfVeM+YkCimZlGMPPjqSbQUPyX5BF0BBshlYG7j 8mvamxc8joUUnTQEYO6ZA3AwFrAAKo5EWwo3uMO37KDLCs5HJ/PDjVen4Q9GHT5veDRzxIp/5 4cepU0bTFjjwqxVwlMJKEIuzp09uYJEI1mYyErEu+Di1OJsjqUjV/vWdHGrvFbILtWTXe+NfJ BNgCQGhTkgGh1I7UnYnNdIWXk7OQ1UPWb3ukYNvjSlOwCKkK5FL9ubpQClHW0moJwrZFitPvg siEYn2cj8vE91Myvq1BE/EnkcvEU87JAzHftNw49Y6NwVZ2oWHOmxv5c3wVE7q69JCfr3YWzc RKLspKcGCS8tbW8vPSJfGP+/9ZFhgSMidUWsl6gN8vutUsqrb1TMh/F8B5EuzuWGcJnjGkOuq DZCecpH4fvuoVvZU6I0TwXID3S6HEGPGPRNTmQxkZJQ21FTaTMDMloWZ2o9kI5LE4NcxU9wPo Ro5lqZLDqn3MqwyD2I+4CrdFt82W5sxryosDks+zvDTryzzW+pxO1G3OYFj1OXYDE5vWHq6uH 6mFF6sO2PyWkbE8H3bSOMJ5Nmk5w0FzFk0ZCFLcQkt63ecLqQsHuPO9yjphFy5gQs7YC4KCR0 iw34S5zAzPq/V97p3wSiJr3zXLCd3g6aBOVxb6rFtesp6edcKE9ZoIWU2sZdgNz1KVdYfVJOo vttNr6OO+0QCxx33dY6tnb64L5hyuVzquG2Ft3iUR2sg439f2aeUUtaOQqWTI9t7KjkpeOVBs ISDNCr6NhfpyUQ/tRFtSyNcNYWZwWtgr3gHQWVxs+Z7OSP258ys0jAHwZfKhDZFF+bl3IyNvH IN8RsTxQrb6BSZ/Ps7NKtifW3Kb0kP+WyX4643gIR3i2ofObdSmliHEkaSeEYytcV5BuisjtA +CA+yJ64TRjJmlC++rPFyxxgx9X7U7N+/73HqfTgywRRFWrgQGYrrUPyiawS6ewM0UeEmmCSO zYcT7ufsVb+Q50h8vON1ylJzJRxuyHt/TU9IZEqbs/A5vdCjtQwA4LlsvZDfEctQ62zjTMADI k1gu0cZfABW1e+B8fBDdkT8moVQf4KyJu9s049pGx8G6oCDXMpda0mEFYV6kAI2UL9KnwlTri DVBiW9e0RJqYIx9fbYTdchSAexa2YX1dPPp9hTtmr7CXwkEHuE9YxDYo9qNbWgffnpgvmZQ2Z fSvO3zpgNZrhxgZhXYGxvIOFE+IauVIt98X4bkM97V0GiNeoBfirikVxJ3cdPTrTiVQps6dwT hl66PUPJX/ZpBfa2nXoWiihIb0GyM66Gdw6uBKfQC0FGFCuJJhGoLSVVrZBgkutxpOsIv1DOh 0okUWnh3bBoAcxsoWD6lsUv/OFow6sywzRUz7ob01EQEY8izJA/b0gsc2RUEJwLQFV/ziJ9c5 Z8uvFscr5f+Gl7qIbw2yq7oSfYNCJnCPeGpxsD21lSsxqSbGoSxY7xX4Zy7PSj46dxrQOuCt+ OdJIgqCJloWpHrY9RcMqNh8+QCeDWeqnX3wpOHctEm+FUF0nE0Viqu2K+mesWJQgHseckSkgn 9SCEjm9fNCA1M5thlf7nV6j2uDtw1h5xS9WwO7L/h/+D2XKYHkHD56Ysflvde72yNIzb1vRq+ ALO2qGrBEfVzjLD27MHBx1cwu2YgNUwfCtmLqNypUOFJoERoOXpWdK5NCtGDPgxFzN+XiMMND 8aJGSDhOnk21tpagNJtj2aqM2Z9VtGQRSa5YkToZwi/q8VMQoInAhY4qPrC0JGxwvdnm71jtq FFVUqZMEr4GJovb1i3+M1dXDj4BPiZQJdRvgWqgDJDjkqGW6/2wo7dAtclvvaiNk53D3yHUvp MYzAAMaoTxytSHspPWVw9ATkvqqmWH+KRVzs0mcYiWtn2hoz9F6jgRAIDT5nOMsyELvMH8BGT IYsqgkilDO6Kpt+XLxk5C2C7ZWZHya3DW9KakdhemQcXNzLfTG3RFgmG+MaUk84Yz4hOg6wq5 fzAWejoUDm0QqKdNwycovAvtSDUr9eqPIHBMmGQTH5vikh5+amjGA/EDQINy9XHfMxrMzNr3r 13BSBURdYR2qp9NmnlAhPDQvka/khL9NKXcMhwmM5RdRUaA+3SVyeE8CVD8mOEoDx3JN6AANI djZNoWwKMZRwCRfNOAeZI8TkizqAn/DBi7nDWjajNVZGuuicatMKqdiCmGyCztZAdXWqPTif1 A/lVyUisECzqKqeq5MGD6JjLDwWjTtiZeu0rUNJSNaDe8+C1/BwZKugpF4b+R+GZXVvx6mkrU vqnMsOxLmZi83znTv/LLKtIpmQwcaZRuycsW1IKQ+Y+zQsOONUPbjc/l1n51e47Tz+B0loeKP 53KKZax6XluAojrGaaCcWkgxfxAGbT27ENE7Yj2f/xI2NBJk73vpujFhNVpvG5ZzZNaBK/H5o yWPbuJlSHesJl4CalE1KmnM4E8qGcsqNpUGkCwsS++VSMO09FN23uTsTNI/DZ5TGtqsc/q7hB 2HW7EERP+9Jr2i/Qphob9c5w2WuLK5sdHGtaUbLYxbf3GUI3mKsa3RmgoPTp2kYPuhfWQF6Is 4/VdgvfsvZh4jjOEaz0ZyKAOm3UFEHBbDiv/Zu9nLbjziaWNUkvznSqvCvh+vWoWANOrTq88U OmwhgMEBKVyNNWUrlb6SUp0PmIat5qKE+z+iR5BBKzTLNy371tRhbSedP/4O8CCjGIjl8cBv9 AYr5hPoCEM4jP/o8b8o+fWFrkHzul5ZSDfKN0Ekz1F2tEDcJw8lXDmqmDHaWJsI6oZSWZcXy5 iA384FO9NDqmYsrwRSpWVoy1/pqNunBVXbGJhoZrSIWSXalFwedJjkOj+yvUW2VKEsgFDQtKp HOw3K6B5eHAqER+e9fBmDlE2tZVSSd4BG4NusS+NY8Mfkncf3ovBS1yG1MgEs+HwGs3BHJhTh 9F4F8VPjy4HqfRG6aEr/floi12OprQXhL6sU9wCaP/DHodHzWki1MGW4iGEUr+KzNoxIQnupn IjNYrlCL96BTIPHOkAA9/ZAyYkV8WT0auTebtWHHlN8WFnNIrzFlEF6bClCD4hQXXsAmnBoOl nHsCYgI3ZMZOEzgNRYu/sm/Babm4Bxku3OPKzaXxwIIeyKmECeK4JtcLcHYeSxor9J9VTCdy7 yEA7Fi5PLJy3uEAfJa33asYandFvbH2NKkkz3lfeubRCB46aA3bnT0wpTj2jYYE4W20vnmJMk UAuy9k+gZqnBjrHlzFwsTmYQ8HO9dSMzR/Si/pIWli3TAhl5VfyYNxWuY/WP96WeUlqYsEcsh GI3mdnvOvCOpXjZMdAs9+dMj9ALnrMHGZJfS/RDB4h8e0jvMXl2ueGKr81zEk8CxvQOj9xGjT Owp4iMkmUbStjlw7WKxvCV1LB70R916mTdH94JBt22s+h55mpZ43rOkLhvH8zrs4PFAsgvAwz yBQou66we6+wqPFZrq9AlxFBYMtFDdOmiAO7pMvcrv6Li/ke63qlR7tQ+R1K5yYWbIFOjKdEy +etBrv+W9gVmDt7EnILD8mKyYdGlMzy8DQHTuT7uo38IBPbFwPHvcM9EnGLwVahmUZ29NNP/w 1zLT6Qlo7Re7rAoZKvOlI/L1bZ81pNmCn9F7lxKno9TDLw3H5NK11v5OAB6BNMnT/TcpnjhCM AdjcZl5+ffldkPcQ0QFFQPr3jlJssPNPE1y479zmGmQBTIkjD7LjA8kulGb78PSQ/cCPTUanG QWYb/C004w0dATc1ixSPOGFXSPo5mgIEpn/3ZWtKlqp1j/rV2HvFHYGaBeQ6xHztI9W6hyB00 46FNjm7Popatk84e+JNm7H/0ZTR6UIX0CbCKkJyP1shKDrkZrT1ybMTBQul2J47zQGFRY8NW5 E0Fjh+7b5XV7BYzShCfNlBsstIDFsKt7GQStQlY/SgLdpBMfvT6UtcCHdm9lsdF0zBNzhlbFh BjXaGFMuRtbxpp9v1o9N85N9rVrEgeFGvfL7nrhtkp4JnrO/6UfZSdpYup8QiyYtSgBTR0KHl McRbNLyhO+UdWbMmOFFphrk0a6ECyz1CZkYHLndX3ldfcyDeW/dcpuwCMgqyfqmjFD/YWGxOB 8jnVAjlWVm+NdJJizfiNxppbCbA8gS8rIuIVkFyrbg11Ec5J9L9lnDxl54vXa80bC+0FVG1oh 1IZZwketHpSsUmEOtrXQBr2aRGocvtRgboSS8qHfIYIcfuwJP/FVvMgBxvbpKR0ljS43sfQTs z5fpUe/3+iX6v72UIWXyDAlrqoW/cUyx+hShG2n8AFzU1oVXPGUd+5ZKhkR9ARD8flcU4m3tA kAuQXOocX2xgRd53DQi4m1a2G1UKZ9Rj31Qu/GaVklrRxDOMVB3b7wCXaKs1QPSjO0Lo+jVO6 JS76eHRpIwWvh0YJT70pyc4gOZ0/JEfKfXOtfWpBqZzvMJ7HxKjpRoyWrTrW1RHxMvR5SvpIo hc258dp8IxouseA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260426_002101_293708_D624505C X-CRM114-Status: UNSURE ( 6.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org =E2=80=A6 > > use dn after the put, leading to use-after-free. Convert to automatic > > cleanup using __free(device_node) to ensure the reference is always > > released when dn goes out of scope. =E2=80=A6 > Reviewed-by: Frank Li > > drivers/interconnect/imx/imx.c | 6 ++---- =E2=80=A6 > @@ -120,7 +120,8 @@ static int imx_icc_node_init_qos(struct icc_provider= *provider, > struct imx_icc_node *node_data =3D node->data; > const struct imx_icc_node_adj_desc *adj =3D node_data->desc->adj; > struct device *dev =3D provider->dev; > - struct device_node *dn =3D NULL; > + struct device_node *__free(device_nod) dn =3D of_parse_phandle(dev->of= _node, > + adj->phandle_name, 0); =E2=80=A6 A typo was overlooked somehow. Regards, Markus