From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ECDCCCA471 for ; Fri, 3 Oct 2025 18:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P8aF5kDHsqAmoeZTdPJfAXWWOjaq5HtPh5P+kz7b4Zg=; b=DtMPTFn5QvR1xjBo2eljcZMU+1 HSRxOBvM8Z0/QcD9cuQsQg30QWcEjfUUUW8ifVv503trrRqrmgT6CIb+0FULu9AWNe+49MoIAi0uS 0LXK+4hWDUG01XF++LHDKOCLBUUsNxQbnOPFMHf8QSMx5kexQ/BFsSYC/T4uW7R0EyD/fofT0Y94l H2l/aT63PTmhNcTkHWGm1XJrCjRBxnPNTAbdc6tWrtSPBxNxT7mC/8cByt53kz339hppuOnFn0mGr kNVjMxtO1Rt1ALeLOowTIsetgfV4017X53591UEgxY722CDz+I2/7ZARpSw3dNld2tNZsf5DQJkM+ 2bhYSGfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v4k7y-0000000Ctb5-2Q0k; Fri, 03 Oct 2025 18:03:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v4k7w-0000000Cta8-0KXb for linux-arm-kernel@lists.infradead.org; Fri, 03 Oct 2025 18:03:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 824EA1596; Fri, 3 Oct 2025 11:03:23 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 590C03F5A1; Fri, 3 Oct 2025 11:03:25 -0700 (PDT) Message-ID: <0d84faef-5a14-4f16-8612-d0e5dfc15985@arm.com> Date: Fri, 3 Oct 2025 19:03:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 19/29] arm_mpam: Use a static key to indicate when mpam is enabled To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-20-james.morse@arm.com> <20250912131336.000014d3@huawei.com> Content-Language: en-GB From: James Morse In-Reply-To: <20250912131336.000014d3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251003_110332_169413_8E7C8A08 X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On 12/09/2025 13:13, Jonathan Cameron wrote: > On Wed, 10 Sep 2025 20:42:59 +0000 > James Morse wrote: > >> Once all the MSC have been probed, the system wide usable number of >> PARTID is known and the configuration arrays can be allocated. >> >> After this point, checking all the MSC have been probed is pointless, >> and the cpuhp callbacks should restore the configuration, instead of >> just resetting the MSC. >> >> Add a static key to enable this behaviour. This will also allow MPAM >> to be disabled in repsonse to an error, and the architecture code to >> enable/disable the context switch of the MPAM system registers. >> >> Signed-off-by: James Morse > > Seems fine to me (other than the TODO move to arch code > that should probably be resolved. That is just to make it clear this isn't where it should live, its a quirk of moving the arch code alter to reduce the number of trees this interacts with. I've dropped the word 'TODO'... > Reviewed-by: Jonathan Cameron Thanks! James