From: Amelie DELAUNAY <amelie.delaunay@foss.st.com>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>, <vkoul@kernel.org>,
<kishon@ti.com>
Cc: <alexandre.torgue@foss.st.com>, <linux-phy@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: stm32: adopt dev_err_probe for regulators
Date: Tue, 26 Oct 2021 17:50:47 +0200 [thread overview]
Message-ID: <0d889ca2-2538-ea17-5bfd-a3d137115223@foss.st.com> (raw)
In-Reply-To: <1635172265-26219-1-git-send-email-fabrice.gasnier@foss.st.com>
Hi Fabrice,
Thanks for your patch.
On 10/25/21 4:31 PM, Fabrice Gasnier wrote:
> Change stm32-usbphyc driver to use dev_err_probe(), to benefit of
> devices_deferred debugfs in case of probe deferral.
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
> drivers/phy/st/phy-stm32-usbphyc.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index 7df6a63..115be0e 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -672,17 +672,15 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
>
> usbphyc->vdda1v1 = devm_regulator_get(dev, "vdda1v1");
> if (IS_ERR(usbphyc->vdda1v1)) {
> - ret = PTR_ERR(usbphyc->vdda1v1);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to get vdda1v1 supply: %d\n", ret);
> + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v1),
> + "failed to get vdda1v1 supply\n");
> goto clk_disable;
> }
>
> usbphyc->vdda1v8 = devm_regulator_get(dev, "vdda1v8");
> if (IS_ERR(usbphyc->vdda1v8)) {
> - ret = PTR_ERR(usbphyc->vdda1v8);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to get vdda1v8 supply: %d\n", ret);
> + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v8),
> + "failed to get vdda1v8 supply\n");
> goto clk_disable;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-26 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 14:31 [PATCH] phy: stm32: adopt dev_err_probe for regulators Fabrice Gasnier
2021-10-26 15:50 ` Amelie DELAUNAY [this message]
2021-11-23 5:19 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d889ca2-2538-ea17-5bfd-a3d137115223@foss.st.com \
--to=amelie.delaunay@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox