From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFDE5C531DC for ; Fri, 23 Aug 2024 07:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K9F6H3c2NVmBHPEentW34dAviw4YhqEZNXwnJa/lgq4=; b=cPrAtKvLHie0Wd/hyJYo8XX7Y7 ADxbdIyLpVrazmOurBavCi0NxWcwWlkuuowTrXDHpCFY/GfYm2fu0jJFWrN6iKM7+DRkHCRRUAWFs QfXQ0jOMRF7KOKrVhh4Swu+njGaCBk1HVBFodiX5hthq8EMzP5PhW6MO1LRxiaYPL4732jolbznIs ckdhIgRPyqYj3EKXY+a57OOKEusSAwCs41rg5ekNMM06FKXHyjIuzEir1Vac4HTl+P/KAr/oRbUY3 +end53J3HV4gv+QVFw8QV7D+VDfVLKpjod4r3UoHw0vHdB8qUw8/v6tezsyE4VOhJJ8CyGDz77Kwf CmBVCjjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shP8b-0000000Fj6a-0pUY; Fri, 23 Aug 2024 07:55:13 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shP7s-0000000FiyO-05sw for linux-arm-kernel@bombadil.infradead.org; Fri, 23 Aug 2024 07:54:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=K9F6H3c2NVmBHPEentW34dAviw4YhqEZNXwnJa/lgq4=; b=RwExweHnRKWg1VNNi5UlgdtFpn ySUMqvAoZ6vWPmsWSeGMlML9oaj8EHLLAVIPfiuFulaE1zxHjT/0ZfUiQip4GRQr9uTiOx/umdbZT 5KetPHDX2uBPNRryO/4pewQGFZQOJqr6djAT/M7At1EFnwsvdoKygtkZcPRtLlo9a7NnjtrB2MC3K F4TShHaWJejmwmEh/8Wu+JHDBufKq/w3oIydZ3NVQRkuE4O1spJjp1Ftle6FZjxG06IZGAoK+GSvv ClKH4I9mhyo0v5mimHz3zELK5H7xDCCHLVoIRBU1zuifA0KWg4yzJd802sQCV87MaWsR0CkQv9pUf 8ycWgHZg==; Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shP7f-0000000A68n-2JRM for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 07:54:26 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-58ef19aa69dso1982490a12.3 for ; Fri, 23 Aug 2024 00:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724399650; x=1725004450; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K9F6H3c2NVmBHPEentW34dAviw4YhqEZNXwnJa/lgq4=; b=NR8/N+374fnc/QayDE0KHYEQCoyWtD7TSUK/2GdD6OSs0JPjhECgFNkNvOVWbBzlFh 2TWCpzOshJbrUIxUumUjclGvPNkZydVVTdZlTGJHthRDtlrB5fy0hm58kXddWvN6FgvF 0ISVILjg5cFcioW2k4CkFNg6Ncr+hfdyKQdpTyHONFeBe88hvrvSNX8niQ1Aop0FDY+2 NY2FFmz9fSyJgLpUdALhIeirfap0MLFHpAYGyPTQwURUbXuuKUYrFHLB5mX/Eiz0x8Fk UzCFlHRYJpSMIb4ieZXTFv1ifIZAa8hAWvNhElsDD6wlfWufjrkpNU0PJGbeqJtUhT5R 76FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724399650; x=1725004450; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K9F6H3c2NVmBHPEentW34dAviw4YhqEZNXwnJa/lgq4=; b=FWC3fzadWhoyvPImjM/X8YLMBE/N/e5b1QxDKd0O4/QCVqu8KK7whuFiWb93g9gxtY CmRKxRkIO/jhfX+1cxC7FDPnu7662Stq5Ynk6tLw2IPmv4Y1anTRPD1V5ZfYc2Pf/gxT T2QN3YuaHBh7GfVKACH6FJsPvf+Ph/7g9APCoGVcJdq/hgYZ57XltdWVVkCo0pEUpr9q WyQfpxGm0bkENNjrf3orntvtLAiWsZectrB7kpq9Q3o5XiR5ZQkKDgqJ/Py8mRFp8jgx wLY/w6XpflGKSjq+OaZO88bZHbv8irnwXuWEYslvBeEF3wB2XTor3KHgpGPyWqqAUGDy wSiw== X-Forwarded-Encrypted: i=1; AJvYcCVU49tId3EtiZsB6fYEBwtfc9cCoJ5Gskn0YIszPW4Anz8x4Drte2Zilk5ji4ifJAADJIeCph0sYSFXpkE0/VT1@lists.infradead.org X-Gm-Message-State: AOJu0Yz0FnS7Db6PbhkDbeeIG4oxn+kgHFencaCJ6POPCLSRJdqHzBbf byJFqkrB0zD9qTzt15bS9Mka8DnhEI/fV9ZwFZCG+wX5P9DYjuPUW961IBZHxQ8= X-Google-Smtp-Source: AGHT+IEoQJnrG7rJ9f2StMomCkVPrYJqe5+JdS66nZak9PuSepkUhwJhO+/TtFtd6qLUxl+/AblgVw== X-Received: by 2002:a05:6402:4303:b0:5be:e999:18ab with SMTP id 4fb4d7f45d1cf-5c0891a1ccemr803908a12.23.1724399649843; Fri, 23 Aug 2024 00:54:09 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3eabe1sm1754112a12.52.2024.08.23.00.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 00:54:09 -0700 (PDT) Message-ID: <0d8b1322-cf15-4ed9-b958-06516bbb64c7@tuxon.dev> Date: Fri, 23 Aug 2024 10:54:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] dt-bindings: soc: renesas: renesas,rzg2l-sysc: Add #reset-cells for RZ/G3S Content-Language: en-US To: Conor Dooley Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-3-claudiu.beznea.uj@bp.renesas.com> <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> From: claudiu beznea In-Reply-To: <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_085418_818239_4CF55BBE X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Conor, On 22.08.2024 19:42, Conor Dooley wrote: > On Thu, Aug 22, 2024 at 06:27:47PM +0300, Claudiu wrote: >> From: Claudiu Beznea >> >> The RZ/G3S System controller has registers to control signals that need >> to be de-asserted/asserted before/after different SoC areas are power >> on/off. This signals are implemented as reset signals. For this document >> the #reset-cells property. >> >> Signed-off-by: Claudiu Beznea >> --- >> .../bindings/soc/renesas/renesas,rzg2l-sysc.yaml | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >> index 4386b2c3fa4d..6b0bb34485d9 100644 >> --- a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >> @@ -42,12 +42,28 @@ properties: >> - const: cm33stbyr_int >> - const: ca55_deny >> >> + "#reset-cells": >> + const: 1 >> + >> required: >> - compatible >> - reg >> >> additionalProperties: false >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: renesas,r9a08g045-sysc >> + then: >> + required: >> + - "#reset-cells" > > Given this is new required property on an existing platform, I'd expect > some mention of why it used to be okay to not have this but is now > required. Did firmware or a bootloader stage take things out of reset? On previous SoCs the SYS controller has no support for controlling the signals going to different peripherals (USB, PCIE in case of RZ/G3S). I'll add a note about this on next version. Thank you, Claudiu Beznea > >> + else: >> + properties: >> + "#reset-cells": false >> + >> examples: >> - | >> #include >> -- >> 2.39.2 >>