linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: bdegraaf@codeaurora.org (Brent DeGraaf)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: msm: fix dma usage not to use internal APIs
Date: Fri, 21 Jan 2011 13:37:15 -0800 (PST)	[thread overview]
Message-ID: <0db2f2bf1ef87fbbedecece6ae2c8d33.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <8yaaaiuot1l.fsf@huya.qualcomm.com>

Russell,

Thanks for your comments. Yes, reverting is OK. The writel's are doing the
controller write after the barrier so even though it'll be a little
slower, it will be correct.

Regarding the "unnecessary" pre-invalidate, yeah, I misspoke.  I meant
unnecessary POST-invalidates for non-speculative cpus.  I just checked and
it looks like someone's already put a "FIXME" in the current 2.6.37 source
for those.

We'll look into how much gains we can expect from the relaxed I/O calls
and decide where to go from there.  Thanks for pointing out the api.

Best regards,
Brent

On Fri, January 21, 2011 1:17 pm, David Brown wrote:
> On Fri, Jan 21 2011, Russell King - ARM Linux wrote:
>
>> On Fri, Jan 21, 2011 at 08:13:59AM -0800, Brent DeGraaf wrote:
>
>> This is one of the *biggest* problems I have with people setting up per-
>> platform mailing lists.  It hides information from the rest of the
>> community
>> and causes idiotic practices and abuses such as has happened here.
>
> I have been requesting, internally, that nothing should be sent
> to the linux-arm-msm mailing list that isn't sent to at least
> linux-arm-kernel, and preferrably linux-kernel as well.  It hasn't
> happened yet, but I will be asking people to resend patches if they only
> send them to the MSM list.
>
> As Daniel pointed out, though, I don't think this particular case was
> even discussed.  We're trying to get better.
>
> David
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>


-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-01-21 21:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 23:03 [PATCH] mmc: msm: fix dma usage not to use internal APIs Daniel Walker
2011-01-18 23:05 ` Russell King - ARM Linux
2011-01-20 11:20 ` Daniel Walker
2011-01-20 13:02   ` Russell King - ARM Linux
2011-01-20 13:12     ` Russell King - ARM Linux
2011-01-20 15:08       ` Daniel Walker
2011-01-21 16:13         ` Brent DeGraaf
2011-01-21 16:57           ` Brent DeGraaf
2011-01-21 18:13             ` Russell King - ARM Linux
2011-01-21 19:28           ` Russell King - ARM Linux
2011-01-21 20:45             ` Daniel Walker
2011-01-21 21:17             ` David Brown
2011-01-21 21:37               ` Brent DeGraaf [this message]
2011-01-21 21:42                 ` Russell King - ARM Linux
  -- strict thread matches above, loose matches on Subject: below --
2011-01-18 22:25 Daniel Walker
2011-01-18 22:41 ` Russell King - ARM Linux
2011-01-18 22:48   ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0db2f2bf1ef87fbbedecece6ae2c8d33.squirrel@www.codeaurora.org \
    --to=bdegraaf@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).