Re: [PATCH net-next 2/2] net: xilinx: axienet: Add inline comment for stats_lock mutex definition

Sean Anderson
2025-09-11T14:35:49Z

On 9/11/25 03:28, Suraj Gupta wrote:
> Add inline comment to document the purpose of the stats_lock mutex in
> the axienet_local structure. This mutex protects the hw_stats_seqcount
> sequence counter used for hardware statistics synchronization.
>
> Fixes checkpatch warning:
> CHECK: struct mutex definition without comment
>
> Signed-off-by: Suraj Gupta <suraj.gupta2@amd.com>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h
> index 5ff742103beb..99b9c27bbd60 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet.h
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet.h
> @@ -598,7 +598,7 @@ struct axienet_local {
>
> u64 hw_stat_base[STAT_COUNT];
> u32 hw_last_counter[STAT_COUNT];
> - seqcount_mutex_t hw_stats_seqcount;
> + seqcount_mutex_t hw_stats_seqcount; /* Lock for hardware statistics */
> struct mutex stats_lock;
> struct delayed_work stats_work;
> bool reset_in_progress;

NAK. This is already documented in the kernel-doc comment.