From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAA8EC2BD09 for ; Fri, 12 Jul 2024 21:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3kkkiGO/kyluSOIqlCphcpAU2FE2uhCL82aBXiEAD0A=; b=NAU63vy6lI5KysgDDujDxkadC8 ZboCdTkgkRcllwpzfi5vDVlCjfkgIEEL/yMofazNQi0F2+of1X7RzS9to+IRpEGElGWK2/mgztyDz rdmA1bqfcufsu9dBJSED9Wz8OXIaYpiATd5uBidNXgtU/YrK6wyoSflDKfosu0hkXd3pxa+xE4/rN VxdA6NGf6zYb4ggj4k+MswfTbWgzXiN20Rd2je6qfQNiEWGLxv8s+CL/t5/b3GN5iOwJ2ojW1044k vkNWlvrZDUkkokCuOjNdYWIVbvvQBWNYS+/09sZsNTM/Hdgwm/d2RjmbiN3dnjJr4TYkXAHntgnIf OgRmFjaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSNQJ-00000001FAQ-1J9c; Fri, 12 Jul 2024 21:03:23 +0000 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSNPZ-00000001F3p-2BLx for linux-arm-kernel@lists.infradead.org; Fri, 12 Jul 2024 21:03:06 +0000 Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-5b97a9a9b4bso1086646eaf.0 for ; Fri, 12 Jul 2024 14:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720818156; x=1721422956; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3kkkiGO/kyluSOIqlCphcpAU2FE2uhCL82aBXiEAD0A=; b=IeZxn2U2YyqsbCYN8j8+tkNx9NreKtFu2pf7C/nK0dwgo8KqErQXOtCPkYeptSlbVh rYvox1Jbhrkjt/qnT4M0oSJ8MI+A0dvswTyO9lXGGtSy+VC6XN8s9JfTh3U7UYKcsRa1 023yzy/OuoTwz0jlKPkD+uV1t8rqJaYX35HTA1PBvXE6XjdFvIMTRJ394hYcT6ZoqDX/ KUBm5pMRLKpVNyxMvPuzaDAzjsG37T3YqP1d4VNNnHLaaSx+P3WWbNz/+Ul4LbjiRJMa n7hZe5/Md9aFtvbOqdzWXVYRXFT0SNf6w6BlnKJc9oUOvvXOXJA1xJIbcNsLCGhBmhxq zflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720818156; x=1721422956; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3kkkiGO/kyluSOIqlCphcpAU2FE2uhCL82aBXiEAD0A=; b=segBxUmw+uMLhZO3SNIFqQnDM5ObjZJtZOsAFKEv13KSg/gMBLFm+GhMov3JvBMZRw XtmuBZkylugBlHvESrMULC88GxNP3D8aoRv+rnoWdszwsDmA63EIA0Z6Nr2P+X0ESoGm oQy3tRMDDzAkacMnDvUBpv6Qawt4KQwoH6KDoqtF9yadVv4pa61hszn2PgWFsWg986BX +v7pDJNudt/mYAcIzHoDkPw1hoKuNaK0XvQdKekLPxmOu1DReC+3hYJdGeOPFpATN/4a aUKmE5lpEM0mvVBsXy8lN88w3x1+R6miSGeHpcSq4EBm2SanTDEGQ9hStx3rPcFd1AFR mFbw== X-Forwarded-Encrypted: i=1; AJvYcCVCAunxwWjY5ms3pxvE561pmxFDYZQWD1VbuOUvAEGS1Y+BpmWNtrviyAmVLpfjRYkE8hkytHtoOAYFcz2lzzYoW+7+SSmSNy82rxvdTPn1oBC12hg= X-Gm-Message-State: AOJu0YzJQN4jt65SJl+rGYEqLKcbR5QunNy0Tt5cGrs+Xs6e109P1Uh1 1Uk3vga2LwaQox5aFkUfyGaZ/LGd1LZZMRLgghIYdTJJWVkAFkc/ X-Google-Smtp-Source: AGHT+IE4ALT8roZ1t3XhXtyuD1j5gAIM1uqK7lT52poiDEEjqMhEKkUuMoBMs45Re6mEzDggCZ1AaQ== X-Received: by 2002:a05:6359:740f:b0:1a5:7844:2068 with SMTP id e5c5f4694b2df-1aade0db912mr990636155d.5.1720818155728; Fri, 12 Jul 2024 14:02:35 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-77d621c6300sm6304368a12.51.2024.07.12.14.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 14:02:35 -0700 (PDT) Message-ID: <0dd4e916-6f7f-4427-a217-5b7a290b1b3f@gmail.com> Date: Fri, 12 Jul 2024 14:02:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] Make SCMI transport as standalone drivers To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, ptosi@google.com, dan.carpenter@linaro.org, souvik.chakravarty@arm.com References: <20240710173153.4060457-1-cristian.marussi@arm.com> Content-Language: en-US From: Florian Fainelli In-Reply-To: <20240710173153.4060457-1-cristian.marussi@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_140237_594243_7FB31BD3 X-CRM114-Status: GOOD ( 31.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/10/24 10:31, Cristian Marussi wrote: > Hi all, > > Till now the SCMI transport layer was being built embedded into in the core > SCMI stack. > > Some of these transports, despite being currently part of the main SCMI > module, are indeed also registered with different subsystems like optee or > virtio, and actively probed also by those: this led to a few awkward and > convoluted tricks to properly handle such interactions at boot time in the > SCMI stack. > > Moreover some partner expressed the desire to be able to fully modularize > the transports components. > > This series aim to make all such transports as standalone drivers that can > be optionally loaded as modules. > > In order to do this, at first some new mechanism is introduced to support > this new capability while maintaining, in parallel, the old legacy embedded > transports; then each transport, one by one, is transitioned to be a > standalone driver and finally the old legacy support for embedded transport > is removed. > > Patch [1/8] is a mostly unrelated (but much needed) clean-up from Peng, > which I included in this series to avoid conflicts at merge. > > Patch [2/8] simply collects the existing datagram manipulation helpers in a > pair of function pointers structures, in preparation for later reworks. > > Patch [3/8] adds the bulk of the new logic to the core SCMI stack and then > each existing transport is transitioned to be a standalone driver in > patches 4,5,6,7 while shuffling around the compatibles. (no DT change is > needed of curse for backward compatibility) > While doing this I kept the module authorship in line with the main > author(S) as spitted out by git-blame. > > Finally patch [8/8] removes all the legacy dead code from the core SCMI > stack. > > No new symbol EXPORT has been added. > > The new transport drivers have been tested, as built-in and LKM, as > follows: > > - mailbox on JUNO > - virtio on emulation > - optee on QEMU/optee using Linaro setup > > Exercised using the regular SCMI drivers stack and the SCMI ACS suite, > testing commands, replies, delayed responses and notification. > > Multiple virtual SCMI instances support has been tested too. > > SMC has NOT been tested/exercised at run-time, only compile-tested. > (due to lack of hardware) > > Note that in this new setup, all the probe deferral and retries between the > SCMI core stack and the transports has been removed, since no more needed. > > Moreover the new drivers have been tested also with a fully modularized > SCMI stack, i.e.: > > scmi-core.ko + scmi-module.ko + scmi_transport_*.ko [ + vendor modules ] > > ToBeDone: > - completely remove any dependency at build time at the Kconfig level between > the SCMI core and the transport drivers: so that the transports will be > dependent only on the related subsystems (optee/virtio/mailbox/smc) > (easy to be done but maybe it is not worth...) > - integrate per-platform transport configuration capabilities > (max_rx_timeout_ms & friends..) > > Based on sudeep/for-next/scmi/updates. > > Any feedback, and especially testing (:D) is welcome. Tested-by: Florian Fainelli -- Florian