From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08C72C77B73 for ; Wed, 31 May 2023 09:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=skRdP7oJnQAyw6JQ97iMLHDmdj+Yh57jRLzt/XThsCo=; b=YLL4e12Ytp6Gu1 CehKrXVqly3GfMchvOevWYX6UgH95h9u41O2B9i8roDPvyupRtvUTpvFoC8JdUzEDX2k6KErV8dpn i5mUadNGEbhZkgKvfq5hWNLl+upp6lwdOig0JSJDSEPgt51rpS/4/pvac9NQMFYkVCfuu/5YoN2Fx jjjZYlsFF2YCtlF1G2+fCsNKk6vTEmp9lLnlbRu56gtPih8ifOHqU+/kGuHpO6G2eFANzwQI/+Fog sqpjXt7050OII68FMZMkfVVO4+e3OOnIt5VTXeGvmzSHpshicNOxkFTSP1fDXSggYaIn5XmKzpQZL qX1NyKHRbE9+/RwEhazg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4Hs3-00GpPx-1f; Wed, 31 May 2023 09:11:55 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4Hs0-00GpMi-0p for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 09:11:53 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4f4f8b94c06so4458735e87.1 for ; Wed, 31 May 2023 02:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685524303; x=1688116303; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n+rhtjoI0oVWr4lv7CIl4YpL7WJExUtXF/mZsGUKruo=; b=Iy51vWIAOJEYhuMmlu7qQREiZEWb0ykWvKQrH7g08xAUjpmSTz9580hHm3zNvhwRPO mOOyHvchn3HQLHZwYDg3ldiYL8VsczTo0PSdfcIK6SY6nOuJjlLDoxQ1ouk7rsf7xiuD BSJdPpSZ23dx4Xg1VHUbo4f5Pyh44FzgERtIMQ+aLXdnI5J17cljPgvOVN+FkYh1Z+bz U4VcaucTXmnct4QrLcjkeGQTLHxV89MU1WwEyukaaTyraCFqrusVXJZBFmv82V1p3GLV hzKKAboSdcxG9c3/2ZsCLitpsJEy66ioLd0f1oKlXimzwzUhBs+NJIyosKNn0OZTeGoK k/+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685524303; x=1688116303; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n+rhtjoI0oVWr4lv7CIl4YpL7WJExUtXF/mZsGUKruo=; b=Vw4golWjsM9f6TYVVgXzR44Bn+fXTtq74FO7oYL5sK7WiIHQfHa25FHgG5qtwweEsO k2NMiP/3wtYSX3WGGE0j68qgrBo9lSU0trZ2mf1mCATt/+mAYqNQSJysI0r9Bw2Gqkil DTh8EsZ6QNhQauvH5JRnpnG7b8sOPPrPEq3BbYx4y1Yjdqvmkev5/Q8lFGtJiRN/Fy8H 2oxQuXGsuj07GJm8AD9dDLQFLds1OjzmAerLqzJCk9SFowgZ0dZk/66gENMk9PjjO2XH N12R5QID89Io20MtWmm8cHEx/Hz8xhRtXOAfY2CHGJn3WU7Fz7z9+uS8U1u62uNP+s3M Ksig== X-Gm-Message-State: AC+VfDx3Xx7AMOCHD98/csWEVu8wRRf7Vvbx4wRnasCUi1SLTPIvg/sk XWMfrQQCEXmAWuN5j73E5LiUMA== X-Google-Smtp-Source: ACHHUZ6xBAZjyXT/YB/xNZ0KdSNoP9qtdld3FAw0nIeEga8FmMgG+PzrRjktTTnIcrWrcPyIGTzFqw== X-Received: by 2002:a05:6512:243:b0:4f3:a485:919a with SMTP id b3-20020a056512024300b004f3a485919amr2147076lfo.57.1685524303455; Wed, 31 May 2023 02:11:43 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id a19-20020a50ff13000000b005148f0e8568sm5124081edu.39.2023.05.31.02.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 02:11:42 -0700 (PDT) Message-ID: <0de8cecf-ec36-9300-656b-2c073f60c407@linaro.org> Date: Wed, 31 May 2023 11:11:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/3] dt-bindings: regulator: pca9450: add pca9451a support Content-Language: en-US To: Frieder Schrempf , Joy Zou , ping.bai@nxp.com, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230531065724.3671795-1-joy.zou@nxp.com> <20230531065724.3671795-2-joy.zou@nxp.com> <25e6d735-f191-68a1-84cc-d7e1ae4c3217@kontron.de> From: Krzysztof Kozlowski In-Reply-To: <25e6d735-f191-68a1-84cc-d7e1ae4c3217@kontron.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_021152_303255_E852C0BF X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/05/2023 09:22, Frieder Schrempf wrote: > On 31.05.23 08:56, Krzysztof Kozlowski wrote: >> On 31/05/2023 08:57, Joy Zou wrote: >>> Update pca9450 bindings. >>> >>> Signed-off-by: Joy Zou >>> --- >> >> Subject prefix is: regulator: dt-bindings: pca9450: > > Is there some way to have this consistent for all subsystems? Most > subsystems seem to use: > > dt-bindings: [subsystem]: > > But some use: > > [subsystem]: dt-bindings: > > Casual contributors (like me) will very often get it wrong on the first > try. Examining the history is extra effort that could be avoided and > often doesn't provide a definite hint as you find both variations in the > past. > > Can we standardize this and make checkpatch validate the subject line? I understand your pain. :) My expectation is just to have "dt-bindings:" prefix. It can be anywhere - first or second, doesn't matter to me. Then there is the generic rule that subsystem prefix should be the first and here there is a disagreement between some folks. Most maintainers either don't care or assume bindings are separate subsystem. Mark (spi, ASoC, regulator) and media-folks say it is not separate subsystem (real subsystem are spi, regulator etc), thus they want their subsystem name as the first prefix. It sounds reasonable. Anyway it does not contradict DT bindings maintainers expectation to have somewhere "dt-bindings:" prefix. My comment was only to help you and there is no need to resend. I think Mark when applying will drop "dt-bindings" prefix if is before regulator, though. Life, no big deal. Whether checkpatch can do this? Sure, quite likely, one just need some Perl-foo to add such rule. :) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel