From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene@kernel.org (Kukjin Kim) Date: Wed, 24 Jul 2013 11:20:33 +0900 Subject: [PATCH 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos In-Reply-To: References: <1372054438-15693-1-git-send-email-sachin.kamat@linaro.org> <0ad601ce868c$d88bff40$89a3fdc0$@org> <3136364.6D0qu7zGk3@amdc1227> <51ED89CA.2040908@gmail.com> Message-ID: <0df901ce8814$601ab6d0$20502470$@org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sachin Kamat wrote: [...] > >>>>> Hmm, BTW, I'm wondering why it is 288 not 285 or other specific > >>> > >>> > >>> number... > >>> > >>>> I wasn't really sure if we can have any number there. I chose the > >>>> closest one (288) which was already used by other platform. > >>>> If there is no problem to use 285 itself then I can resend with that > >>>> number. Please let me know. > >>> > >>> > >>> If there is no reason, please don't use bigger value than necessary > one. > >> > >> > >> Hmm, what about some GPIO expanders that would require bigger GPIO > address > >> space? I would reserve some space just in case, i.e. define this value > to > >> be > >> the highest number of GPIOs on all Exynos SoCs + some extra, like 32 or > >> 64. > > > > > > That sounds like a good idea. IIRC I once had to increase ARCH_NR_GPIO > to > > make the wm8994 GPIO controller working. The wm8994 driver also handles > > WM1811 audio codec that some Exynos development boards are shipped with. > > Looks like a valid point. > > Kukjin, > Let me know your opinion about this before I respin the patch. > Agreed, let's use 512 including some extras, I'm not sure what value for some GPIO expanders is reasonable at this moment, though. It should be fine on current EXYNOS platforms. Thanks, Kukjin