From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 880BDC04A95 for ; Sat, 22 Oct 2022 11:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u1zd2z4w28VDswnmnQFPnAJGvQyAoxBG0nGX3wsVeto=; b=h1FKLu0Dh/JEYt bX5toZFIbCSTY17ZvA0yfjcww7kbVSwrNCHpap7+YtF6J9Au5LkYiT7Nd41olfMwKw5X3vfjvDU7X N3hhdhwb0BiOPerIv/APajYBeV0668TfC6pnAp/b/zjxnIj98pCLwVUyNVCx1o9GDTOOJP/GvnFg1 Q016lGalGbj6EhxzBXfVSrVHPCwnAog5OwlyqtEqEZnTOU0EnTe5nXUTKHs/zhYeX/7jhiQCAxw4c 8mqpFJWwsF4RuskdL0oiExC7Ou69imegPOZ9jsoxvPtgADhsYAV2O5Mg3SLxG5ItWAACAlnyKhqGo 7ZOE7jdkU2990O/K71cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omD1r-00CScn-9Q; Sat, 22 Oct 2022 11:51:03 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omD1n-00CSbr-6w for linux-arm-kernel@lists.infradead.org; Sat, 22 Oct 2022 11:51:02 +0000 Received: by mail-pj1-x1029.google.com with SMTP id h14so4542704pjv.4 for ; Sat, 22 Oct 2022 04:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gf6dQ9LAjbku9tNlXYs6K70y6uNvlcEqkF4aaiHp/zU=; b=E4aU0a07cwaHSsoed6bDFBy4lpC14k12UJKZDHn0WaJSzmsuK4OC57Uw++peddyAaT +ousCegB9LKUF9V+5fZ3aHQSpVDIOKlFEX/iAo8ZG6/sO4fqBW4Wcn503EtjHs5hly9k B7nhHt0inDgpVQqy1Zp9JtPaAFV9GM1By4hzyBsivJz0/9DNR8j4Mw6x8h+e3C38pQDH UtdVk+0AhVsn+kj3Pn2HbBg0yMzxK8u/9sVNaimy+QjSx/SfpQrWpBdbMbGHFrkGh6md k99oi+srIQRTDKACAPKhsmUAOXB0JcxERn55nOuQeYMsaCb8BKCLbSeXGCe9o0hj9TW2 qa0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gf6dQ9LAjbku9tNlXYs6K70y6uNvlcEqkF4aaiHp/zU=; b=161qlwy4gL3AxtFXrST+PWkVFmvgBz2Xr0CL1NKntDz3SLztQCC0XIk+gPe3h5YSHy Y7FvDsLBT71S/in0iuNbShlfZJ/H8NP2FSn/n+Kts6Ldf/Owdp9x7SDwmEfVkeSrZ/kc ikyo25AxpPcH7x3DO1kZzejJHbViTebmQ+Ru1YOZuVJY0pCUsm/T3xxg7M9Mwh4MVyS5 mWQi6jGjZ38y9JOZSajERSQX+tCbdPGmB0tyCdLFAsHcSyq06bbXlmHOAOgwI5Umq8gj V5bnl6KYNe5FKOGaY3ecAuktW8FlNQLxZn8STvtmP+qKlEXHorZxSxwfPKBLXew5R4oQ RlFg== X-Gm-Message-State: ACrzQf26O4xXdRT+IoJqQAxy0hmeLlD1a/rPUSSLdynOdaGA1tB8903T oYLsowgTeOfI/soyMc3uKWc= X-Google-Smtp-Source: AMsMyM5AmJOLPRTfil+lrVbmN2PHNf0wLvVe29ngBB+ANhMjqQEj59AKauVj1+TUcH4vXRO/S7naMg== X-Received: by 2002:a17:902:bd98:b0:182:631b:7dd5 with SMTP id q24-20020a170902bd9800b00182631b7dd5mr23531125pls.165.1666439452757; Sat, 22 Oct 2022 04:50:52 -0700 (PDT) Received: from [172.30.1.63] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id x11-20020a17090a6b4b00b0020ddea12227sm1223171pjl.55.2022.10.22.04.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Oct 2022 04:50:52 -0700 (PDT) Message-ID: <0e0eff12-d8ea-72e9-d135-4259dda9a750@gmail.com> Date: Sat, 22 Oct 2022 20:50:46 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 11/21] clk: remove s3c24xx driver Content-Language: en-US To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, Ben Dooks , Simtec Linux Team , Arnd Bergmann , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org References: <20221021202254.4142411-1-arnd@kernel.org> <20221021203329.4143397-11-arnd@kernel.org> From: Chanwoo Choi In-Reply-To: <20221021203329.4143397-11-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221022_045059_325585_FDCA9790 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On 22. 10. 22. 05:27, Arnd Bergmann wrote: > From: Arnd Bergmann > > The s3c24xx platform is gone, so the clk driver can be removed as > well. > > Signed-off-by: Arnd Bergmann > --- > MAINTAINERS | 1 - > drivers/clk/samsung/Kconfig | 32 -- > drivers/clk/samsung/Makefile | 4 - > drivers/clk/samsung/clk-s3c2410-dclk.c | 440 --------------------- > drivers/clk/samsung/clk-s3c2410.c | 446 ---------------------- > drivers/clk/samsung/clk-s3c2412.c | 254 ------------ > drivers/clk/samsung/clk-s3c2443.c | 438 --------------------- > include/linux/platform_data/clk-s3c2410.h | 19 - > 8 files changed, 1634 deletions(-) > delete mode 100644 drivers/clk/samsung/clk-s3c2410-dclk.c > delete mode 100644 drivers/clk/samsung/clk-s3c2410.c > delete mode 100644 drivers/clk/samsung/clk-s3c2412.c > delete mode 100644 drivers/clk/samsung/clk-s3c2443.c > delete mode 100644 include/linux/platform_data/clk-s3c2410.h (snip) I think that it should remove the pll code related to s3c24xx as following: diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c index fe383471c5f0..0daea2aadce4 100644 --- a/drivers/clk/samsung/clk-pll.c +++ b/drivers/clk/samsung/clk-pll.c @@ -1061,48 +1061,6 @@ static void samsung_s3c2410_upll_disable(struct clk_hw *hw) samsung_s3c2410_pll_enable(hw, 7, false); } -static const struct clk_ops samsung_s3c2410_mpll_clk_min_ops = { - .recalc_rate = samsung_s3c2410_pll_recalc_rate, - .enable = samsung_s3c2410_mpll_enable, - .disable = samsung_s3c2410_mpll_disable, -}; - -static const struct clk_ops samsung_s3c2410_upll_clk_min_ops = { - .recalc_rate = samsung_s3c2410_pll_recalc_rate, - .enable = samsung_s3c2410_upll_enable, - .disable = samsung_s3c2410_upll_disable, -}; - -static const struct clk_ops samsung_s3c2440_mpll_clk_min_ops = { - .recalc_rate = samsung_s3c2440_mpll_recalc_rate, - .enable = samsung_s3c2410_mpll_enable, - .disable = samsung_s3c2410_mpll_disable, -}; - -static const struct clk_ops samsung_s3c2410_mpll_clk_ops = { - .recalc_rate = samsung_s3c2410_pll_recalc_rate, - .enable = samsung_s3c2410_mpll_enable, - .disable = samsung_s3c2410_mpll_disable, - .round_rate = samsung_pll_round_rate, - .set_rate = samsung_s3c2410_pll_set_rate, -}; - -static const struct clk_ops samsung_s3c2410_upll_clk_ops = { - .recalc_rate = samsung_s3c2410_pll_recalc_rate, - .enable = samsung_s3c2410_upll_enable, - .disable = samsung_s3c2410_upll_disable, - .round_rate = samsung_pll_round_rate, - .set_rate = samsung_s3c2410_pll_set_rate, -}; - -static const struct clk_ops samsung_s3c2440_mpll_clk_ops = { - .recalc_rate = samsung_s3c2440_mpll_recalc_rate, - .enable = samsung_s3c2410_mpll_enable, - .disable = samsung_s3c2410_mpll_disable, - .round_rate = samsung_pll_round_rate, - .set_rate = samsung_s3c2410_pll_set_rate, -}; - /* * PLL2550x Clock Type */ @@ -1530,24 +1488,6 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx, else init.ops = &samsung_pll46xx_clk_ops; break; - case pll_s3c2410_mpll: - if (!pll->rate_table) - init.ops = &samsung_s3c2410_mpll_clk_min_ops; - else - init.ops = &samsung_s3c2410_mpll_clk_ops; - break; - case pll_s3c2410_upll: - if (!pll->rate_table) - init.ops = &samsung_s3c2410_upll_clk_min_ops; - else - init.ops = &samsung_s3c2410_upll_clk_ops; - break; - case pll_s3c2440_mpll: - if (!pll->rate_table) - init.ops = &samsung_s3c2440_mpll_clk_min_ops; - else - init.ops = &samsung_s3c2440_mpll_clk_ops; - break; case pll_2550x: init.ops = &samsung_pll2550x_clk_ops; break; diff --git a/drivers/clk/samsung/clk-pll.h b/drivers/clk/samsung/clk-pll.h index a9892c2d1f57..5d5a58d40e7e 100644 --- a/drivers/clk/samsung/clk-pll.h +++ b/drivers/clk/samsung/clk-pll.h @@ -25,9 +25,6 @@ enum samsung_pll_type { pll_6552, pll_6552_s3c2416, pll_6553, - pll_s3c2410_mpll, - pll_s3c2410_upll, - pll_s3c2440_mpll, pll_2550x, pll_2550xx, pll_2650x, @@ -56,24 +53,6 @@ enum samsung_pll_type { .sdiv = (_s), \ } -#define PLL_S3C2410_MPLL_RATE(_fin, _rate, _m, _p, _s) \ - { \ - .rate = PLL_VALID_RATE(_fin, _rate, \ - _m + 8, _p + 2, _s, 0, 16), \ - .mdiv = (_m), \ - .pdiv = (_p), \ - .sdiv = (_s), \ - } - -#define PLL_S3C2440_MPLL_RATE(_fin, _rate, _m, _p, _s) \ - { \ - .rate = PLL_VALID_RATE(_fin, _rate, \ - 2 * (_m + 8), _p + 2, _s, 0, 16), \ - .mdiv = (_m), \ - .pdiv = (_p), \ - .sdiv = (_s), \ - } - #define PLL_36XX_RATE(_fin, _rate, _m, _p, _s, _k) \ { \ .rate = PLL_VALID_RATE(_fin, _rate, \ -- Best Regards, Samsung Electronics Chanwoo Choi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel