From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E9FC10F13 for ; Tue, 16 Apr 2019 10:31:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61FCE20693 for ; Tue, 16 Apr 2019 10:31:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GsAlcYs5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61FCE20693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k+JQqrYhpFvfdY1vzakM3enSwUhYUsQYODG0EN6+TjE=; b=GsAlcYs5znRkNrUC3sliaEa9T 6WRKwr95nwwSOnudT4LgRXUPOfIDr6zBLwNDksRecS0i//QMpMHl4fBWXXD0eYaOylrql5v7f5iOW kKZkKuVRiRnmoqw4NN2BldW0rvNuPajCN1/6jw/eTGGrBUGMQe6FdMvVDUkr6G8d8xkpD3RXAkyA+ ndY5Ceid9lHVMPPOtnloMwV92C7Ka8tlryOoJ0LYW2PdutcDcHQN7YMqE7HFSUsYT75PtKZmWlzR9 dmMWzwN8XBSl4C5J5whzCX+fmrlxhVa4FlJeh7vw82QcjMrIQICqCV8UeF6kLDEilmQccNyuXiO8g JD8Z7nZxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLNX-0001CI-Jb; Tue, 16 Apr 2019 10:31:51 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLNU-0001Bz-In for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 10:31:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B46C15A2; Tue, 16 Apr 2019 03:31:43 -0700 (PDT) Received: from [10.37.12.114] (unknown [10.37.12.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 40F493F68F; Tue, 16 Apr 2019 03:31:41 -0700 (PDT) Subject: Re: [PATCH v2 27/36] drivers: Add a generic helper to match device by fwnode handle To: rafael@kernel.org References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-28-git-send-email-suzuki.poulose@arm.com> From: Suzuki K Poulose Message-ID: <0e152d7f-4b5f-0b0e-ac25-94b6cefa6901@arm.com> Date: Tue, 16 Apr 2019 11:34:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_033148_625235_186DE406 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mathieu.poirier@linaro.org, gregkh@linuxfoundation.org, coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rafael On 04/16/2019 11:20 AM, Rafael J. Wysocki wrote: > On Mon, Apr 15, 2019 at 6:06 PM Suzuki K Poulose wrote: >> >> Make the device_fwnode_match() a generic helper to match device >> by fwnode handle for use with bus_find_device(). This will be >> also used by coresight. >> >> Cc: Greg Kroah-Hartman >> Cc: "Rafael J. Wysocki" >> Signed-off-by: Suzuki K Poulose > > Can you resend this with a CC to linux-acpi@vger.kernel.org, please? > > There's some device properties material for 5.2 collected already and > it would be good to keep all that together. > Sure, will do. Btw, I have a question w.r.t the match function. We have : class_find_device(struct class *class, struct device *start, const void *data, int (*match)(struct device *, const void *)) and bus_find_device(struct bus_type *bus, struct device *start, void *data, int (*match)(struct device *dev, void *data)) Just because the "match" has slightly different constraint for the data (i.e, const void * vs void *), we can't reuse the same match function for class_find_device. Do you think we should converge the types to reuse the same match every where (Of course in a separate patch series) ? Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel