From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76373C433F5 for ; Mon, 10 Jan 2022 18:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vES+S1kspXWq7z+jGaaGI8qgcCxPu6g8KY6fzAHWJo8=; b=v9BhF5qGlvEJ8EqiUkxLIjmCSF w0WpEGtkO0yE+CPrerLMBHjD26M6qa6TOntbcXsYApyWi75vz/N5WYZqLg23lGWxPuDGCyktBT2wk z6qRYxdnmo2uKzk0vX4tBretgd4vuTm2P1ji29VK55jE0INqDaysRvU7FpFK8ep0ejTohyi8nGefN 4KeIBkQR+JUEkBQlkDCO0s4jWaiyzwE6qR8qM7G921CnCeoEgyQbIVNb67Rilb1oV8oLqvHS5AVbR /8AhgAR+5JDOVoMEg0DebACgtTbSgNpp8dW6IX374i2TMIyJ7XCBZ7DbBJmFX7KPIalJwQ0lpeTtO 7qRW90xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zlH-00CrTu-4G; Mon, 10 Jan 2022 18:51:19 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zlD-00CrS2-Fm for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 18:51:16 +0000 Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JXjW203KSz6H7ZD; Tue, 11 Jan 2022 02:47:42 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 19:51:12 +0100 Received: from [10.47.24.251] (10.47.24.251) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 18:51:10 +0000 Subject: Re: [PATCH v4 04/48] perf stat: Switch aggregation to use for_each loop To: Ian Rogers , Andi Kleen , "Jiri Olsa" , Namhyung Kim , Kajol Jain , "Paul A . Clarke" , "Arnaldo Carvalho de Melo" , Riccardo Mancini , Kan Liang , Peter Zijlstra , "Ingo Molnar" , Mark Rutland , "Alexander Shishkin" , , , "Vineet Singh" , James Clark , "Mathieu Poirier" , Suzuki K Poulose , Mike Leach , Leo Yan , , , CC: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-5-irogers@google.com> From: John Garry Message-ID: <0e26524c-9f4c-b351-2498-0a56bc86b4ee@huawei.com> Date: Mon, 10 Jan 2022 18:50:54 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20220105061351.120843-5-irogers@google.com> Content-Language: en-US X-Originating-IP: [10.47.24.251] X-ClientProxiedBy: lhreml743-chm.china.huawei.com (10.201.108.193) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_105115_720373_5067961E X-CRM114-Status: UNSURE ( 9.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/01/2022 06:13, Ian Rogers wrote: > + cpus = evsel__cpus(evsel); > + perf_cpu_map__for_each_cpu(cpu, idx, cpus) { It seems a common pattern to evaluate cpus and use in perf_cpu_map__for_each_cpu() - is it possible to make a macro to accept evsel and create cpus, like perf_evsel__for_each_cpu()? > + if (cpu_map__compare_aggr_cpu_id(config->aggr_get_id(config, cpus, idx), > + id)) > + return cpu; > } > return 0; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel