From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2481BC43331 for ; Sun, 10 Nov 2019 22:53:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E39AF206C3 for ; Sun, 10 Nov 2019 22:53:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LjnfctVV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E39AF206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mleia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aGPsQVb2NAulG9GmnC+lIQkxjdLjfSa5DE9PDViZYqk=; b=LjnfctVVby4+sL LY6a9mjmfeEFx+WGMjyHtBaXpig81jB84z3L2W17s05GymlYIQHc5R3zl1PUX7VS4CDzSVwc0uls6 QbGZtdAHZ6Pb6kzHFC/fH0I50Rgj+PIWFc1D1N9RikKLyubq4/JugOSyFEg1eUHXirXuderoEN/SS S3kkM2X96VWRvb9ejT5ZoFF84LeF/kHUfduOjHlyLQGZmYPU+TaxHYjnfxlsWMquf41h/4e9Eo4Ds DJsx9SGTqu+4czO17FlvKviGhs2M3YQ/wtbamtmF7JYcAWyrTMeLqmozfenFnCdndvDqTdg1vmKD/ YyPAG6ydXP6ftWbtY4Bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTw5L-00068c-TT; Sun, 10 Nov 2019 22:53:31 +0000 Received: from mleia.com ([178.79.152.223] helo=mail.mleia.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTw5I-000687-BJ for linux-arm-kernel@lists.infradead.org; Sun, 10 Nov 2019 22:53:29 +0000 Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 8AC713AE374; Sun, 10 Nov 2019 22:53:23 +0000 (UTC) Subject: Re: [PATCH] usb: gadget: udc: lpc32xx: don't dereference ep until it has been null checked To: Colin King , Felipe Balbi , Greg Kroah-Hartman , Sylvain Lemieux , Roland Stigge , Arnd Bergmann , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20191110221413.22321-1-colin.king@canonical.com> From: Vladimir Zapolskiy Message-ID: <0e5105e3-768e-c8eb-dd73-d097bb7edfb2@mleia.com> Date: Mon, 11 Nov 2019 00:53:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20191110221413.22321-1-colin.king@canonical.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20191110_225323_591453_2C3ACE0D X-CRM114-Status: UNSURE ( 7.74 ) X-CRM114-Notice: Please train this message. /bin/ln: failed to access 'reaver_cache/texts/20191110_225323_591453_2C3ACE0D': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191110_225323_591453_2C3ACE0D X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/11/2019 12:14 AM, Colin King wrote: > From: Colin Ian King > > The pointer ep is currently being dereferenced when initializing pointer > udc before ep is being null checked. Fix this by only dereferencing > ep after it has been null checked. > > Addresses-Coverity: ("Dereference before null check") > Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx") > Signed-off-by: Colin Ian King Acked-by: Vladimir Zapolskiy -- Best wishes, Vladimir _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel