From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Eddie Hung <eddie.hung@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH 06/13] usb: xhci-mtk: support ip-sleep wakeup for MT8183
Date: Mon, 22 Mar 2021 11:54:22 +0300 [thread overview]
Message-ID: <0e660a28-d66f-a23e-3fad-8fa37b6df1b1@gmail.com> (raw)
In-Reply-To: <1616382832-28450-6-git-send-email-chunfeng.yun@mediatek.com>
Hello!
On 22.03.2021 6:13, Chunfeng Yun wrote:
> Add support ip-sleep wakeup for MT8183, it's similar to MT8173,
^ for
> and it's also a specific one, but not follow IPM rule.
Following?
> Due to the index 2 already used by many DTS, it's better to keep
> it unchanged for backward compatible, treat specific ones without
Compatibility.
> following IPM rule as revision 1.x, meanwhile reserve 3~10 for
> later revision that follows the IPM rule.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 09f2ddbfe8b9..8ba1f914cb75 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -57,12 +57,19 @@
> #define CTRL_U2_FORCE_PLL_STB BIT(28)
>
> /* usb remote wakeup registers in syscon */
> +
> /* mt8173 etc */
> #define PERI_WK_CTRL1 0x4
> #define WC1_IS_C(x) (((x) & 0xf) << 26) /* cycle debounce */
> #define WC1_IS_EN BIT(25)
> #define WC1_IS_P BIT(6) /* polarity for ip sleep */
>
> +/* mt8183 */
> +#define PERI_WK_CTRL0 0x0
> +#define WC0_IS_C(x) (((x) & 0xf) << 28) /* cycle debounce */
> +#define WC0_IS_P BIT(12) /* polarity */
> +#define WC0_IS_EN BIT(6)
> +
> /* mt2712 etc */
> #define PERI_SSUSB_SPM_CTRL 0x0
> #define SSC_IP_SLEEP_EN BIT(4)
> @@ -71,6 +78,7 @@
> enum ssusb_uwk_vers {
> SSUSB_UWK_V1 = 1,
> SSUSB_UWK_V2,
> + SSUSB_UWK_V11 = 11, /* specific revision 1.1 */
SSUSB_UWK_V1_1, maybe?
[...]
MBR, Sergei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-22 8:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 3:13 [PATCH 01/13] dt-bindings: usb: mtk-xhci: support property usb2-lpm-disable Chunfeng Yun
2021-03-22 3:13 ` [PATCH 02/13] dt-bindings: usb: mtk-xhci: add support wakeup for mt8183 and mt8192 Chunfeng Yun
2021-03-22 3:13 ` [PATCH 03/13] dt-bindings: usb: mtu3: " Chunfeng Yun
2021-03-22 3:13 ` [PATCH 04/13] usb: xhci-mtk: fix broken streams issue on 0.96 xHCI Chunfeng Yun
2021-03-22 3:13 ` [PATCH 05/13] usb: xhci-mtk: support quirk to disable usb2 lpm Chunfeng Yun
2021-03-22 3:13 ` [PATCH 06/13] usb: xhci-mtk: support ip-sleep wakeup for MT8183 Chunfeng Yun
2021-03-22 8:54 ` Sergei Shtylyov [this message]
2021-03-23 2:39 ` Chunfeng Yun
2021-03-23 9:07 ` kernel test robot
2021-03-22 3:13 ` [PATCH 07/13] usb: xhci-mtk: add support ip-sleep wakeup for mT8192 Chunfeng Yun
2021-03-22 8:58 ` Sergei Shtylyov
2021-03-23 2:39 ` Chunfeng Yun
2021-03-22 3:13 ` [PATCH 08/13] usb: xhci-mtk: drop CONFIG_OF Chunfeng Yun
2021-03-22 3:13 ` [PATCH 09/13] usb: xhci-mtk: remove MODULE_ALIAS Chunfeng Yun
2021-03-22 3:13 ` [PATCH 10/13] usb: mtu3: support ip-sleep wakeup for MT8183 Chunfeng Yun
2021-03-22 8:57 ` Sergei Shtylyov
2021-03-23 2:40 ` Chunfeng Yun
2021-03-22 17:51 ` kernel test robot
2021-03-23 9:14 ` kernel test robot
2021-03-22 3:13 ` [PATCH 11/13] usb: mtu3: add support ip-sleep wakeup for MT8192 Chunfeng Yun
2021-03-22 3:13 ` [PATCH 12/13] usb: mtu3: drop CONFIG_OF Chunfeng Yun
2021-03-22 3:13 ` [PATCH 13/13] arm64: dts: mt8183: update wakeup register offset Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e660a28-d66f-a23e-3fad-8fa37b6df1b1@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).