From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 376E6CEBF78 for ; Fri, 27 Sep 2024 05:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hmM9nard7C236jMcmPNo75yk3HSeZ0dMHaCt6a0p4X4=; b=wSw8eHIW9u4IOZoBTk1S33qGKD +ZqN11mugg3Fr+1g2oBuDgJEes2b8rF+1UeMd3MoWEjUU3KobSOr29gW/mEHtahk0Sl+nvYU8bArT AMavPBWCc5LVWRIpoKkBDkXnUG/gmsGI+zwI9uMZ0+JVlQ8WJ/bKxCo0KFuqPIvVw4oh2DKd2uJFp 6tH+ilB0VOtbY15JpLof1Gw3rC0l62US6ITmgj5iDoDpvSbaa+pZE1KZkJOs10a3YI/6P0CLWhxv8 vicMYrfMxit1A5iH+yxg1kdcCNuu77bh2nPjLtAVfCDuWUhu/UcDKt34N2SgMIoj63Twr68mWzcRQ etWVUC0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1su3mZ-0000000A5hP-0dyI; Fri, 27 Sep 2024 05:44:49 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1su3lL-0000000A5YW-1nIq for linux-arm-kernel@lists.infradead.org; Fri, 27 Sep 2024 05:43:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1727415809; bh=hmM9nard7C236jMcmPNo75yk3HSeZ0dMHaCt6a0p4X4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=I6LrnbrcjS+t9cKS5+t1QWpHB3ZXrTfGOVlCEgIdfLk6TaC0UZAKI2xk1rP6Z+73i JxTyr/pUssnJRw4c0sBqQOQ9xV9S2jn50Qw5A0XaME0quauF1Hz+xboRulGZlEGQ2i bv16X3GZF1ftMpVT+XqjLazEvmZW89kll1D3jqyoVq42KXecBi9rjCG5XZfoALQvV/ B0/Y6CV4Q9A+0xjOrAbZPbwFKFSjU9Ql/G+9dv72pEOS8gU5lymdPLwnJenbn3IEx3 AIQRMK48KR4HjPCKCQdkbG5vP9VnzrTSNAP3H/PE5QfnObT3jQ4DKnmFcRMacrW2l6 FdCAxfwYFlLxg== Received: from [192.168.68.112] (ppp118-210-187-73.adl-adc-lon-bras34.tpg.internode.on.net [118.210.187.73]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id D890965029; Fri, 27 Sep 2024 13:43:28 +0800 (AWST) Message-ID: <0e9483a19f916982ba6996b81c2f1254da3801f3.camel@codeconstruct.com.au> Subject: Re: [PATCH v1 2/5] ARM: dts: aspeed: yosemite4: remove led gpio pca9552 on fan boards From: Andrew Jeffery To: Delphine CC Chiu , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: Ricky CX Wu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Fri, 27 Sep 2024 15:13:26 +0930 In-Reply-To: <20240926032821.4171466-3-Delphine_CC_Chiu@wiwynn.com> References: <20240926032821.4171466-1-Delphine_CC_Chiu@wiwynn.com> <20240926032821.4171466-3-Delphine_CC_Chiu@wiwynn.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_224331_691435_AE082B4B X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu >=20 > Remove led gpio contorller: pca9552 on fan boards since there is > no binding document for pca9552 currently. That's not true, there is, just it's not converted to dt-schema: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc= umentation/devicetree/bindings/leds/leds-pca955x.txt?h=3Dv6.11 So the nodes can stay, though they probably generate warnings. The right way to fix this is to convert the binding document. Andrew >=20 > Signed-off-by: Ricky CX Wu > Signed-off-by: Delphine CC Chiu > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 18 ------------------ > 1 file changed, 18 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b= /arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 04f6378c2b5f..430c28bdd314 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -525,15 +525,6 @@ eeprom@52 { > compatible =3D "atmel,24c128"; > reg =3D <0x52>; > }; > - > - gpio@61 { > - compatible =3D "nxp,pca9552"; > - reg =3D <0x61>; > - #address-cells =3D <1>; > - #size-cells =3D <0>; > - gpio-controller; > - #gpio-cells =3D <2>; > - }; > }; > =20 > imux31: i2c@1 { > @@ -577,15 +568,6 @@ eeprom@52 { > compatible =3D "atmel,24c128"; > reg =3D <0x52>; > }; > - > - gpio@61 { > - compatible =3D "nxp,pca9552"; > - reg =3D <0x61>; > - #address-cells =3D <1>; > - #size-cells =3D <0>; > - gpio-controller; > - #gpio-cells =3D <2>; > - }; > }; > }; > };