From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC37DC001B0 for ; Thu, 10 Aug 2023 05:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+P8OFtZwpq6jETADpO1aRpf+hdjhBT3t+tKV2NLXM3Q=; b=XtY2aklpSYOsyy 2pFZKP7MX2mCV2tZSqI0R65ycoQ2XlG3JATt2JK6m+YLYPcyjopYzwGvubB+GOm9aqSSE4yboHIYZ ivnGa5lZ7FFeaH5hgffbVosT9rzSxni9oq1fsXrwdTg/ddyjHHrGTM9Kc1PBVk6jq+YoEZgvLmDCZ midyAd7xHsiEacnL8wpzepX0cVQDVoqsgKAskWMYaCQNFkSFIMbPg97incfcVMvs7i5BODs8R9Vak V7U0UqRsm/9QX3JzbaXMz/QTae+V660yQC8J0xxkLhlWdnIYK8oTkeSTf3ocseMVjeLm2pSBsDrs5 bKkuPrZMCqK8+W6K9JHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTxrz-006Xfn-1H; Thu, 10 Aug 2023 05:05:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTxrw-006Xeg-0j for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 05:05:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 89704D75; Wed, 9 Aug 2023 22:06:32 -0700 (PDT) Received: from [10.162.42.7] (unknown [10.162.42.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D8FF33F64C; Wed, 9 Aug 2023 22:05:45 -0700 (PDT) Message-ID: <0ed54ef6-e502-7c33-6e3f-08de76786245@arm.com> Date: Thu, 10 Aug 2023 10:35:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V13 - RESEND 01/10] drivers: perf: arm_pmu: Add new sched_task() callback Content-Language: en-US To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com Cc: Mark Brown , James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org References: <20230711082455.215983-1-anshuman.khandual@arm.com> <20230711082455.215983-2-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: <20230711082455.215983-2-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230809_220556_313643_8DA1FE3F X-CRM114-Status: GOOD ( 21.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Will, I am just wondering - would it be possible for you to take this pre-requisite patch stand alone for the upcoming merge window. This has been acked by Mark earlier. Besides, I am also working on your other suggestions on the series, and will respond soon. Thank you. - Anshuman On 7/11/23 13:54, Anshuman Khandual wrote: > This adds armpmu_sched_task(), as generic pmu's sched_task() override which > in turn can utilize a new arm_pmu.sched_task() callback when available from > the arm_pmu instance. This new callback will be used while enabling BRBE in > ARMV8 PMU. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Tested-by: James Clark > Acked-by: Mark Rutland > Signed-off-by: Anshuman Khandual > --- > drivers/perf/arm_pmu.c | 9 +++++++++ > include/linux/perf/arm_pmu.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > index f6ccb2cd4dfc..c0475a96c2a0 100644 > --- a/drivers/perf/arm_pmu.c > +++ b/drivers/perf/arm_pmu.c > @@ -519,6 +519,14 @@ static int armpmu_event_init(struct perf_event *event) > return __hw_perf_event_init(event); > } > > +static void armpmu_sched_task(struct perf_event_pmu_context *pmu_ctx, bool sched_in) > +{ > + struct arm_pmu *armpmu = to_arm_pmu(pmu_ctx->pmu); > + > + if (armpmu->sched_task) > + armpmu->sched_task(pmu_ctx, sched_in); > +} > + > static void armpmu_enable(struct pmu *pmu) > { > struct arm_pmu *armpmu = to_arm_pmu(pmu); > @@ -865,6 +873,7 @@ struct arm_pmu *armpmu_alloc(void) > } > > pmu->pmu = (struct pmu) { > + .sched_task = armpmu_sched_task, > .pmu_enable = armpmu_enable, > .pmu_disable = armpmu_disable, > .event_init = armpmu_event_init, > diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h > index a0801f68762b..3d3bd944d630 100644 > --- a/include/linux/perf/arm_pmu.h > +++ b/include/linux/perf/arm_pmu.h > @@ -102,6 +102,7 @@ struct arm_pmu { > void (*stop)(struct arm_pmu *); > void (*reset)(void *); > int (*map_event)(struct perf_event *event); > + void (*sched_task)(struct perf_event_pmu_context *pmu_ctx, bool sched_in); > int num_events; > bool secure_access; /* 32-bit ARM only */ > #define ARMV8_PMUV3_MAX_COMMON_EVENTS 0x40 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel