[PATCH 0/5] TQMa6x / MBa6x DT improvements

[PATCH 0/5] TQMa6x / MBa6x DT improvements

[Markus Niebel]

This series brings following improvements:
* use a more specific compatible for the LM75 temperature sensors
  on SoM and mainboard
* move I2C pinmux entries to variants that use them and prevent
  doubled declaration
* rename node name for onboard USB hub

Alexander Stein (1):
  ARM: dts: imx6qdl: Rename USB hub node name

Markus Niebel (4):
  arm: dts: imx6qdl-tqma6: move i2c3 pinmux to imx6qdl-tqma6b
  arm: dts: imx6qdl-tqma6: improve compatible for LM75 temp sensor
  arm: dts: imx6qdl-mba6: improve compatible for LM75 temp sensor
  arm: dts: imx6qdl-mba6b: remove doubled entry for I2C1 pinmux

 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi   |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi  |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi  | 11 +---------
 arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6.dtsi  | 14 -------------
 arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6a.dtsi |  4 ++--
 arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi | 20 +++++++++++++++++--
 6 files changed, 23 insertions(+), 30 deletions(-)

-- 
2.34.1

[PATCH 1/5] arm: dts: imx6qdl-tqma6: move i2c3 pinmux to imx6qdl-tqma6b

[Markus Niebel]

Move the pinmux entries to the variant where they are actual
used. No functional changes.

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6.dtsi  | 14 --------------
 arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi | 16 ++++++++++++++++
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6.dtsi
index 344ea935c7da..6152a9ed4768 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6.dtsi
@@ -59,20 +59,6 @@ MX6QDL_PAD_CSI0_DAT9__GPIO5_IO27 0x4001b899
 		>;
 	};
 
-	pinctrl_i2c3: i2c3grp {
-		fsl,pins = <
-			MX6QDL_PAD_GPIO_5__I2C3_SCL 0x4001b899
-			MX6QDL_PAD_GPIO_6__I2C3_SDA 0x4001b899
-		>;
-	};
-
-	pinctrl_i2c3_recovery: i2c3recoverygrp {
-		fsl,pins = <
-			MX6QDL_PAD_GPIO_5__GPIO1_IO05 0x4001b899
-			MX6QDL_PAD_GPIO_6__GPIO1_IO06 0x4001b899
-		>;
-	};
-
 	pinctrl_pmic: pmicgrp {
 		fsl,pins = <
 			MX6QDL_PAD_NANDF_RB0__GPIO6_IO10 0x1b099 /* PMIC irq */
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi
index aeba0a273600..53e78f1aed38 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi
@@ -33,3 +33,19 @@ eeprom@50 {
 		vcc-supply = <&reg_3p3v>;
 	};
 };
+
+&iomuxc {
+	pinctrl_i2c3: i2c3grp {
+		fsl,pins = <
+			MX6QDL_PAD_GPIO_5__I2C3_SCL 0x4001b899
+			MX6QDL_PAD_GPIO_6__I2C3_SDA 0x4001b899
+		>;
+	};
+
+	pinctrl_i2c3_recovery: i2c3recoverygrp {
+		fsl,pins = <
+			MX6QDL_PAD_GPIO_5__GPIO1_IO05 0x4001b899
+			MX6QDL_PAD_GPIO_6__GPIO1_IO06 0x4001b899
+		>;
+	};
+};
-- 
2.34.1

[PATCH 2/5] arm: dts: imx6qdl-tqma6: improve compatible for LM75 temp sensor

[Markus Niebel]

Use national,lm75a to specify exact variant used. This should cause
no functional changes.

While at it change node name to 'temperature-sensor@48' to
describe the function of the IC.

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6a.dtsi | 4 ++--
 arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6a.dtsi
index 68525f0205d3..828996382f24 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6a.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6a.dtsi
@@ -27,8 +27,8 @@ pmic: pmic@8 {
 		reg = <0x08>;
 	};
 
-	sensor@48 {
-		compatible = "national,lm75";
+	temperature-sensor@48 {
+		compatible = "national,lm75a";
 		reg = <0x48>;
 		vs-supply = <&reg_3p3v>;
 	};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi
index 53e78f1aed38..1d0966b8d99e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tqma6b.dtsi
@@ -20,8 +20,8 @@ pmic: pmic@8 {
 		reg = <0x08>;
 	};
 
-	sensor@48 {
-		compatible = "national,lm75";
+	temperature-sensor@48 {
+		compatible = "national,lm75a";
 		reg = <0x48>;
 		vs-supply = <&reg_3p3v>;
 	};
-- 
2.34.1

[PATCH 3/5] arm: dts: imx6qdl-mba6: improve compatible for LM75 temp sensor

[Markus Niebel]

Use national,lm75a to specify exact variant used. This should cause
no functional changes.

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi | 2 +-
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
index 807f3c95e3ce..aca320ee8f47 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
@@ -13,7 +13,7 @@ &fec {
 
 &i2c1 {
 	lm75: temperature-sensor@49 {
-		compatible = "national,lm75";
+		compatible = "national,lm75a";
 		reg = <0x49>;
 		vs-supply = <&reg_mba6_3p3v>;
 	};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
index 789733a45b95..eacd230b97d5 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
@@ -23,7 +23,7 @@ &i2c1 {
 
 &i2c3 {
 	lm75: temperature-sensor@49 {
-		compatible = "national,lm75";
+		compatible = "national,lm75a";
 		reg = <0x49>;
 		vs-supply = <&reg_mba6_3p3v>;
 	};
-- 
2.34.1

[PATCH 4/5] arm: dts: imx6qdl-mba6b: remove doubled entry for I2C1 pinmux

[Markus Niebel]

Since the muxing is described already in imx6qdl-tqma6 can be reused
by this variant. No functional change.

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
index eacd230b97d5..c7bbd6195fef 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
@@ -50,12 +50,3 @@ rtc0: rtc@68 {
 		reg = <0x68>;
 	};
 };
-
-&iomuxc {
-	pinctrl_i2c1: i2c1grp {
-		fsl,pins = <
-			MX6QDL_PAD_CSI0_DAT8__I2C1_SDA 0x4001b899
-			MX6QDL_PAD_CSI0_DAT9__I2C1_SCL 0x4001b899
-		>;
-	};
-};
-- 
2.34.1

[PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Markus Niebel]

From: Alexander Stein <alexander.stein@ew.tq-group.com>

According to microchip,usb2514.yaml the node name shall be usb-hub.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi
index 60aa1e947f62..d03f7065ddfd 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6.dtsi
@@ -293,7 +293,7 @@ &usbh1 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 
-	hub@1 {
+	usb-hub@1 {
 		compatible = "usb424,2517";
 		reg = <1>;
 		#address-cells = <1>;
-- 
2.34.1

Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Niebel, Markus]

On Mon, 2024-08-12 at 16:34 +0200, Markus Niebel wrote:
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> According to microchip,usb2514.yaml the node name shall be usb-hub.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 

Sorry, i forgot my Signed-off-by. Will resend if needed

> ---
Best regards,
Markus

Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Krzysztof Kozlowski]

On 12/08/2024 16:34, Markus Niebel wrote:
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> According to microchip,usb2514.yaml the node name shall be usb-hub.

That's not true. The schema does not say anything like this. Old name is
correct. NAK.


Best regards,
Krzysztof

Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Alexander Stein]

Am Dienstag, 13. August 2024, 11:20:08 CEST schrieb Krzysztof Kozlowski:
> On 12/08/2024 16:34, Markus Niebel wrote:
> > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > 
> > According to microchip,usb2514.yaml the node name shall be usb-hub.
> 
> That's not true. The schema does not say anything like this. Old name is
> correct. NAK.

So, is the schema incorrect? There is the dtbs_check warning:
arch/arm/boot/dts/nxp/imx/imx6q-mba6b.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?'
        from schema $id: http://devicetree.org/schemas/usb/microchip,usb2514.yaml#

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Krzysztof Kozlowski]

On 13/08/2024 11:27, Alexander Stein wrote:
> Am Dienstag, 13. August 2024, 11:20:08 CEST schrieb Krzysztof Kozlowski:
>> On 12/08/2024 16:34, Markus Niebel wrote:
>>> From: Alexander Stein <alexander.stein@ew.tq-group.com>
>>>
>>> According to microchip,usb2514.yaml the node name shall be usb-hub.
>>
>> That's not true. The schema does not say anything like this. Old name is
>> correct. NAK.
> 
> So, is the schema incorrect? There is the dtbs_check warning:
> arch/arm/boot/dts/nxp/imx/imx6q-mba6b.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?'
>         from schema $id: http://devicetree.org/schemas/usb/microchip,usb2514.yaml#

If you have a warning, shorten it and paste it so this will be obvious.
If you look at several bindings, the hub is widely used name. I think
the schema is not correct here - I do not see any properties from
usb.yaml being used here (for usb2514). What's more, if you compare
usb2514 with any other on-board HUB representations (because that's the
only point why we have it in bindings, right?), none of them reference
usb(-hcd)?.yaml.

These are not USB controllers, IMO.

Best regards,
Krzysztof

Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Alexander Stein]

Am Dienstag, 13. August 2024, 11:44:28 CEST schrieb Krzysztof Kozlowski:
> On 13/08/2024 11:27, Alexander Stein wrote:
> > Am Dienstag, 13. August 2024, 11:20:08 CEST schrieb Krzysztof Kozlowski:
> >> On 12/08/2024 16:34, Markus Niebel wrote:
> >>> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> >>>
> >>> According to microchip,usb2514.yaml the node name shall be usb-hub.
> >>
> >> That's not true. The schema does not say anything like this. Old name is
> >> correct. NAK.
> > 
> > So, is the schema incorrect? There is the dtbs_check warning:
> > arch/arm/boot/dts/nxp/imx/imx6q-mba6b.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?'
> >         from schema $id: http://devicetree.org/schemas/usb/microchip,usb2514.yaml#
> 
> If you have a warning, shorten it and paste it so this will be obvious.
> If you look at several bindings, the hub is widely used name. I think
> the schema is not correct here - I do not see any properties from
> usb.yaml being used here (for usb2514). What's more, if you compare
> usb2514 with any other on-board HUB representations (because that's the
> only point why we have it in bindings, right?), none of them reference
> usb(-hcd)?.yaml.
> 
> These are not USB controllers, IMO.

I raised that concern in [1] already, but nobody commented.

Best regards,
Alexander

[1] https://lore.kernel.org/all/3633627.mvXUDI8C0e@steina-w/
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Niebel, Markus]

On Tue, 2024-08-13 at 13:02 +0200, Alexander Stein wrote:
> Am Dienstag, 13. August 2024, 11:44:28 CEST schrieb Krzysztof Kozlowski:
> > On 13/08/2024 11:27, Alexander Stein wrote:
> > > Am Dienstag, 13. August 2024, 11:20:08 CEST schrieb Krzysztof Kozlowski:
> > > > On 12/08/2024 16:34, Markus Niebel wrote:
> > > > > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > 
> > > > > According to microchip,usb2514.yaml the node name shall be usb-hub.
> > > > 
> > > > That's not true. The schema does not say anything like this. Old name is
> > > > correct. NAK.
> > > 
> > > So, is the schema incorrect? There is the dtbs_check warning:
> > > arch/arm/boot/dts/nxp/imx/imx6q-mba6b.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?'
> > >         from schema $id: http://devicetree.org/schemas/usb/microchip,usb2514.yaml#
> > 
> > If you have a warning, shorten it and paste it so this will be obvious.
> > If you look at several bindings, the hub is widely used name. I think
> > the schema is not correct here - I do not see any properties from
> > usb.yaml being used here (for usb2514). What's more, if you compare
> > usb2514 with any other on-board HUB representations (because that's the
> > only point why we have it in bindings, right?), none of them reference
> > usb(-hcd)?.yaml.
> > 
> > These are not USB controllers, IMO.
> 
> I raised that concern in [1] already, but nobody commented.
> 

Besides that, current version of device tree specification [1], section
'2.2.2 Generic Names Recommendation' exlicitely suggests 'usb-hub' but
not 'hub'

See
https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.4

> Best regards,
> Alexander
> 
> [1] https://lore.kernel.org/all/3633627.mvXUDI8C0e@steina-w/

Best regards,
Markus

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name

[Krzysztof Kozlowski]

On 13/08/2024 13:02, Alexander Stein wrote:
> Am Dienstag, 13. August 2024, 11:44:28 CEST schrieb Krzysztof Kozlowski:
>> On 13/08/2024 11:27, Alexander Stein wrote:
>>> Am Dienstag, 13. August 2024, 11:20:08 CEST schrieb Krzysztof Kozlowski:
>>>> On 12/08/2024 16:34, Markus Niebel wrote:
>>>>> From: Alexander Stein <alexander.stein@ew.tq-group.com>
>>>>>
>>>>> According to microchip,usb2514.yaml the node name shall be usb-hub.
>>>>
>>>> That's not true. The schema does not say anything like this. Old name is
>>>> correct. NAK.
>>>
>>> So, is the schema incorrect? There is the dtbs_check warning:
>>> arch/arm/boot/dts/nxp/imx/imx6q-mba6b.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?'
>>>         from schema $id: http://devicetree.org/schemas/usb/microchip,usb2514.yaml#
>>
>> If you have a warning, shorten it and paste it so this will be obvious.
>> If you look at several bindings, the hub is widely used name. I think
>> the schema is not correct here - I do not see any properties from
>> usb.yaml being used here (for usb2514). What's more, if you compare
>> usb2514 with any other on-board HUB representations (because that's the
>> only point why we have it in bindings, right?), none of them reference
>> usb(-hcd)?.yaml.
>>
>> These are not USB controllers, IMO.
> 
> I raised that concern in [1] already, but nobody commented.

With 200 new emails in my inbox every day, I bet I miss many threads...

The nodes could be named usb-hub, makes sense, but:
1. Several bindings examples have hub, so we would need to correct all
of them for consistency?

2. For me hub is generic and obvious enough. Just like "phy", even
though DT spec has "usb-phy".

3. Renaming nodes to fix issues is very good. Renaming just to make
things more readable is also good or because coding style asks for it.
Renaming just because one person likes hub, other likes usb-hub, so just
personal preference, is for me churn. Considering it sometimes breaks
some users (it is not ABI... till it is), personal preference is poor
reason.

I think the schema should be fixed, because this is not an USB
controller, in terms how we call things which are "USB controllers". On
the bus it is USB device and USB hub. For USB device we have schema. For
USB hub we don't, so it does not matter.

Best regards,
Krzysztof

Re: [PATCH 0/5] TQMa6x / MBa6x DT improvements

[Shawn Guo]

On Mon, Aug 12, 2024 at 04:34:26PM +0200, Markus Niebel wrote:
> This series brings following improvements:
> * use a more specific compatible for the LM75 temperature sensors
>   on SoM and mainboard
> * move I2C pinmux entries to variants that use them and prevent
>   doubled declaration
> * rename node name for onboard USB hub
> 
> Alexander Stein (1):
>   ARM: dts: imx6qdl: Rename USB hub node name
> 
> Markus Niebel (4):
>   arm: dts: imx6qdl-tqma6: move i2c3 pinmux to imx6qdl-tqma6b
>   arm: dts: imx6qdl-tqma6: improve compatible for LM75 temp sensor
>   arm: dts: imx6qdl-mba6: improve compatible for LM75 temp sensor
>   arm: dts: imx6qdl-mba6b: remove doubled entry for I2C1 pinmux

"ARM: dts: ..." please.

Shawn

Re: Re: [PATCH 0/5] TQMa6x / MBa6x DT improvements

[Niebel, Markus]

> On Mon, Aug 12, 2024 at 04:34:26PM +0200, Markus Niebel wrote:
> > This series brings following improvements:
> > * use a more specific compatible for the LM75 temperature sensors
> >   on SoM and mainboard
> > * move I2C pinmux entries to variants that use them and prevent
> >   doubled declaration
> > * rename node name for onboard USB hub
> > 
> > Alexander Stein (1):
> >   ARM: dts: imx6qdl: Rename USB hub node name
> > 
> > Markus Niebel (4):
> >   arm: dts: imx6qdl-tqma6: move i2c3 pinmux to imx6qdl-tqma6b
> >   arm: dts: imx6qdl-tqma6: improve compatible for LM75 temp sensor
> >   arm: dts: imx6qdl-mba6: improve compatible for LM75 temp sensor
> >   arm: dts: imx6qdl-mba6b: remove doubled entry for I2C1 pinmux
> 
> "ARM: dts: ..." please.
> 
> 
> Thank you for the hint, will resend.
> Shawn
> 

Markus

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/