From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C12A2C433F5 for ; Fri, 22 Oct 2021 15:19:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 885E66112D for ; Fri, 22 Oct 2021 15:19:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 885E66112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=iaRJ8bGQx9xNH1dpTi3+ZH/3oLFvrywlaEfbnlT3tIs=; b=xtEGYClqVbukrRBfQjkQxIbSHr 7TYv8YvKyfPGdV9WyqsbU+LM1670ZgJZeT61YrdTQxEX/gASEw9e9Ls8cxxy5ZScSmhSuM1Q8eIsX /EO0fVlsbvgwMVZ9Q6hBCfyP4QPeCafZjmOr+LnWiUl1emeewPplFmqGHieCrfYQ4nZ9dPBpyfaI1 0pEEtfoNQBqKGRCDbY6xPoHtBsQHDevmOGVjRFDNkUduJIXoe9RsrlaNMF4SqPYh32O26pPWXeMXV v0dyuZX0hqyXLXMcYaagsFHVLoH4APbNA7u1i9+6ZVIo9TLf1dS6dgX/Ow7V8CCztwqDJDXiHV12t DdNv0whg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdwJQ-00BOiI-IR; Fri, 22 Oct 2021 15:18:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdwJN-00BOhQ-A6 for linux-arm-kernel@lists.infradead.org; Fri, 22 Oct 2021 15:18:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B48BB1FB; Fri, 22 Oct 2021 08:18:22 -0700 (PDT) Received: from [10.57.20.104] (unknown [10.57.20.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6C5E3F694; Fri, 22 Oct 2021 08:18:18 -0700 (PDT) Subject: Re: [PATCH 09/15] irq: arm: perform irqentry in entry code To: Mark Rutland , linux-kernel@vger.kernel.org Cc: aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, tsbogend@alpha.franken.de, vgupta@kernel.org, will@kernel.org References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-10-mark.rutland@arm.com> From: Vladimir Murzin Message-ID: <0efc4465-12b5-a568-0228-c744ec0509a3@arm.com> Date: Fri, 22 Oct 2021 16:18:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20211021180236.37428-10-mark.rutland@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211022_081825_449605_D999D4AC X-CRM114-Status: UNSURE ( 8.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On 10/21/21 7:02 PM, Mark Rutland wrote: > +/* > + * TODO: restructure the ARMv7M entry logic so that this entry logic can live > + * in arch code. > + */ > +asmlinkage void __exception_irq_entry > +static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) I'm seeing build time failure... drivers/irqchip/irq-nvic.c:50:8: error: two or more data types in declaration specifiers static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) ^~~~ drivers/irqchip/irq-nvic.c:50:13: warning: 'nvic_handle_irq' defined but not used [-Wunused-function] static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) I've fixed that locally and planing to give it a go... Cheers Vladimir _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel