From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 061D4C636CC for ; Sun, 19 Feb 2023 12:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e/ZDNlZWDqQiaFoQFPhyaAz/TTPOn/tNmh+Al6jjR0M=; b=RzyaQU5V4Wx66m m6zqBP8gGvLEZd970s9wgVoTFF8CUcmPWH7DY2Oc9BCbSPXFzHT3p6Fk8194OViCatlVMZm43yKd0 /KDejbnhf+A6zdAevtLVpsTK+HWkox/g9Xz4v5s6or6RPiZCLqW51VFEhsV2fsXDEYsKeYHH0h502 7UTBEIYo60Tevev8J5+3jszBZBxuHhLSWGqhnwld9+Vac5Cfs8s2gJ4iInOygW8odvGNP13MuMHWJ 4FnLVIV1+tH2zz+B8Ur8rcBiOzwXfUOM0hHa0om2SHa+d+5bVwz/vJYzUZlIRzuOM47BwCfFG4bU3 IiM0pXoPIgmf0z5gNrvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTiyV-001VMd-2T; Sun, 19 Feb 2023 12:39:27 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTiyR-001VLr-Tj for linux-arm-kernel@lists.infradead.org; Sun, 19 Feb 2023 12:39:25 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id BC6DF32000EB; Sun, 19 Feb 2023 07:39:22 -0500 (EST) Received: from imap47 ([10.202.2.97]) by compute5.internal (MEProxy); Sun, 19 Feb 2023 07:39:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1676810362; x=1676896762; bh=k8 3A+g7S3ByBVaUJPvDn2um16R3lzsxqFfSEQC5A0ls=; b=oDNhtv0DuSXXtQpIKc aQlBh+GfGOy8X3rS+YYGpM1PX0Hzt4LDfXmpGGxAYFj7BLQkDKv9KbOlZBjlxfaC myRo6/nSwB7dh2Y+vfb3o8PgSSMnslP0KA9ei6aEnKhDipeOq4BYsaVTF+b6ki6f TzZUrWVkvmWMxn9nhAivHiGv98z3WIlZcYFogFN68gWwu5KlsIqk5gTzftaU8V2r QdUC2Fk9f8v1RVmVA07v3SG0S2XKLdvwQI/nlAxGAY67ova5aNyzCaGbAees4fv1 hD+jCwlykJXBpW4AOkz7JHCNpsjneSBMlbepZrFABlicKMoZRFgI7kaZ0H6kd0Ic nNcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676810362; x=1676896762; bh=k83A+g7S3ByBVaUJPvDn2um16R3l zsxqFfSEQC5A0ls=; b=XnlDmCRzSEgzBbxfME0H9Ry2dnYZzJ5OQA1p1VIi0TAE sZp/Ynij3iqEWylE8StrhX6KCGgtjA2xISN9t2BET9KNcYM4yVlVAsBetqb/qJRB IYa6WyWVvI9AW1sd7syCMqXQKQRSRemZ7AfQImii4kMXaVV6fxLZRxrd0eiB4Lyj l6AjekA2jlr5mVBumSkBj5y+4tPg8llhTdSLsvoXwUUV6jY0QoJc2e5YqNaDmO3C ugKc1JmVc1vIZMWvzemavp4HWSf3vUoohuk4RK2KzaRjVSeoORMmfbMsaooCtvDj MxuIwr1qanzLPtts+IgX+iB3b0P5PCIoRBRc1J8oew== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfufhv vghnucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrf grthhtvghrnhepleevgfegffehvedtieevhfekheeftedtjeetudevieehveevieelgffh ieevieeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshhvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 38341A6007C; Sun, 19 Feb 2023 07:39:21 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-156-g081acc5ed5-fm-20230206.001-g081acc5e Mime-Version: 1.0 Message-Id: <0f49c43d-c6e0-47a9-871b-6fbe4daaa37e@app.fastmail.com> In-Reply-To: <20230217141059.392471-12-nick.alcock@oracle.com> References: <20230217141059.392471-1-nick.alcock@oracle.com> <20230217141059.392471-12-nick.alcock@oracle.com> Date: Sun, 19 Feb 2023 13:38:54 +0100 From: "Sven Peter" To: "Nick Alcock" , mcgrof@kernel.org Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, "Hitomi Hasegawa" , "Hector Martin" , "Philipp Zabel" , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: remove MODULE_LICENSE in non-modules X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230219_043924_007606_6B1472C9 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 17, 2023, at 15:10, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Hector Martin > Cc: Sven Peter > Cc: Philipp Zabel > Cc: asahi@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- Acked-by: Sven Peter Sven > drivers/soc/apple/apple-pmgr-pwrstate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c > b/drivers/soc/apple/apple-pmgr-pwrstate.c > index e1122288409a..2c15474c7b53 100644 > --- a/drivers/soc/apple/apple-pmgr-pwrstate.c > +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c > @@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver > = { > > MODULE_AUTHOR("Hector Martin "); > MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs"); > -MODULE_LICENSE("GPL v2"); > > module_platform_driver(apple_pmgr_ps_driver); > -- > 2.39.1.268.g9de2f9a303 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel