From: Matthias Brugger <matthias.bgg@gmail.com>
To: Weiyi Lu <weiyi.lu@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>
Cc: Rob Herring <robh@kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
James Liao <jamesjj.liao@mediatek.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Fan Chen <fan.chen@mediatek.com>,
Devicetree List <devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v17 06/12] soc: mediatek: Add support for hierarchical scpsys device node
Date: Thu, 1 Oct 2020 16:33:52 +0200 [thread overview]
Message-ID: <0f750b5c-86b6-f78f-f03f-d63bb599922e@gmail.com> (raw)
In-Reply-To: <1601437039.28469.3.camel@mtksdaap41>
On 30/09/2020 05:37, Weiyi Lu wrote:
> On Mon, 2020-09-28 at 15:14 +0800, Nicolas Boichat wrote:
>> On Thu, Aug 6, 2020 at 5:22 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote:
>>>
>>> Try to list all the power domains of under power controller
>>> node to show the dependency between each power domain directly
>>> instead of filling the dependency in scp_soc_data.
>>> And could be more clearly to group subsys clocks into power domain
>>> sub node to introduce subsys clocks of bus protection in next patch.
>>>
>>> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
>>> ---
>> [snip]
>>> +static int traverse_scp(struct platform_device *pdev, struct scp *scp,
>>> + const struct scp_domain_data *scp_domain_data)
>>> +{
>>> + struct device *dev = &pdev->dev;
>>> + struct device_node *np = dev->of_node;
>>> + struct device_node *sub;
>>> + int ret;
>>> +
>>> + INIT_LIST_HEAD(&scp->dep_links);
>>> +
>>> + for_each_available_child_of_node(np, sub) {
>>> + ret = scpsys_get_domain(pdev, scp, sub, scp_domain_data);
>>> + if (ret) {
>>> + dev_err(&pdev->dev, "failed to handle node %pOFn: %d\n", sub, ret);
>>
>> minor comment: this error should not be printed if ret ==
>> -EPROBE_DEFER (use the new dev_err_probe?)
>>
>
> You're right! I'll use dev_err_probe() instead if anyone is interested
> in this series. Thank you!
>
I'd propose that we put all our effort of reviewing and testing into the series
Enric send:
https://lore.kernel.org/linux-mediatek/20200910172826.3074357-1-enric.balletbo@collabora.com/
Regards,
Matthias
>>> + goto err;
>>> + }
>>> + }
>>> +
>>> + return 0;
>>> +
>>> +err:
>>> + of_node_put(sub);
>>> + return ret;
>>> +}
>> [snip]
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-01 14:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 9:21 [PATCH v17 00/12] Mediatek MT8183 scpsys support Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 01/12] dt-bindings: mediatek: Add property to mt8183 smi-common Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 02/12] soc: mediatek: Add basic_clk_name to scp_power_data Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 03/12] soc: mediatek: Remove infracfg misc driver support Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 04/12] soc: mediatek: Add multiple step bus protection control Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 05/12] dt-bindings: soc: Add MT8183 power dt-bindings Weiyi Lu
2020-08-17 21:53 ` Rob Herring
2020-08-06 9:21 ` [PATCH v17 06/12] soc: mediatek: Add support for hierarchical scpsys device node Weiyi Lu
2020-09-28 7:14 ` Nicolas Boichat
2020-09-30 3:37 ` Weiyi Lu
2020-10-01 14:33 ` Matthias Brugger [this message]
2020-08-06 9:21 ` [PATCH v17 07/12] soc: mediatek: Add subsys clock control for bus protection Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 08/12] soc: mediatek: Add extra sram control Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 09/12] soc: mediatek: Add MT8183 scpsys support Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 10/12] soc: mediatek: Add a comma at the end Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 11/12] arm64: dts: Add power controller device node of MT8183 Weiyi Lu
2020-08-06 9:21 ` [PATCH v17 12/12] arm64: dts: Add power-domains property to mfgcfg Weiyi Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f750b5c-86b6-f78f-f03f-d63bb599922e@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=eballetbo@gmail.com \
--cc=fan.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).