From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1700C56201 for ; Wed, 11 Nov 2020 10:13:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C1F82075A for ; Wed, 11 Nov 2020 10:13:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A/WWPAKn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="tJ3mTPjb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C1F82075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:References:In-Reply-To:MIME-Version:Date:Message-ID:From:To:Subject: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VNJBKEKO5ChJ0hOMCib/0juajXBU3iUz1uB1IIQvKnE=; b=A/WWPAKnHCivvu9G6NwS25F6ek hvq79xBmbDj2XfPBQqcgi8OXDHjgalag6P4L77E4szFCBlR9b57/PqLtquPoVK0AHFkjvkZq9jbGL 5AR0s1cY35kupwQVhvHxd/nGkG3JQ3koPSPHvJzM2OOfIc7LzGQ//XEeF5MDtN8cwJw1c+Kc42eKs 3zW3LJM4Sd0HpJGFWfb31PNc2xhRA1wwpRqRegossLVulkRXc+869sUAfgM6r46ytv984cWZtEEqC iYp/0wGOgi6G7Yl07Wy60rOi8DnIR8f+ug4yTzIaTBmzSwRipDj0+CUdo/RT7jkgDR43f97N4Bt6z 2Ss3eC7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcn6Y-0002H8-RJ; Wed, 11 Nov 2020 10:11:54 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcn6V-0002GO-Vi for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 10:11:53 +0000 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20201111101147epoutp04478489a63a99c6dd0ec11c99b5d47132~GbGc6l0VI1427414274epoutp04s for ; Wed, 11 Nov 2020 10:11:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20201111101147epoutp04478489a63a99c6dd0ec11c99b5d47132~GbGc6l0VI1427414274epoutp04s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1605089507; bh=UK192lurrVstoJVqplp6lLRHryqWEbuY4owgU9ypYPU=; h=Subject:To:From:Date:In-Reply-To:References:From; b=tJ3mTPjbmJApFXCOz1Kmw0xEJ2QmpADg+HIIL3XMvB3r5fWH9PfBPwNN7K0qgJ78f vvnFXr3BCdKNUz1u8XKRpHdr8la5+7D1a3OiReunLBIIBP18MQE4H8oFTTZsxsqbuN FZir/iFN1aSvIDqSlH+ux/q0CnWvPzgltqbOtsM4= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20201111101147epcas1p3f9fc958728fc8706400bee24c466d286~GbGctdzi70281302813epcas1p3L; Wed, 11 Nov 2020 10:11:47 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.40.158]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4CWL9s2pMtzMqYkk; Wed, 11 Nov 2020 10:11:45 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id E0.AD.10463.1E8BBAF5; Wed, 11 Nov 2020 19:11:45 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20201111101144epcas1p13b8e67701630ed85d4984de890f2f6b0~GbGZ0Ujz20897308973epcas1p1B; Wed, 11 Nov 2020 10:11:44 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201111101144epsmtrp2631b382c7481c23ca1cb8ac8a857287f~GbGZuAeHT2680026800epsmtrp2R; Wed, 11 Nov 2020 10:11:44 +0000 (GMT) X-AuditID: b6c32a38-efbff700000028df-fd-5fabb8e1f058 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id D9.17.13470.0E8BBAF5; Wed, 11 Nov 2020 19:11:44 +0900 (KST) Received: from [10.113.221.102] (unknown [10.113.221.102]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201111101144epsmtip110eaf6e36052b5b5417772605217937d~GbGZZZK9x2400324003epsmtip1U; Wed, 11 Nov 2020 10:11:44 +0000 (GMT) Subject: Re: [PATCH] clk: samsung: allow building the clkout driver as module To: Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Chanwoo Choi Organization: Samsung Electronics Message-ID: <0f8c5a70-44e0-b4aa-51e7-73d8db9ff85b@samsung.com> Date: Wed, 11 Nov 2020 19:25:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: <20201110193749.261367-1-krzk@kernel.org> Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKJsWRmVeSWpSXmKPExsWy7bCmnu7DHavjDaZs4LM4f34Du8Wmx9dY LT723GO1uLxrDpvFjPP7mCwunnK1OPymndXi37WNLBardv1hdOD0eH+jld1j56y77B6bVnWy eWxeUu/Rt2UVo8fnTXIBbFHZNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJ uam2Si4+AbpumTlANykplCXmlAKFAhKLi5X07WyK8ktLUhUy8otLbJVSC1JyCiwL9IoTc4tL 89L1kvNzrQwNDIxMgQoTsjPaTxoXzBar6OpYztjAuEmoi5GTQ0LAROLG+0csXYxcHEICOxgl vvV0MkM4nxglnv/+xARSJSTwjVFiarcgTEfn5j1QRXsZJSYf6mCFcN4zSpz99IMRpEpYwF/i RdtXdpCEiMBlJonp5yeCjWIT0JLY/+IGG4jNL6AocfXHY7AGXgE7iQ8fT7KA2CwCqhLT9hxn B7FFBcIkTm5rgaoRlDg58wlYDaeAmcSWo3vBbGYBcYlbT+YzQdjyEtvfzgE7T0JgLodE98Et jBB3u0i0dvawQtjCEq+Ob2GHsKUkPr/bywZhV0usPHmEDaK5g1Fiy/4LUA3GEvuXTgbawAG0 QVNi/S59iLCixM7fcxkhFvNJvPsKMp8DKM4r0dEGDWBlicsP7jJB2JISi9s7oVZ5SNz/NZ91 AqPiLCSvzULyziwk78xCWLyAkWUVo1hqQXFuemqxYYEJcmxvYgSnVy2LHYxz337QO8TIxMF4 iFGCg1lJhJepbVW8EG9KYmVValF+fFFpTmrxIUZTYGBPZJYSTc4HJvi8knhDUyNjY2MLE0Mz U0NDJXHeP9od8UIC6YklqdmpqQWpRTB9TBycUg1MDKzKy/5v7+f8qL1cVNbb1Ofaz45Nk89y rV29a4XDJWn2nXdVhC70JZ58eaJBzOxeecmqbXETSk+u2F32aONkQ45NwpI+p56pTLv07ebv xIfSbr82SgaF8C/61djhM6vI6JJG7qH9HtMEmHNXRs4TVPr166lWQPHRmbny53ZHBp3xvsO0 VyG+0jpkw+wO/32Wf76uLT0Uly+57sXjCSINU9lDjxsqtS273f/6yb34nEc5qXIn2rgEFPVy 9K6nLPhq6fMwQKSDe8M65bknZJiV61K5VK6E+lodk+C08pL1Mlz2itdmZ9RDsU+f9k3ynnSw y1+oomdHm0Umx/3pydUn3RxZ81xcfOR+avPzlV9QYinOSDTUYi4qTgQAlL5jZTgEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42LZdlhJTvfBjtXxBp+W81mcP7+B3WLT42us Fh977rFaXN41h81ixvl9TBYXT7laHH7Tzmrx79pGFotVu/4wOnB6vL/Ryu6xc9Zddo9NqzrZ PDYvqffo27KK0ePzJrkAtigum5TUnMyy1CJ9uwSujPaTxgWzxSq6OpYzNjBuEupi5OSQEDCR 6Ny8h7mLkYtDSGA3o8SOtzfYIRKSEtMuHgVKcADZwhKHDxdD1LxllHiy7CorSI2wgK/E3KsP GUESIgLXmSSmH1jMCFHVySjxZt0usElsAloS+1/cYAOx+QUUJa7+eMwIYvMK2El8+HiSBcRm EVCVmLbnOFi9qECYxM4lj5kgagQlTs58AlbDKWAmseXoXjCbWUBd4s+8S8wQtrjErSfzmSBs eYntb+cwT2AUmoWkfRaSlllIWmYhaVnAyLKKUTK1oDg3PbfYsMAwL7Vcrzgxt7g0L10vOT93 EyM4orQ0dzBuX/VB7xAjEwfjIUYJDmYlEV6mtlXxQrwpiZVVqUX58UWlOanFhxilOViUxHlv FC6MExJITyxJzU5NLUgtgskycXBKNTBFXtt+3KJ9mVb0g7szKhoY5bOdr552nb7P8+y5CD4X gadacXqX9ZOr7ojEPTs/NXLOJN74mIe1TH3XRHOUpP5LaZ9Y/nLaxzmnzjYUZ65hFN5lFrP9 5JHJduzJ2g1qNzcXXctdwKXsX1ptkch7S/f7Hb87n+Mc+Zw9mJqXXTQw/fc1sfLZRcVUx0+v 5FeWPmk+8VEl9UN64/3zAQrXf35cx9IdbOljWJW82a5Ccfd71Z8yQlKLVjnf5GnPqgnhEaxJ z/2q+Uy0qdzxyvww3gP6S1cnFs1czn9hqvuNN61uL3I6NXW5fFjftm3PX5WVdsnkb90XaX4O 11olw6Z25z9zNidf4XjePUNxxxm1ACWW4oxEQy3mouJEAPJ6W1oXAwAA X-CMS-MailID: 20201111101144epcas1p13b8e67701630ed85d4984de890f2f6b0 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20201110193800epcas1p22bc64cad38fe355f25684175d2c77e83 References: <20201110193749.261367-1-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_051152_318861_EE58527A X-CRM114-Status: GOOD ( 29.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 11/11/20 4:37 AM, Krzysztof Kozlowski wrote: > The Exynos clock output driver can be built as module (it does not have > to be part of core init process) for better customization. Adding a > KConfig entry allows also compile testing for build coverage. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/samsung/Kconfig | 10 ++++++++++ > drivers/clk/samsung/Makefile | 2 +- > drivers/clk/samsung/clk-exynos-clkout.c | 1 + > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig > index 57d4b3f20417..b6b2cb209543 100644 > --- a/drivers/clk/samsung/Kconfig > +++ b/drivers/clk/samsung/Kconfig > @@ -19,6 +19,16 @@ config EXYNOS_AUDSS_CLK_CON > on some Exynos SoC variants. Choose M or Y here if you want to > use audio devices such as I2S, PCM, etc. > > +config EXYNOS_CLK_OUT > + tristate "Samsung Exynos clock output driver" > + depends on COMMON_CLK_SAMSUNG > + default y if ARCH_EXYNOS > + help > + Support for the clock output (XCLKOUT) driver present on some of > + Exynos SoC variants. Usually the XCLKOUT is used to monitor the > + status of the certains clocks from SoC, but it could also be tied to > + other devices as an input clock. > + > # For S3C24XX platforms, select following symbols: > config S3C2410_COMMON_CLK > bool "Samsung S3C2410 clock controller support" if COMPILE_TEST > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile > index 1a4e6b787978..4adbf972e9f6 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -15,7 +15,7 @@ obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o > obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5-subcmu.o > obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o > obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o > -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o > +obj-$(CONFIG_EXYNOS_CLK_OUT) += clk-exynos-clkout.o > obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o > obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o > obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o > diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c > index f5f8a956b316..9ec2f40cc400 100644 > --- a/drivers/clk/samsung/clk-exynos-clkout.c > +++ b/drivers/clk/samsung/clk-exynos-clkout.c > @@ -72,6 +72,7 @@ static const struct of_device_id exynos_clkout_ids[] = { > .data = &exynos_clkout_exynos5, > }, { } > }; > +MODULE_DEVICE_TABLE(of, exynos_clkout_ids); > > /* > * Device will be instantiated as child of PMU device without its own > Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel