From: Marek Vasut <marex@nabladev.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Christophe Roullier <christophe.roullier@foss.st.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>,
Rob Herring <robh@kernel.org>,
Yannick Fertre <yannick.fertre@foss.st.com>,
devicetree@vger.kernel.org, kernel@dh-electronics.com,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells
Date: Fri, 28 Aug 2026 18:05:17 +0200 [thread overview]
Message-ID: <0f959651-34d9-4fb2-9e07-238f731c5342@nabladev.com> (raw)
In-Reply-To: <20260828-target-operable-ebc87e0bf30a@spud>
On 8/28/26 5:57 PM, Conor Dooley wrote:
[...]
>> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> @@ -39,6 +39,17 @@ properties:
>> "#clock-cells":
>> const: 0
>>
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 1
>> +
>> +patternProperties:
>> + "^phy@[0-9a-f]+$":
>> + type: object
>> + $ref: /schemas/phy/st,stm32-usb2phy.yaml
>> +
>> required:
>> - compatible
>> - reg
>> @@ -57,10 +68,14 @@ allOf:
>> - if:
>> properties:
>> compatible:
>> - const: st,stm32mp25-syscfg
>> + enum:
>> + - st,stm32mp23-syscfg
>> + - st,stm32mp25-syscfg
>
> Sashiko comment here I believe is valid, the syntax here only works if
> there's only the listed compatible present. It doesn't work with
> fallbacks.
This syntax is used all over the place ?
Documentation/devicetree/bindings/ata/ahci-platform.yaml-allOf:
Documentation/devicetree/bindings/ata/ahci-platform.yaml- - $ref:
ahci-common.yaml#
Documentation/devicetree/bindings/ata/ahci-platform.yaml-
Documentation/devicetree/bindings/ata/ahci-platform.yaml- - if:
Documentation/devicetree/bindings/ata/ahci-platform.yaml- properties:
Documentation/devicetree/bindings/ata/ahci-platform.yaml- compatible:
Documentation/devicetree/bindings/ata/ahci-platform.yaml: contains:
Documentation/devicetree/bindings/ata/ahci-platform.yaml- enum:
Documentation/devicetree/bindings/ata/ahci-platform.yaml- -
qcom,apq8064-ahci
Documentation/devicetree/bindings/ata/ahci-platform.yaml- -
qcom,ipq806x-ahci
> pw-bot: changes-requested
>
>> then:
>> required:
>> - "#clock-cells"
>> + - "#address-cells"
>> + - "#size-cells"
>
> else, false? But I'm also not sure what the benefit is of requiring
> addr/size cells when the child node is not?
The subnodes of this syscfg node have reg property , see [PATCH v4 0/4]
arm64: dts: st: Add STM32MP2 USB support .
prev parent reply other threads:[~2026-08-28 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:11 [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells Marek Vasut
2026-08-28 15:11 ` [PATCH v4 2/2] soc: st: Add STM32MP2 SYSCFG driver Marek Vasut
2026-08-28 15:57 ` [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells Conor Dooley
2026-08-28 16:05 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f959651-34d9-4fb2-9e07-238f731c5342@nabladev.com \
--to=marex@nabladev.com \
--cc=alexandre.torgue@foss.st.com \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=robh@kernel.org \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox