From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E047EC433EF for ; Fri, 11 Mar 2022 08:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date :Message-ID:From:References:Cc:To:Subject:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IgE9ECrjMBuTyClcqeMroI10h7ldvuBMXdSZAkSJrSQ=; b=qw4bX2miHotNEe ajQ0gcMhw2/YKjBpXiDwl6hkyw+Ota1oYkMQ9/YhS2ovy2yBK9PaevVHLi4UJRI+VzhBY7zM76qoh stV7gohEbdtSCK2ptsBlt28sIomTXfWoVAIukz3t2ZJoIQS9rKaK9/Bdttw9x83q0ngG33y/QdLhh Mt6Uhh8KW2fFgVWT/5TlrIWJK5v+AD6BfyEXgLudflg8G0kAKVR1yE85A9+SaP9fhinrJeAi4+0xB XBzCL7gAoi58XiSUyrHZEax+D1Jz2UaZFnhzKYyLLD5NSoOQu8AtTXny6nvIGP/3V8WddMW1hkU+9 TwtiSteA10BiEoGUfxgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSaIp-00FSvw-UW; Fri, 11 Mar 2022 08:07:13 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSaIP-00FSpK-3Q for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 08:06:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646986003; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgP2Kr6cQT3iIV3nMtr5LhvA/+AXCJWjko3NF+tsE8k=; b=R0Q8sjjQ02BSioRUfkLzERwYplF2SwVGPvakscH6sWgwsTgQa4h5Xy9u2S1a14KTPWygKz WVl4Lh1Dvta/tHAc45nDlPmVjd+Xa/uMMDL11Y33TTPVkUH3tdxlbUxXFHi6Z8G45ufSTG qi9oXSxDkyYj2zYICakMW8w5UMmXYpc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-cq3iASdCP3iqvxnNbnFq5Q-1; Fri, 11 Mar 2022 03:06:41 -0500 X-MC-Unique: cq3iASdCP3iqvxnNbnFq5Q-1 Received: by mail-wr1-f72.google.com with SMTP id p18-20020adfba92000000b001e8f7697cc7so2514807wrg.20 for ; Fri, 11 Mar 2022 00:06:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=vgP2Kr6cQT3iIV3nMtr5LhvA/+AXCJWjko3NF+tsE8k=; b=gx1ftjXKjcnigNJgNpwhoNxv8nrBK3VHNsETuqh/iI5o0cRZ6yMB296QYGML5clAAZ h+VgJ1Tijy1ZRkYVilAkrAm6n4MGrATVcxzEXAekaaqB9YUwSwuaCmPxEiMQMADSmt56 T283lyXXdyzLU2cl1fT+ga+jowrJHb7pT6ElWoeYR9iPst0+gOjQNNbDlUAee9iBWjnc Txdm1vKz2KjTf7vu9zuJ+FPGhOx2h82TxBbb6LBtuyMyzZ2uTzI4j1tjxpyFxjyG7Hvw NLfe8AftNS0IEmPyMJajcHARgixbK4gbpMuyGjvvlxasn7Fk9tnydhyFcXpfYPD3jwsY W8lQ== X-Gm-Message-State: AOAM5318RoArv+LeTGFEIQPPULLEmEDJVuECp55jgfS/RSMNok1L8mZA iK5iCrsScwxkzC8f7KJKOm248SEwJHEKD2atUACO5BB++pizRIoa5fER6ailVwLD+Nu0pQCZwFR ++uE0GCU0aLqlQS1fN3OTifJ+v5OzlD+V/ZU= X-Received: by 2002:adf:ed0c:0:b0:1f0:63a5:36aa with SMTP id a12-20020adfed0c000000b001f063a536aamr6305556wro.588.1646986000398; Fri, 11 Mar 2022 00:06:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2Vm6KkbbdN49P08cPdti6Bocnw762oiUUP6ZqnjAq5tnsFyAkAMa6xeqMtfYWEzcvFxaUkQ== X-Received: by 2002:adf:ed0c:0:b0:1f0:63a5:36aa with SMTP id a12-20020adfed0c000000b001f063a536aamr6305537wro.588.1646986000119; Fri, 11 Mar 2022 00:06:40 -0800 (PST) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id e20-20020adfa454000000b001f01a14dce8sm6107441wra.97.2022.03.11.00.06.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 00:06:39 -0800 (PST) Subject: Re: [PATCH v8 00/11] ACPI/IORT: Support for IORT RMR node To: Shameer Kolothum , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org Cc: linuxarm@huawei.com, lorenzo.pieralisi@arm.com, joro@8bytes.org, robin.murphy@arm.com, will@kernel.org, wanghuiqiang@huawei.com, guohanjun@huawei.com, steven.price@arm.com, Sami.Mujawar@arm.com, jon@solid-run.com, yangyicong@huawei.com References: <20220221154344.2126-1-shameerali.kolothum.thodi@huawei.com> From: Eric Auger Message-ID: <0f9634c1-8401-7814-7783-c1c042e8fb42@redhat.com> Date: Fri, 11 Mar 2022 09:06:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220221154344.2126-1-shameerali.kolothum.thodi@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eric.auger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220311_000645_375359_A8AE9693 X-CRM114-Status: GOOD ( 31.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shameer, On 2/21/22 4:43 PM, Shameer Kolothum wrote: > Hi, > > Since we now have an updated verion[0] of IORT spec(E.d) which > addresses the memory attributes issues discussed here [1], > this series now make use of it. > > The pull request for ACPICA E.d related changes are already > raised and can be found here, > https://github.com/acpica/acpica/pull/752 > > v7 --> v8 > - Patch #1 has temp definitions for RMR related changes till > the ACPICA header changes are part of kernel. > - No early parsing of RMR node info and is only parsed at the > time of use. > - Changes to the RMR get/put API format compared to the > previous version. > - Support for RMR descriptor shared by multiple stream IDs. I tested it on guest side for host MSI SW RESV region flat mapping (using both the old single mapping layout and the now allowed multiple RID ID mapping format) and this worked for me. Feel free to add my Tested-by: Eric Auger Thanks Eric > > Please take a look and let me know your thoughts. > > Thanks, > Shameer > [0] https://developer.arm.com/documentation/den0049/ed/ > [1] https://lore.kernel.org/linux-acpi/20210805160319.GB23085@lpieralisi/ > > From old: > We have faced issues with 3408iMR RAID controller cards which > fail to boot when SMMU is enabled. This is because these > controllers make use of host memory for various caching related > purposes and when SMMU is enabled the iMR firmware fails to > access these memory regions as there is no mapping for them. > IORT RMR provides a way for UEFI to describe and report these > memory regions so that the kernel can make a unity mapping for > these in SMMU. > > Change History: > > v6 --> v7 > -fix pointed out by Steve to the SMMUv2 SMR bypass install in patch #8. > > v5 --> v6 > - Addressed comments from Robin & Lorenzo. > : Moved iort_parse_rmr() to acpi_iort_init() from > iort_init_platform_devices(). > : Removed use of struct iort_rmr_entry during the initial > parse. Using struct iommu_resv_region instead. > : Report RMR address alignment and overlap errors, but continue. > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > on Type of RMR region. Suggested by Jon N. > > v4 --> v5 > -Added a fw_data union to struct iommu_resv_region and removed > struct iommu_rmr (Based on comments from Joerg/Robin). > -Added iommu_put_rmrs() to release mem. > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > yet because of the above changes. > > v3 -->v4 > -Included the SMMUv2 SMR bypass install changes suggested by > Steve(patch #7) > -As per Robin's comments, RMR reserve implementation is now > more generic (patch #8) and dropped v3 patches 8 and 10. > -Rebase to 5.13-rc1 > > RFC v2 --> v3 > -Dropped RFC tag as the ACPICA header changes are now ready to be > part of 5.13[0]. But this series still has a dependency on that patch. > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > PCIe). > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > discussion here[1]. > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > > Jon Nettleton (1): > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > Shameer Kolothum (10): > ACPI/IORT: Add temporary RMR node flag definitions > iommu: Introduce a union to struct iommu_resv_region > ACPI/IORT: Add helper functions to parse RMR nodes > iommu/dma: Introduce generic helper to retrieve RMR info > ACPI/IORT: Add a helper to retrieve RMR memory regions > iommu/arm-smmu-v3: Introduce strtab init helper > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > bypass > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > iommu/arm-smmu-v3: Reserve any RMR regions associated with a dev > iommu/arm-smmu: Reserve any RMR regions associated with a dev > > drivers/acpi/arm64/iort.c | 305 ++++++++++++++++++++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 91 ++++-- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 65 ++++- > drivers/iommu/dma-iommu.c | 25 ++ > include/linux/acpi_iort.h | 14 + > include/linux/dma-iommu.h | 14 + > include/linux/iommu.h | 9 + > 7 files changed, 504 insertions(+), 19 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel