From: Markus Elfring <Markus.Elfring@web.de>
To: Zhang Shurong <zhang_shurong@foxmail.com>,
asahi@lists.linux.dev, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Janne Grunau" <j@jannau.net>, "Jörg Rödel" <joro@8bytes.org>,
"Neal Gompa" <neal@gompa.dev>,
"Robin Murphy" <robin.murphy@arm.com>,
"Sven Peter" <sven@kernel.org>, "Will Deacon" <will@kernel.org>
Subject: Re: [PATCH] iommu/dart: add missing put_device() call in apple_dart_of_xlate
Date: Sat, 12 Jul 2025 20:22:13 +0200 [thread overview]
Message-ID: <0fb8863d-24eb-46c5-b52c-20313eeba5f5@web.de> (raw)
In-Reply-To: <tencent_22664B08ACDCE35DE10E5546C2FB26B59605@qq.com>
> The apple_dart_of_xlate() function obtains a platform device reference
> via of_find_device_by_node() but doesn't release it with put_device().
> This patch adds proper device reference handling to prevent memory
> leaks.
Will another goto chain become helpful here?
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc5#n94
Under which circumstances can the application of the attribute “put_device” grow?
https://elixir.bootlin.com/linux/v6.16-rc5/source/include/linux/device.h#L1140
Regards,
Markus
next prev parent reply other threads:[~2025-07-12 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 16:16 [PATCH] iommu/dart: add missing put_device() call in apple_dart_of_xlate Zhang Shurong
2025-07-12 18:22 ` Markus Elfring [this message]
2025-07-14 11:23 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb8863d-24eb-46c5-b52c-20313eeba5f5@web.de \
--to=markus.elfring@web.de \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robin.murphy@arm.com \
--cc=sven@kernel.org \
--cc=will@kernel.org \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox