linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: edac: Convert aspeed,ast2400-sdram-edac to DT schema
@ 2025-09-19 19:53 Rob Herring (Arm)
  2025-09-22  3:56 ` Andrew Jeffery
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-09-19 19:53 UTC (permalink / raw)
  To: Stefan Schaeckeler, Krzysztof Kozlowski, Conor Dooley,
	Joel Stanley, Andrew Jeffery
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel

Convert the ASpeed SDRAM EDAC binding to DT schema. It's a
straight-forward conversion.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../edac/aspeed,ast2400-sdram-edac.yaml       | 48 +++++++++++++++++++
 .../bindings/edac/aspeed-sdram-edac.txt       | 28 -----------
 MAINTAINERS                                   |  2 +-
 3 files changed, 49 insertions(+), 29 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml
 delete mode 100644 Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt

diff --git a/Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml b/Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml
new file mode 100644
index 000000000000..09735826d707
--- /dev/null
+++ b/Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/edac/aspeed,ast2400-sdram-edac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Aspeed BMC SoC SDRAM EDAC controller
+
+maintainers:
+  - Stefan Schaeckeler <sschaeck@cisco.com>
+
+description: >
+  The Aspeed BMC SoC supports DDR3 and DDR4 memory with and without ECC (error
+  correction check).
+
+  The memory controller supports SECDED (single bit error correction, double bit
+  error detection) and single bit error auto scrubbing by reserving 8 bits for
+  every 64 bit word (effectively reducing available memory to 8/9).
+
+  Note, the bootloader must configure ECC mode in the memory controller.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-sdram-edac
+      - aspeed,ast2500-sdram-edac
+      - aspeed,ast2600-sdram-edac
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    sdram@1e6e0000 {
+        compatible = "aspeed,ast2500-sdram-edac";
+        reg = <0x1e6e0000 0x174>;
+        interrupts = <0>;
+    };
diff --git a/Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt b/Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt
deleted file mode 100644
index 8ca9e0a049d8..000000000000
--- a/Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Aspeed BMC SoC EDAC node
-
-The Aspeed BMC SoC supports DDR3 and DDR4 memory with and without ECC (error
-correction check).
-
-The memory controller supports SECDED (single bit error correction, double bit
-error detection) and single bit error auto scrubbing by reserving 8 bits for
-every 64 bit word (effectively reducing available memory to 8/9).
-
-Note, the bootloader must configure ECC mode in the memory controller.
-
-
-Required properties:
-- compatible: should be one of
-	- "aspeed,ast2400-sdram-edac"
-	- "aspeed,ast2500-sdram-edac"
-	- "aspeed,ast2600-sdram-edac"
-- reg:        sdram controller register set should be <0x1e6e0000 0x174>
-- interrupts: should be AVIC interrupt #0
-
-
-Example:
-
-	edac: sdram@1e6e0000 {
-		compatible = "aspeed,ast2500-sdram-edac";
-		reg = <0x1e6e0000 0x174>;
-		interrupts = <0>;
-	};
diff --git a/MAINTAINERS b/MAINTAINERS
index ec0aba646e7e..b6800e86286a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8848,7 +8848,7 @@ F:	drivers/edac/armada_xp_*
 EDAC-AST2500
 M:	Stefan Schaeckeler <sschaeck@cisco.com>
 S:	Supported
-F:	Documentation/devicetree/bindings/edac/aspeed-sdram-edac.txt
+F:	Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml
 F:	drivers/edac/aspeed_edac.c
 
 EDAC-BLUEFIELD
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: edac: Convert aspeed,ast2400-sdram-edac to DT schema
  2025-09-19 19:53 [PATCH] dt-bindings: edac: Convert aspeed,ast2400-sdram-edac to DT schema Rob Herring (Arm)
@ 2025-09-22  3:56 ` Andrew Jeffery
  2025-09-24 17:29   ` Stefan Schaeckeler (sschaeck)
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2025-09-22  3:56 UTC (permalink / raw)
  To: Rob Herring (Arm), Stefan Schaeckeler, Krzysztof Kozlowski,
	Conor Dooley, Joel Stanley
  Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel

On Fri, 2025-09-19 at 14:53 -0500, Rob Herring (Arm) wrote:
> Convert the ASpeed SDRAM EDAC binding to DT schema. It's a
> straight-forward conversion.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Thanks Rob.

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: edac: Convert aspeed,ast2400-sdram-edac to DT schema
  2025-09-22  3:56 ` Andrew Jeffery
@ 2025-09-24 17:29   ` Stefan Schaeckeler (sschaeck)
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Schaeckeler (sschaeck) @ 2025-09-24 17:29 UTC (permalink / raw)
  To: Andrew Jeffery
  Cc: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
	Joel Stanley, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	schaecsn@gmx.net


> On Sep 21, 2025, at 20:56, Andrew Jeffery <andrew@codeconstruct.com.au> wrote:
> 
> On Fri, 2025-09-19 at 14:53 -0500, Rob Herring (Arm) wrote:
>> Convert the ASpeed SDRAM EDAC binding to DT schema. It's a
>> straight-forward conversion.
>> 
>> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> 
> Thanks Rob.
> 
> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Reviewed-by: Stefan Schaeckeler <sschaeck@cisco.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-24 17:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-19 19:53 [PATCH] dt-bindings: edac: Convert aspeed,ast2400-sdram-edac to DT schema Rob Herring (Arm)
2025-09-22  3:56 ` Andrew Jeffery
2025-09-24 17:29   ` Stefan Schaeckeler (sschaeck)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).