From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 465ECC3DA59 for ; Mon, 15 Jul 2024 08:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WM0yZ3dZzzFTTxe4hgvAgtIJwKRKDgqcOStwGt2gSJ8=; b=Ig5kMjbA0IuWCxMn+TKJWg38X5 irsDuuqMFh/GLChb7L43VXETg+vsTlgerehSLld98+SokPvbKnIb54OK2glHr9TC+2KoF8ubu91FS V8mpU7HUFON9jZcExJdCo0UsIHJDMO76WZn8RwpmaNa3ILqsN5/lO0CX8ZBVj7ulSsJft6RXIz0kU DKHquyo+X40aRkF9BifLMdRObOfkp3OIgtZcBY2YBPLl1WwJsDBw4tnq4WAUBZRZ8Xigf2zI1GFKU 9A0varRE/8EM0ogwSAK0tXYgREnZQWjVpi/2gFNyBdOytNzd3V0BmChtYZRw2z6dm0GOcWbCRYyu2 aSiKAzFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTHK2-00000006OAf-3uLJ; Mon, 15 Jul 2024 08:44:38 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTHJj-00000006O6t-3yBj for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 08:44:21 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-427aeebaecdso4411155e9.1 for ; Mon, 15 Jul 2024 01:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1721033058; x=1721637858; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WM0yZ3dZzzFTTxe4hgvAgtIJwKRKDgqcOStwGt2gSJ8=; b=FGizMVIT3zyffWIgJAQB8J++MGH9DR2w50BqkaPYsaIHVbB6+KAI6Llv8Zh0YLKQYN PcpwzErDYy4b4/TVbXo14Q+P1WWZJchDpNJK1mhNM2Ph1l/ZQD797pQQ1JWXLvE6aonF wsnvXXtcvn0vdim7lurOiewfVmedZ0O+xG3Q4/ic40ICzTfm8sNqorMl7vIRyyx6nXDG +PlMjjJqNcw0KLKZZYqYbekOX4b2PzwWmFC2denNyFpW9/s4Jg+Z/TBKMBHXfsVs57ws 7JcFrLumRg5ou6+/H6uFiZmPj3RoCRWxk2rhlZR9ns3kesnw9Siolx8M9VCXxp9EllRj IVKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721033058; x=1721637858; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WM0yZ3dZzzFTTxe4hgvAgtIJwKRKDgqcOStwGt2gSJ8=; b=mEfVI7S1T7+EbG+xavIwARFHVlTSiCYeuZV2icqYT8bry7zjD4qX5vMMMh0b+aA4sH EjRqDmFwsy/YHPSun20KhOHRqICTiitpbBaHgstSYJIh45m0p2ZVQ65fzsBeJQXUAhZE s4oazWXGy5cum7QLtdDLzy2D63tPYkBGUnhbgIPnzgOJi0oHsFtAAUqJ9+GqSrDGnYg5 FKV2DjWCGWROOxkDPB4JacYEy4Cj20sKGPXn7F4YwRETgob4B+DAd8CvEyYEYnjlhLWD Ie+A66uj31ReRDjMiF7CKONmnW5hgigHGh+5WiKtfaK+4gDcMs/PHDWx/Y7YEZ/XeYHY PNrg== X-Forwarded-Encrypted: i=1; AJvYcCUKISIaL6SP+YE2Nkr9yVSTIHUpv/FJPm87DkpJ1ZwkD6UNUmnUYKwdG/qIcWekfh82csoxEUHVu/qEXBDgnaF5z3tV0NijWMeT1iAH1UzhXVWyiuc= X-Gm-Message-State: AOJu0YwYQOt4vyxulTOZGvuocuNsGtlh/C1pUB2rbPq1dY1yrVLjmlHZ 2gKZ4vNm5mTLsGYjFhxSWo5dfJCgEzfVF7BVr7Nys1A9N1TmcBRGB+cBHzUmHKA= X-Google-Smtp-Source: AGHT+IGi4ZuAQ/yriu2Z9Cdv2XEyhj7rSOXhNHCWeEiNJIx9fF5ukvI9h0+hmRATjeo6CGGYegYPkw== X-Received: by 2002:a05:600c:a:b0:426:63b8:2cce with SMTP id 5b1f17b1804b1-426707cc06emr117802385e9.7.1721033058270; Mon, 15 Jul 2024 01:44:18 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dabf20dsm5717442f8f.38.2024.07.15.01.44.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 01:44:17 -0700 (PDT) Message-ID: <0ff64285-8a88-421c-96c3-aa10decc8d05@tuxon.dev> Date: Mon, 15 Jul 2024 11:44:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 13/27] clk: at91: sam9x7: add sam9x7 pmc driver Content-Language: en-US To: Varshini.Rajendran@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240703102011.193343-1-varshini.rajendran@microchip.com> <20240703102800.195957-1-varshini.rajendran@microchip.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_014420_017543_09015DC0 X-CRM114-Status: GOOD ( 18.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Varshini, On 15.07.2024 09:46, Varshini.Rajendran@microchip.com wrote: > Hi Claudiu, > > On 14/07/24 7:25 pm, claudiu beznea wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> Hi, Varshini, >> >> On 03.07.2024 13:28, Varshini Rajendran wrote: >>> Add a driver for the PMC clocks of sam9x7 Soc family. >>> >>> Signed-off-by: Varshini Rajendran >>> --- >>> drivers/clk/at91/Makefile | 1 + >>> drivers/clk/at91/sam9x7.c | 946 ++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 947 insertions(+) >>> create mode 100644 drivers/clk/at91/sam9x7.c >>> ... >>> + for (i = 0; i < PLL_ID_MAX; i++) { >>> + for (j = 0; j < 3; j++) { >> >> I now realize that we are alocating more than needed memory for each PLL in >> sam9x7_plls[][]. The number of columns for the 2d array is PLL_ID_MAX and >> it should be 3. I can adjust it when applying but I need you to run a >> simple boot test with it. >> > Yes. It boots and works perfectly with the change suggested. I am > pasting the snippet below just to be on the same page. > > --- a/drivers/clk/at91/sam9x7.c > +++ b/drivers/clk/at91/sam9x7.c > @@ -198,7 +198,7 @@ static const struct { > const struct clk_pll_characteristics *c; > unsigned long f; > u8 eid; > -} sam9x7_plls[][PLL_ID_MAX] = { > +} sam9x7_plls[][3] = { Great! Thank you!