From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Sun, 18 Mar 2018 22:54:48 +0100 Subject: [PATCH v1 12/19] arm: dts: mt7623: fix all Warnings (unit_address_vs_reg) In-Reply-To: <5cf5b140e45b8484eca780b53cc223ba8d1d768b.1519378872.git.sean.wang@mediatek.com> References: <5cf5b140e45b8484eca780b53cc223ba8d1d768b.1519378872.git.sean.wang@mediatek.com> Message-ID: <0ff8d1ab-704a-1263-ec16-a9f3464b5798@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/23/2018 11:16 AM, sean.wang at mediatek.com wrote: > From: Sean Wang > > Fix below a lot of warnings that dtc complains so much > > Warning (unit_address_vs_reg): Node /oscillator at 1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /oscillator at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/cir at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/i2c at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/i2c at 1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/i2s at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/i2s at 1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/keys at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/leds at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/pwm at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/spi at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/uart at 0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/uart at 1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /pinctrl at 10005000/uart at 2 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /ethernet at 1b100000/mdio-bus/switch at 0/ports has a reg or ranges property, but no unit name > > Signed-off-by: Sean Wang > Cc: Rob Herring > Cc: Mark Rutland > Cc: devicetree at vger.kernel.org > --- > arch/arm/boot/dts/mt7623.dtsi | 4 ++-- > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 29 +++++++++++++-------------- > arch/arm/boot/dts/mt7623n-rfb.dtsi | 2 +- > 3 files changed, 17 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi > index 4b68448..bf9db44 100644 > --- a/arch/arm/boot/dts/mt7623.dtsi > +++ b/arch/arm/boot/dts/mt7623.dtsi > @@ -130,14 +130,14 @@ > #clock-cells = <0>; > }; > > - rtc32k: oscillator at 1 { > + rtc32k: oscillator-1 { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <32000>; > clock-output-names = "rtc32k"; > }; > > - clk26m: oscillator at 0 { > + clk26m: oscillator-0 { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <26000000>; > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index a6295ef..75e61c4 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -158,7 +158,6 @@ > ports { > #address-cells = <1>; > #size-cells = <0>; > - reg = <0>; > > port at 0 { > reg = <0>; > @@ -262,14 +261,14 @@ > }; > > &pio { > - cir_pins_a:cir at 0 { > + cir_pins_a:cir-default { > pins-cir { > pinmux = ; > bias-disable; > }; > }; > > - i2c0_pins_a: i2c at 0 { > + i2c0_pins_a: i2c0-default { > pins-i2c0 { > pinmux = , > ; > @@ -277,7 +276,7 @@ > }; > }; > > - i2c1_pins_a: i2c at 1 { > + i2c1_pins_a: i2c1-default { > pin-i2c1 { > pinmux = , > ; > @@ -285,7 +284,7 @@ > }; > }; > > - i2s0_pins_a: i2s at 0 { > + i2s0_pins_a: i2s0-default { > pin-i2s0 { > pinmux = , > , > @@ -297,7 +296,7 @@ > }; > }; > > - i2s1_pins_a: i2s at 1 { > + i2s1_pins_b: i2s1-default { Why does this change from i2s1_pins_a to i2s1_pins_b? > pin-i2s1 { > pinmux = , > , > @@ -309,7 +308,7 @@ > }; > }; > > - key_pins_a: keys at 0 { > + key_pins_a: keys-alt { > pins-keys { > pinmux = , > ; > @@ -317,7 +316,7 @@ > }; > }; > > - led_pins_a: leds at 0 { > + led_pins_a: leds-alt { > pins-leds { > pinmux = , > , > @@ -428,15 +427,15 @@ > }; > }; > > - pcie_default: pcie_pin_default { > - pins_cmd_dat { > + pcie_default: pcie-pin-default { > + pins-cmd-dat { No pcie node present in upstream. Please rebase. Regards, Matthias > pinmux = , > ; > bias-disable; > }; > }; > > - pwm_pins_a: pwm at 0 { > + pwm_pins_a: pwm-default { > pins-pwm { > pinmux = , > , > @@ -446,7 +445,7 @@ > }; > }; > > - spi0_pins_a: spi at 0 { > + spi0_pins_a: spi0-default { > pins-spi { > pinmux = , > , > @@ -456,21 +455,21 @@ > }; > }; > > - uart0_pins_a: uart at 0 { > + uart0_pins_a: uart0-default { > pins-dat { > pinmux = , > ; > }; > }; > > - uart1_pins_a: uart at 1 { > + uart1_pins_a: uart1-default { > pins-dat { > pinmux = , > ; > }; > }; > > - uart2_pins_a: uart at 2 { > + uart2_pins_a: uart2-default { > pins-dat { > pinmux = , > ; > diff --git a/arch/arm/boot/dts/mt7623n-rfb.dtsi b/arch/arm/boot/dts/mt7623n-rfb.dtsi > index 256c5fd..128586d 100644 > --- a/arch/arm/boot/dts/mt7623n-rfb.dtsi > +++ b/arch/arm/boot/dts/mt7623n-rfb.dtsi > @@ -50,7 +50,7 @@ > reg = <0 0x80000000 0 0x40000000>; > }; > > - usb_p1_vbus: regulator at 0 { > + usb_p1_vbus: regulator-5v { > compatible = "regulator-fixed"; > regulator-name = "usb_vbus"; > regulator-min-microvolt = <5000000>; >