From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 160FFC433F5 for ; Sun, 10 Apr 2022 16:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9WBs75kYniivrAwmxL6FDDiWvwYRLdG0G6aAkA7FhMg=; b=sH9CSFa2WRY8Ry 29FP4O1K4mrQrpIHmYFgNiH5FfsshOq4OBD6UprrpapV35uWqjSXCQ+Lr1OGBaBm7/dcqKqwWaLGB ZFKaE2d7SLJ6q3XmHXpfN/wf5yHF1oCM1iixz+ITEf1QP9zM03ssrRuBdMp2M0Jk7Fn2w5U3Wtgiq 6U30Dfw5U+9ZxN5cVfRbW/QTIoGt4JM/78VnRhCWWicKGkEUNfLqjAPrVCWGRmwa0exOE+5pPblUL GgxFEzmJmQURcI2G/Pvi4GQrz6OFzC1zOLtlmjrkNgdR6rTGJE6t8Y079y9I79sh61PPkeCAAQkVD FiBBCAO5VL68QhE9nNkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndaob-0058rJ-MS; Sun, 10 Apr 2022 16:53:29 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndaoY-0058qS-Ag; Sun, 10 Apr 2022 16:53:27 +0000 Received: from p508fdda7.dip0.t-ipconnect.de ([80.143.221.167] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndaoQ-0006ci-8W; Sun, 10 Apr 2022 18:53:18 +0200 From: Heiko Stuebner To: Frank Wunderlich , Peter Geis Cc: Dan Johansen , Frank Wunderlich , "open list:ARM/Rockchip SoC..." , Rob Herring , Krzysztof Kozlowski , Michael Riesch , devicetree , arm-mail-list , Linux Kernel Mailing List Subject: Re: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb Date: Sun, 10 Apr 2022 18:53:17 +0200 Message-ID: <10062144.nUPlyArG6x@phil> In-Reply-To: References: <20220409075147.136187-1-linux@fw-web.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220410_095326_394151_31B5A6A5 X-CRM114-Status: GOOD ( 25.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 9. April 2022, 17:26:01 CEST schrieb Peter Geis: > On Sat, Apr 9, 2022 at 7:56 AM Frank Wunderlich wrote: > > > > Hi, > > > > so to not break the binding and other boards the right Patch should be like this > > > > +++ b/drivers/usb/dwc3/core.c > > @@ -1691,17 +1691,17 @@ static int dwc3_probe(struct platform_device *pdev) > > * Clocks are optional, but new DT platforms should support all > > * clocks as required by the DT-binding. > > */ > > - dwc->bus_clk = devm_clk_get_optional(dev, "bus_early"); > > + dwc->bus_clk = devm_clk_get_optional(dev, "bus_clk"); > > if (IS_ERR(dwc->bus_clk)) > > return dev_err_probe(dev, PTR_ERR(dwc->bus_clk), > > "could not get bus clock\n"); > > > > - dwc->ref_clk = devm_clk_get_optional(dev, "ref"); > > + dwc->ref_clk = devm_clk_get_optional(dev, "ref_clk"); > > if (IS_ERR(dwc->ref_clk)) > > return dev_err_probe(dev, PTR_ERR(dwc->ref_clk), > > "could not get ref clock\n"); > > > > - dwc->susp_clk = devm_clk_get_optional(dev, "suspend"); > > + dwc->susp_clk = devm_clk_get_optional(dev, "suspend_clk"); > > if (IS_ERR(dwc->susp_clk)) > > return dev_err_probe(dev, PTR_ERR(dwc->susp_clk), > > "could not get suspend clock\n"); > > > > but this needs fixing dts using the new clock names > > > > this is a link to the series moving from bulk_clk to named clocks: > > > > https://patchwork.kernel.org/project/linux-usb/patch/20220127200636.1456175-3-sean.anderson@seco.com/ > > > > regards Frank > > I've submitted a fix for the backwards compatibility issue. > https://patchwork.kernel.org/project/linux-rockchip/patch/20220409152116.3834354-1-pgwipeout@gmail.com/ > > This fix is standalone and necessary no matter which route we decide > to go with this series (and the rk3328/rk3399 support as well). > With this patch, dwc3 is functional on the rk356x as the series was > submitted, so if we decide to fix everything all at once, that is a > viable option. Thanks for doing that fix. As the usb-dt-series is actually following the rockchip,dwc3 binding, and "just" the driver does ignore it, I've now applied the usb series and hope for a resolution of the general problem :-) Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel