From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38DD6C47DD9 for ; Wed, 27 Mar 2024 14:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9eaMJ+RX9iBA/ntHmtOsOYaJ0yYnT9OuK46WytZb1YU=; b=MJby1KZLjHuYB/ DJvmiCrcrH4sv7ZNajnw7pIcuLPnhtXavTt9JmzAmz19F9eUTv1TfCQm44F3D6etBcc4CHuiTM/HB ghq1LsayOrjIvQ+ypMT38285xiHWyAQakE6j0+Vs1pHXuz9w8DsUZx6OVBoIG4SHdrkexaPGE5CIJ CdAn2x13U4NkU43ifGnOKLqpkT0CDS3FKPgvn77cz3m1Q1Wh/OyVTOAhZUCf0FH3E0z5g7xQ28hMJ RYyomRKTnax9PcAO/l/AwC4+5xeliaHvXPPqkmVxECRPP9tsqpqYh0V3cRbDnIS6ND/gnlQ4jHYj0 wR3YxnzvIvImUgjXteiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpUiq-00000009dCy-2ewA; Wed, 27 Mar 2024 14:57:48 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpUim-00000009dAm-3nEb for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 14:57:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711551462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0fE+RnDfOth0R7Oh5Kfc3He6SD3W0/HGyJDPHY8kVAI=; b=DJEuHwN+8YfyQnGj9jlqrfTn58M0wyu2wXaKVRVBVbe6B9lLKr2vxi+3f23BFUSuZAPpYd a7t6tWELsQpGV5jrCIYXe39jb1XAsEh6imDKUK70AufZIoeY5uv3duRdxtoH+IXa2rSy2W qvgPGxeckuT1EgZG3BOuCCjUI60r010= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-2cAyF-wYPV2czXPkqtroaA-1; Wed, 27 Mar 2024 10:57:40 -0400 X-MC-Unique: 2cAyF-wYPV2czXPkqtroaA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33ec604d3b3so4084931f8f.1 for ; Wed, 27 Mar 2024 07:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711551459; x=1712156259; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0fE+RnDfOth0R7Oh5Kfc3He6SD3W0/HGyJDPHY8kVAI=; b=ow9qY+1Eko4Eryf0TYwJv996fUyCcjOkvJWcRA/aWohBZ9e2ClffZ0LFZH4yw+j4Fv 6APykJAmoOPwLzpGfq88MYthXM+UxsH27ZAqBh75NrIhVwWoFYq/AsI6V5C+1HfsQJm6 e2lwS1shtkVKmgsN66vZOTz8hgD48QNGzrEpDfg5lHkaKO9jv2hGLAu0T1jbpGyS3iVK mfBdNvUT1/BgxkiBzdmzsWlaWhCbdKBGkLdnR6D8QrqEuhIK1RkQvY15iuhPlFOfxRD0 h81DeH6sVYbBYKIjltU1MoSDBdBlL19v5tADBP7gExWQ4o/NpRywMKkzWhYFE4L2xJ9t 4V+w== X-Forwarded-Encrypted: i=1; AJvYcCVSN8aol6EBbrehjA2xY9M3uByZt856sUrNGDV/kNZ2jIIhlM3H4BIMjyEsim9wQKixlv8VHAZGTxoY9350D/AOn0ocCtX2HdItZ+Ns9QLaTOgxSw0= X-Gm-Message-State: AOJu0Yxa9qb8tE7NMOyRt9TZRAhNneX8ytE+GJzqFGyDhpJ5ko/z946R nUkiJD6sx6F5zX5SQHOtmMqkQAOyvRzuUjrq4WYycTXZwM5jbYODOzmpcKBf61E4FnSmXjSdTXN yFRmJjUBg+u4h9folVXPlAz3vx3Erbpc4wIe5JdlQ8IBPo31A4Qc2/odtiHNxxqB3pSRbXuFJ X-Received: by 2002:adf:e9c5:0:b0:33e:9b42:ba5 with SMTP id l5-20020adfe9c5000000b0033e9b420ba5mr159336wrn.17.1711551459429; Wed, 27 Mar 2024 07:57:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAvZMPi9idbs5gCjuXfzA0MPUdg0By4phuZBqG4kMIunlfX880q3vYkz7op1APnMIcFHYGeA== X-Received: by 2002:adf:e9c5:0:b0:33e:9b42:ba5 with SMTP id l5-20020adfe9c5000000b0033e9b420ba5mr159323wrn.17.1711551459055; Wed, 27 Mar 2024 07:57:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:8a00:362b:7e34:a3bc:9ddf? (p200300cbc7088a00362b7e34a3bc9ddf.dip0.t-ipconnect.de. [2003:cb:c708:8a00:362b:7e34:a3bc:9ddf]) by smtp.gmail.com with ESMTPSA id dv13-20020a0560000d8d00b0033e25c39ac3sm15064157wrb.80.2024.03.27.07.57.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 07:57:38 -0700 (PDT) Message-ID: <1006392c-c437-46c0-9a2e-e25e52236b67@redhat.com> Date: Wed, 27 Mar 2024 15:57:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] arm64: mm: swap: support THP_SWAP on hardware with MTE To: Matthew Wilcox , Barry Song <21cnbao@gmail.com> Cc: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, hughd@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, chrisl@kernel.org, mark.rutland@arm.com, ryan.roberts@arm.com, steven.price@arm.com, Barry Song , Kemeng Shi , Anshuman Khandual , Peter Collingbourne , Yosry Ahmed , Peter Xu , Lorenzo Stoakes , "Mike Rapoport (IBM)" , "Aneesh Kumar K.V" , Rick Edgecombe References: <20240322114136.61386-1-21cnbao@gmail.com> <20240322114136.61386-2-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_075745_026859_3ED3F84D X-CRM114-Status: GOOD ( 15.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27.03.24 15:53, Matthew Wilcox wrote: > On Sat, Mar 23, 2024 at 12:41:36AM +1300, Barry Song wrote: >> Commit d0637c505f8a1 ("arm64: enable THP_SWAP for arm64") brings up >> THP_SWAP on ARM64, but it doesn't enable THP_SWP on hardware with >> MTE as the MTE code works with the assumption tags save/restore is >> always handling a folio with only one page. >> >> The limitation should be removed as more and more ARM64 SoCs have >> this feature. Co-existence of MTE and THP_SWAP becomes more and >> more important. >> >> This patch makes MTE tags saving support large folios, then we don't >> need to split large folios into base pages for swapping out on ARM64 >> SoCs with MTE any more. > > Can we go further than this patch and only support PG_mte_tagged and > PG_mte_lock on folio->flags instead of page->flags? We're down to using I think we discussed that already and what I learned is that it "gets a bit complicated". But I'm hoping we can get that discussion started again. > page->flags for these two MTE bits, a whole lot of s390 junk, PG_hwpoison, > PG_head, PG_anon_exclusive and Zone/Section/Node/KASAN/last_cpupid. ... just like PG_anon_exclusive "gets a bit complicated". Well, I think I might have finally found a way to make it work, I'll only have to uglify fork() a bit. -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel