From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92513C433EF for ; Thu, 10 Mar 2022 07:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nn1AMfAdIPEeVUQORlUvGvRcUUzEXtIimWWrgJEt+0I=; b=J7f5MW8zqJh29u yc1vdqb8EdtQ6SAxo2tjzlqniLDBKRIyr8Xt6ixIFCltFkUNn7FIfNp6SYDPXVaNxynQf13EoZ45H D2MBtgpl5QlafpDuZtAENW2G9kUQb3VCq+mc3KoHQTnpGi2NuFtPVGdlB6yIU0OoY9qJ8iCGynREB /08SBsdDVUFeVYX2Ew3hRUdUCS5U56PsMnBO82YRWnRoTqBfVY7O2RR2w/4uwBFG2CoHD3HGNJg2P r1hL9sxgUE4qMUdzMcwhBFKSrSEmQohihFrS9BPraZ6G2gRF0y147ZY++swWGseplOc4dNcDVLBLf G3/5XLYKbLCc9oNk0Q4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSD6p-00Bip7-Uv; Thu, 10 Mar 2022 07:21:16 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSD6m-00Bimj-2p for linux-arm-kernel@lists.infradead.org; Thu, 10 Mar 2022 07:21:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1646896872; x=1678432872; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SDMH4Lrut+v6QvvwgHR3CQKGCpHrAskEKeuCGP50BE8=; b=jiI09IX7RErlHXzZI67AtkZy9+eQIjP8OJZxKeCMew9ypIDD0hjt0CoF 0avJuuDPXrnyAEq1ajKi7jQUSheNV+6RGzEM6AOE+cqH7JqDMmTjt3zMB y2xKU2yt78KAdRVgODKtRRtsXVKcVQ+bhx/EkxN0oeeUP2jejLzuIs7pV BbB8woL/paAhm49q/Jy1l4ywc3NPQoo/MF23oTh/USAsZZ4ogFnTRZf1c 24c1AtbzF2f9t8VU38FqUI2zmabC28KJtLAghb8wTbHJTqJqb8ALDMqeP /uQKab7swviCTKuvXDbh7WPsAtCb14BXZnZuEx6eS/rl18MqDLv7aAbgb w==; X-IronPort-AV: E=Sophos;i="5.90,169,1643670000"; d="scan'208";a="22572217" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 10 Mar 2022 08:21:08 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 10 Mar 2022 08:21:08 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 10 Mar 2022 08:21:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1646896868; x=1678432868; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SDMH4Lrut+v6QvvwgHR3CQKGCpHrAskEKeuCGP50BE8=; b=FpHmwVzcwUsd4W9Ic93ndFvYxPXYS145rE63qz9YnIM8DBkzNeCCwxwJ FQSWkDEDxAFJYpAHfAoO5CKr1U+v0F3DidcX8jjp32semXKBVj759hita ovLqgq0rLn1QdTqyYDI6rK1Q6EbPRB8A7A6m3sOR/3vukShnI8X49BJ3g 2FqZn4HCBmgIjWvrnIwZ9A5FiRiLnor62mmfbwFgLIRZP3hmVVj4q3pOy XkGGEyLJ87rCNHMr+nAgJRHn7t+ehCDfOCqJqje+9uqIGP4IGyIf6Lhc3 gLIsov3J++32B6mg/F8H/kXTYL31AEknmavIO4NztdOcbP1jI/xIvOFnp Q==; X-IronPort-AV: E=Sophos;i="5.90,169,1643670000"; d="scan'208";a="22572216" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 10 Mar 2022 08:21:08 +0100 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 1F707280065; Thu, 10 Mar 2022 08:21:08 +0100 (CET) From: Alexander Stein To: Xavier Roumegue Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, stanimir.varbanov@linaro.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ideasonboard.com, robh+dt@kernel.org, nicolas@ndufresne.ca, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Xavier Roumegue Subject: Re: (EXT) [PATCH v3 8/9] media: dw100: Add i.MX8MP dw100 dewarper driver Date: Thu, 10 Mar 2022 08:21:05 +0100 Message-ID: <10066981.nUPlyArG6x@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20220308201038.48386-9-xavier.roumegue@oss.nxp.com> References: <20220308201038.48386-1-xavier.roumegue@oss.nxp.com> <20220308201038.48386-9-xavier.roumegue@oss.nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220309_232112_504863_82771B8D X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Xavier, thanks for trying to mainline this hardware support. Am Dienstag, 8. M=E4rz 2022, 21:10:37 CET schrieb Xavier Roumegue: > Add a V4L2 mem-to-mem driver for the Vivante DW100 Dewarp Processor IP > core found on i.MX8MP SoC. > = > The processor core applies a programmable geometrical transformation on > input image to correct distorsion introduced by lenses. > The transformation function is exposed as a grid map with 16x16 pixel > macroblocks indexed using X, Y vertex coordinates. > = > The dewarping map can be set from application through dedicated a v4l2 > control. If not set or invalid, the driver computes an identity map > prior to start the processing engine. > = > The driver supports scaling, cropping and pixel format conversion. > = > Signed-off-by: Xavier Roumegue > --- > [snip] > diff --git a/drivers/media/platform/dw100/dw100.c > b/drivers/media/platform/dw100/dw100.c new file mode 100644 > index 000000000000..7e1fcdfe5b91 > --- /dev/null > +++ b/drivers/media/platform/dw100/dw100.c > @@ -0,0 +1,1744 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * DW100 Hardware dewarper > + * > + * Copyright 2022 NXP > + * Author: Xavier Roumegue (xavier.roumegue@oss.nxp.com) > + * > + */ > [snip] > +static const struct v4l2_ctrl_config ctrl_custom_lut =3D { > + .id =3D V4L2_CID_DW100_MAPPING, > + .name =3D "Look-Up Table", > + .type =3D V4L2_CTRL_TYPE_U32, > + .min =3D 0x00000000, > + .max =3D 0xFFFFFFFF, > + .step =3D 1, > + .def =3D 0, > + .dims =3D { DW100_MAX_LUT_NELEMS }, > + .flags =3D V4L2_CTRL_FLAG_DYNAMIC_ARRAY, > +}; I know right now there is only one control, but you are reserving 16 contro= ls = in PATCH 5/9. So for me it seems sensible to make this an array already, so = that additional controls can be added here easily. > [snip] > + hdl =3D &ctx->hdl; > + v4l2_ctrl_handler_init(hdl, 1); > + v4l2_ctrl_new_custom(hdl, &ctrl_custom_lut, NULL); IMHO this won't need any further changes if an array is already being used. I'm eager to try it once you can provide an example how to use it. Regards Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel