From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A41AC43334 for ; Fri, 8 Jul 2022 14:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VjWk8XSFsqjrS6YtfUCqVbjNVXv036L+ahsBueD6ruE=; b=hKql8rnibwBdYW 1TN808GdIIhpQBRoPZeTaBrOcDT55dvjFP7ZSzoZFs9TMCGMnZ549lvEpXeIobB/bArEvUhe1OL4z bVd28vQOqB6XqjfIyPwKyJ2wlo8xRD3b3mwACo6GHZto5quuSGvdM8NDQfLPQ2j1KLJ7VrUq8vo5E fiSzGcDhJbKMTfcLd+ob6WxArNyFcZmCSv7Umh45dA1N9S4l+/nH2Mpd/NI8eL7rjHjHmDKGoKG/G /4dno0RjgVU7G/cWMLHyBfXur8RkcHm/0Fe+ffet1hd4uDDnEUWn1YVxR0ASaCXB+LDFSXd+WG07k Ui3VGdI8JwdZaiF9S4pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9okh-0045fN-9X; Fri, 08 Jul 2022 14:14:39 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9okd-0045dr-NU for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 14:14:37 +0000 Received: by mail-ej1-x633.google.com with SMTP id u15so13516822ejx.9 for ; Fri, 08 Jul 2022 07:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z0XOec91623/KuMv+Ej/7gZUuHsCJ62v6usunFr5b6A=; b=f6IhZTBULbQ7llaZot4o9crrDH/bVkSBG4cnMtEpeURfPACgFjn6vJq/r5K9ktnt1p LERVggmRob4jL/GCkTX2w7v74r1KkY3FTdHWj4yihWbrOZUOANV5aUCghGUOwU0dnxko /PZTw+0EqCC4O3OgTunDclurFhOm+fOeM7DwyLzfawWZNxV75iEId53Bz12llAwF3zZA CxlP1Y+szHux5dgocUVRRMZVsnAep+OILxAx64nCQmbv+MyobgioKifPwL4r/ZjZE8Ln pQduBNe9DY1hriNkcdpRfW0SVuCcc5CUW3dFFnTn/mtPcA5nKFiMo8hNefUcad7CmpbW 7uVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z0XOec91623/KuMv+Ej/7gZUuHsCJ62v6usunFr5b6A=; b=dglw0TGTjVFUNA04NBkwWS/s6t/U7IEaOhtYPeTJJCeBxGBwb85fIMrMGqRgMVAlB0 lXVYvDNXvcvP/ftRyhhp12/Evvg8ceruR0JS3eeZK+I9QXW/H43k8dT/s34p9mve+LaL Ahwb/AJwfW1116PSzMKCo1AaNhs8XNBjzb3ZL9fI/Vh+BmZOOAq45a/b8Md+K95JfoBq qHMMwnjO4g9WCySoEYV0af5QJxCK7tJ40VM6rDn86KdIIpANNK7EGZQhNIZN/SwHDLRi 9TtByn2Vy0uXoTvz3wDHo/bJMp+pdntTD8L/7O8Wn4XkB95NfO2o202SA3AEw1ON9lGu 7NLQ== X-Gm-Message-State: AJIora+TRqFEyflZRA0F9YG+qPGzC9VDwjK/xAfBQASw9U70p4Q+UTib yakJ093Y7DuYwmiy7WyQpoM= X-Google-Smtp-Source: AGRyM1v6rPWBPZilFN90Jv15KQMt+j6kMHP6jk8djEs05COCTktH+9O11oNXRuqjRUVfaq+6AN/t3g== X-Received: by 2002:a17:907:3dac:b0:722:e6ab:8d9 with SMTP id he44-20020a1709073dac00b00722e6ab08d9mr4190126ejc.20.1657289674494; Fri, 08 Jul 2022 07:14:34 -0700 (PDT) Received: from jernej-laptop.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id q2-20020a170906a08200b006fed93bf71fsm20603401ejy.18.2022.07.08.07.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 07:14:34 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Michal Suchanek , Samuel Holland Cc: linux-sunxi@lists.linux.dev, Icenowy Zheng , Andre Przywara , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sunxi: dts: Fix SPI NOR campatible on Orange Pi Zero Date: Fri, 08 Jul 2022 16:13:11 +0200 Message-ID: <10106175.nUPlyArG6x@jernej-laptop> In-Reply-To: <0c575068-abd7-c69a-e59c-3140f8cb7813@sholland.org> References: <20220707174801.36e010da@donnerap.cambridge.arm.com> <20220707170721.20225-1-msuchanek@suse.de> <0c575068-abd7-c69a-e59c-3140f8cb7813@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_071435_795711_C2770C07 X-CRM114-Status: GOOD ( 24.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, sorry, but I was a bit too quick with giving r-b line. See comments below. Dne petek, 08. julij 2022 ob 09:36:26 CEST je Samuel Holland napisal(a): > Hi Michal, > > The subject prefix should start with "ARM: dts:" (e.g. "ARM: dts: sunxi:"). > Generally it is a good idea to look at the log of the file and follow the > pattern you see there. > > On 7/7/22 12:07 PM, Michal Suchanek wrote: > > Without "jedec,spi-nor" compatible the flash memory cannot be probed by > > u-boot. The macronix part is what is shipped on the boards that come > > with a flash chip. Please reword this a bit. DT isn't user specific, so U-Boot should not be mentioned. But you can write about compatible being wrong. According to DT bindings, it should be manufacturer specific compatible, followed by "jedec,spi-nor". Once both issues are addressed, you can keep my r-b tag and include fixes tag posted by Sameul. Best regards, Jernej > > Fixes: 45857ae95478 ("ARM: dts: orange-pi-zero: add node for SPI NOR") > > Regards, > Samuel > > > Signed-off-by: Michal Suchanek > > --- > > > > arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > > b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts index > > f19ed981da9d..3706216ffb40 100644 > > --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > > +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts > > @@ -169,7 +169,7 @@ &spi0 { > > > > flash@0 { > > > > #address-cells = <1>; > > #size-cells = <1>; > > > > - compatible = "mxicy,mx25l1606e", "winbond,w25q128"; > > + compatible = "mxicy,mx25l1606e", "jedec,spi-nor"; > > > > reg = <0>; > > spi-max-frequency = <40000000>; > > > > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel