Re: [PATCH v2] sunxi: dts: Fix SPI NOR campatible on Orange Pi Zero

Jernej Škrabec
2022-07-08T14:15:34Z

Hi Michal,

sorry, but I was a bit too quick with giving r-b line. See comments below.

Dne petek, 08. julij 2022 ob 09:36:26 CEST je Samuel Holland napisal(a):
> Hi Michal,
>
> The subject prefix should start with "ARM: dts:" (e.g. "ARM: dts: sunxi:").
> Generally it is a good idea to look at the log of the file and follow the
> pattern you see there.
>
> On 7/7/22 12:07 PM, Michal Suchanek wrote:
> > Without "jedec,spi-nor" compatible the flash memory cannot be probed by
> > u-boot. The macronix part is what is shipped on the boards that come
> > with a flash chip.

Please reword this a bit. DT isn't user specific, so U-Boot should not be
mentioned. But you can write about compatible being wrong. According to DT
bindings, it should be manufacturer specific compatible, followed by
"jedec,spi-nor".

Once both issues are addressed, you can keep my r-b tag and include fixes tag
posted by Sameul.

Best regards,
Jernej

>
> Fixes: 45857ae95478 ("ARM: dts: orange-pi-zero: add node for SPI NOR")
>
> Regards,
> Samuel
>
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >
> > arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> > b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts index
> > f19ed981da9d..3706216ffb40 100644
> > --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> > +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> > @@ -169,7 +169,7 @@ &spi0 {
> >
> > flash@0 {
> >
> > #address-cells = <1>;
> > #size-cells = <1>;
> >
> > - compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> > + compatible = "mxicy,mx25l1606e", "jedec,spi-nor";
> >
> > reg = <0>;
> > spi-max-frequency = <40000000>;
> >
> > };