From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v2 04/13] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions
Date: Mon, 11 May 2015 20:53:49 +0200 [thread overview]
Message-ID: <10106387.CZmapdhaD3@wuerfel> (raw)
In-Reply-To: <5550F174.6000709@redhat.com>
On Monday 11 May 2015 20:14:12 Hans de Goede wrote:
> Also note, that as I've tried to explain in the commit message already this commit
> makes no functional changes what so ever, the generic musb_default_read/write_fifo
> functions are only used by musb platforms which do not overwrite musb_write* /
> musb_read* and musb_write* / musb_read* are already just thin wrappers around
> the __raw_* functions.
Oh, that's a bit odd: That would mean that the defaults are also broken on
big-endian platforms, and fixing them would introduce the bug here, unless your
patch is applied.
Any idea why musb uses the __raw_* functions to start with? Can we change
them to read?_relaxed()/write?_relaxed() now that those are available on
all architectures?
Arnd
next prev parent reply other threads:[~2015-05-11 18:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 19:11 [PATCH v2 00/13] musb: Add support for the Allwinner sunxi musb controller Hans de Goede
2015-03-20 19:11 ` [PATCH v2 01/13] phy-sun4i-usb: Add full support for usb0 phy / OTG Hans de Goede
2015-03-20 19:11 ` [PATCH v2 02/13] musb: Make musb_write_rxfun* and musb_write_rxhub* work like their tx versions Hans de Goede
2015-03-20 19:11 ` [PATCH v2 03/13] musb: Make busctl_offset an io-op rather then a define Hans de Goede
2015-03-20 19:11 ` [PATCH v2 04/13] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions Hans de Goede
2015-05-11 15:58 ` Felipe Balbi
2015-05-11 16:21 ` Arnd Bergmann
2015-05-11 18:14 ` [linux-sunxi] " Hans de Goede
2015-05-11 18:53 ` Arnd Bergmann [this message]
2015-05-11 19:11 ` Hans de Goede
2015-03-20 19:11 ` [PATCH v2 05/13] musb: Fix platform code being unable to override ep access ops Hans de Goede
2015-03-20 19:11 ` [PATCH v2 06/13] musb: Add support for the Allwinner sunxi musb controller Hans de Goede
2015-03-21 2:04 ` Chen-Yu Tsai
2015-03-21 9:30 ` Hans de Goede
2015-05-26 15:48 ` Felipe Balbi
2015-05-26 16:36 ` Hans de Goede
2015-05-26 17:06 ` Felipe Balbi
2015-03-20 19:11 ` [PATCH v2 07/13] ARM: dts: sun4i: Add USB Dual Role Controller Hans de Goede
2015-03-20 19:11 ` [PATCH v2 08/13] ARM: dts: sun5i: " Hans de Goede
2015-03-20 19:11 ` [PATCH v2 09/13] ARM: dts: sun7i: " Hans de Goede
2015-03-20 19:11 ` [PATCH v2 10/13] ARM: dts: sun4i: Enable USB DRC on Chuwi V7 CW0825 Hans de Goede
2015-03-20 19:11 ` [PATCH v2 11/13] ARM: dts: sun5i: Enable USB DRC on UTOO P66 Hans de Goede
2015-03-20 19:11 ` [PATCH v2 12/13] ARM: dts: sun7i: Enable USB DRC on Cubietruck Hans de Goede
2015-03-20 19:11 ` [PATCH v2 13/13] ARM: dts: sun7i: Enable USB DRC on A20-OLinuxIno-Lime Hans de Goede
2015-03-23 16:49 ` [PATCH v2 00/13] musb: Add support for the Allwinner sunxi musb controller Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10106387.CZmapdhaD3@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox