[PATCH V2 1/2] dt/bindings: serial: bcm2835: add binding documentation for bcm2835-aux-uart

Martin Sperl
2016-01-10T10:49:19Z

> On 09.01.2016, at 21:53, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Saturday 09 January 2016 13:07:32 kernel at martin.sperl.org wrote:
>> +
>> + uart1: uart at 7e215040 {
>> + compatible = "brcm,bcm2835-aux-uart";
>> + reg = <0x7e215040 0x40>;
>> + interrupts = <1 29>;
>> + clocks = <&aux BCM2835_AUX_CLOCK_UART>;
>> + };
>>
>
> The node name should always be "serial at ...", not "uart at ..."
>
> Arnd

The existing dts arch/arm/boot/dts/bcm2835.dtsi already contains:
uart0: uart at 7e201000 {
compatible = "brcm,bcm2835-pl011", "arm,pl011", "arm,primecell";
reg = <0x7e201000 0x1000>;
interrupts = <2 25>;
clocks = <&clocks BCM2835_CLOCK_UART>,
<&clocks BCM2835_CLOCK_VPU>;
clock-names = "uartclk", "apb_pclk";
arm,primecell-periphid = <0x00241011>;
};
for the primary uart.

So I was just following that example and would hesitate to
use a different nomenclature in the same file (even though I
saw serial examples elsewhere).

I guess this is a more general thing that needs to get resolved.

If you tell me to re-spin the patch because of this then I can do that,
but that would not solve the issue with uart0.

Thanks,
Martin