From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE6B5CD13D2 for ; Sat, 31 Aug 2024 13:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xVas2nbtwjp9aJsPq4W6cm0leZn3Xl11wuSo0LagmYc=; b=YLh6gJDOtyR+ZuQe2hq8N+bo6L +OcZSwSery+Vs4F4cacyHHBwpVLeuxMRpQ3tIXd2vowXnArCrZEpXinlM9t/VMitkydVPCiVlmgJj Z6dsleT8cgIMNFk3ECAnkS8+umzvFtTarYgUVz2NmtgtaGYE2Rbn21yZfjn4y+6xaUgBMKSluQ5OR i3v9VQElsdoO3miWQLvZHRdhxHv0m5Q/Ir/1ZE//igFgm7snyCTfH8qARRvM4wPGiQh3orXddEroN zTqq+6EYhEu1cCswo5bsraILWQt8uMqoXVOBntAOyumApfQA1+BPBm3Ef/P1vjYL2gMRPoFANxpOx 0rUhKiZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skOcb-00000009SH6-0y6x; Sat, 31 Aug 2024 13:58:33 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skObi-00000009S7R-0kRe; Sat, 31 Aug 2024 13:57:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xVas2nbtwjp9aJsPq4W6cm0leZn3Xl11wuSo0LagmYc=; b=d+SgYgIaeWmE5w0q11SZJGy9SX /27jGu9sSm0xKIhHODE5vwQ0ivyRJQTLcaFDiUJ4/0BadsaeNdpmYrC+ORJ4R2GzCRMgPoagqJYIc GToc1c2K1VcZQIUJuby0zA22v/qr647yFhtjhi1o5Hm6ydrPFhCQv+j5rK85Nsn8GTj3JQbFuzjpS vV1tm+3v+x1k+oX/JsGQPIMadW7Vq4bqazMfxX/Tv1SvUH6N5H7fr7nRfR97d7c8p5Z5eTc/u8Iyf nleqaHazP2U1/QrmMucudPHdwl38+Dpp3aoRtDtD+pfiJtJV0aceKNIkqasxeo3P9kMj+KtMIbwQO mWNzwBzQ==; Received: from i53875be3.versanet.de ([83.135.91.227] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1skOb9-0003xk-5H; Sat, 31 Aug 2024 15:57:03 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Cristian Ciocaltea , Krzysztof Kozlowski Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao , Sascha Hauer , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer Subject: Re: [PATCH v5 1/4] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP Date: Sat, 31 Aug 2024 15:58:31 +0200 Message-ID: <10210346.L8ug28u51p@diego> In-Reply-To: <57wj2vwjv7eehlix2bmvbm3z4agv5fsyp6vmwwqzotkdsadx7n@azqg2kkaeuxz> References: <20240831-b4-rk3588-bridge-upstream-v5-0-9503bece0136@collabora.com> <20240831-b4-rk3588-bridge-upstream-v5-1-9503bece0136@collabora.com> <57wj2vwjv7eehlix2bmvbm3z4agv5fsyp6vmwwqzotkdsadx7n@azqg2kkaeuxz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240831_065738_291037_1A3DB6AB X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Samstag, 31. August 2024, 08:16:26 CEST schrieb Krzysztof Kozlowski: > On Sat, Aug 31, 2024 at 12:55:29AM +0300, Cristian Ciocaltea wrote: > > + clocks: > > + minItems: 4 > > + maxItems: 6 > > + items: > > + - description: Peripheral/APB bus clock > > + - description: EARC RX biphase clock > > + - description: Reference clock > > + - description: Audio interface clock > > + additionalItems: true > > What is the usefulness of all this? How can you even be sure that each > implementation of this core will have exactly these clocks? > > > + > > + clock-names: > > + minItems: 4 > > + maxItems: 6 > > + items: > > + - const: pclk > > + - const: earc > > + - const: ref > > + - const: aud > > + additionalItems: true > > + > > + interrupts: > > + minItems: 4 > > + maxItems: 5 > > + items: > > + - description: AVP Unit interrupt > > + - description: CEC interrupt > > + - description: eARC RX interrupt > > + - description: Main Unit interrupt > > If these are real pins, then this seems more possible, but > additionalItems does not make me happy. So while not "pins", the interrupts are separately specified in the SoC's list of interrupts in the GIC: RK3588 has: 201 irq_hdmitx0_oavp 202 irq_hdmitx0_ocec 203 irq_hdmitx0_oearcrx 204 irq_hdmitx0_omain 392 irq_hdmitx0_hpd and another set of all of them for hdmitx1 and RK3576 using the same hdmi IP has: 370 irq_hdmitx_oavp 371 irq_hdmitx_ocec 372 irq_hdmitx_oearcrx 373 irq_hdmitx_omain 399 irq_hdmitx_hpd so I guess the fifth interrupt is meant to be the hotplug? Though I guess this should be specificed in the name-list too. >From the SoC's manual it looks like the controller is set up from different modules. Like AVP is the audio-video-packet-module, there is a Main and CEC Module as well as a eARC RX controller inside. I'd guess it might be possible other SoC vendors could leave out specific modules? TL;DR I think those clocks and interrupts are dependent on how the IP core was synthesized, so for now I'd think we can only guarantee that they are true for rk3588 and rk3576. So I guess they should move to the rockchip-specific part of the binding until we have more hdmi-qp controllers in the field? Heiko