From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D25EC64ED9 for ; Tue, 14 Feb 2023 14:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k0CY6VhbKWfH2fgi6/jsY8/gA8HLZ90u4ssMNOmo09o=; b=cmMeFWNyzD2QOO avif8wdE8Ecr4+hi6jL/SNWvAOSCR+G2tgxOJC3/piFDeX0DpAN0ZrC87dQu46ZZK6KYTSEeWv9Pd ZJKoIeJnZ60pwrMoQaIgs1NU70bYfVzhE+TvRFH6n+Jp5uuLR8PsIqcWO50wNacMCq2+5o8Emzde0 KMdAjukiqsYYv4nXiGfIPwfFa+oIrD+W/pMSFQ5llfswJVz4FTsMBa9bAfUVg6JSQ8pRdWjGxsrad lcvEFKpezLkPNWo/M1T6bISn/PQXqbC2XhuCAjSEjtKuTmFl9mDzYEzVVn2fuoIwsUyjE+mneIFtq Rvt556wKMWIEuMAK8y6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRw9Z-0025jA-FG; Tue, 14 Feb 2023 14:19:31 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRvaG-001mDb-0M for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 13:43:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676382180; x=1707918180; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aaMwux03jBEKJ1Pb/onCryTf/9UpBBkIzGoSYw5GpeI=; b=i3+oKFKADywZQ+3PEUN4nAqLdC++jdMyVgJDc49ZrLjnMsHnVs3bbnr5 rmZjYI4g3KA6eTdNMhSmLuHPzEFQBponokKnFvPu9ztl81ov/8eqwtIQG VAw2krgMQ02msZpXQ2RBeQTevUT4jhjpOwjpB3XtRv3nPbOvFL7PEXD4L KlQTfRZj1iUGax+Y6RwvdROXyCj2f8jy1cp+GxCBUuayL08bRByMHHb2m SPpKnVSdLsJ3ipKnrKHdM+vJ8KVPSpkHVmE+EqtXI/3s02W+b7j4jt/gs Z/eNc3wnBineErwvmqtbbpWmGPlBj2h/i+uIEGHPyW+hc7twFDOSLhZcj A==; X-IronPort-AV: E=Sophos;i="5.97,296,1669071600"; d="scan'208";a="29074823" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 14 Feb 2023 14:42:57 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 14 Feb 2023 14:42:57 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 14 Feb 2023 14:42:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1676382177; x=1707918177; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aaMwux03jBEKJ1Pb/onCryTf/9UpBBkIzGoSYw5GpeI=; b=GsADJs99Y9ppRaYXXd2lREIqu5lN2jlfn9CmE8pm11/CJpaQENd2fpcK NzA3gNtyhjBgQn0+p9JMCJuZW4TIcb3GM6Q+foYWN//E7c4kkmqbjKaYG 0s8tTiyptcZ23qZRWUPAgN/+lrmKB/8TeCjEQcAv9gcd6iKf6gEJPfl9+ /QOfQBSsn1uOhNDoRhg012S4dR9MRGCHhRlYc6CJD6w/sec5pp7V6woFl xjl4di0TCn49FDfZCnRZm40vIuurGWRzjOKJ3OhBeWnR3I240PBpvOJkh OdHtynAehxAMIa0SKfAQkMVze79BLpxGgt0T4fLoP8VRwou9SqMFpHISX A==; X-IronPort-AV: E=Sophos;i="5.97,296,1669071600"; d="scan'208";a="29074821" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 14 Feb 2023 14:42:57 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id B1F1C280056; Tue, 14 Feb 2023 14:42:56 +0100 (CET) From: Alexander Stein To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Liu Ying Cc: marex@denx.de, stefan@agner.ch, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, krzysztof.kozlowski@linaro.org, LW@karo-electronics.de Subject: Re: [PATCH v3 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge Date: Tue, 14 Feb 2023 14:42:54 +0100 Message-ID: <10229432.nUPlyArG6x@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230213085612.1026538-3-victor.liu@nxp.com> References: <20230213085612.1026538-1-victor.liu@nxp.com> <20230213085612.1026538-3-victor.liu@nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230214_054300_470436_7D8AA9B1 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, thanks for the update. Am Montag, 13. Februar 2023, 09:56:08 CET schrieb Liu Ying: > A valid bridge is already found in lcdif_attach_bridge() and set > to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop > the unnecessary NULL pointer check in KMS stage. > = > Signed-off-by: Liu Ying > --- > v2->v3: > * No change. > = > v1->v2: > * Split from patch 2/2 in v1. (Marek, Alexander) > = > drivers/gpu/drm/mxsfb/lcdif_kms.c | 33 +++++++++++-------------------- > 1 file changed, 12 insertions(+), 21 deletions(-) > = > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > b/drivers/gpu/drm/mxsfb/lcdif_kms.c index 262bc43b1079..e54200a9fcb9 1006= 44 > --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c > +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c > @@ -394,7 +394,7 @@ static void lcdif_crtc_mode_set_nofb(struct > lcdif_drm_private *lcdif, struct drm_display_mode *m =3D > &lcdif->crtc.state->adjusted_mode; > u32 bus_flags =3D 0; > = > - if (lcdif->bridge && lcdif->bridge->timings) > + if (lcdif->bridge->timings) > bus_flags =3D lcdif->bridge->timings->input_bus_flags; > else if (bridge_state) > bus_flags =3D bridge_state->input_bus_cfg.flags; > @@ -463,30 +463,21 @@ static void lcdif_crtc_atomic_enable(struct drm_crtc > *crtc, struct drm_display_mode *m =3D &lcdif->crtc.state->adjusted_mode; > struct drm_bridge_state *bridge_state =3D NULL; > struct drm_device *drm =3D lcdif->drm; > - u32 bus_format =3D 0; > + u32 bus_format; > dma_addr_t paddr; > = > - /* If there is a bridge attached to the LCDIF, use its bus format */ > - if (lcdif->bridge) { > - bridge_state =3D > - drm_atomic_get_new_bridge_state(state, > - lcdif- >bridge); > - if (!bridge_state) > - bus_format =3D MEDIA_BUS_FMT_FIXED; > - else > - bus_format =3D bridge_state->input_bus_cfg.format; > - > - if (bus_format =3D=3D MEDIA_BUS_FMT_FIXED) { > - dev_warn_once(drm->dev, > - "Bridge does not provide bus = format, assuming > MEDIA_BUS_FMT_RGB888_1X24.\n" - = "Please fix bridge driver by > handling atomic_get_input_bus_fmts.\n"); - = bus_format =3D > MEDIA_BUS_FMT_RGB888_1X24; > - } > - } > + bridge_state =3D drm_atomic_get_new_bridge_state(state, lcdif- >bridge); > + if (!bridge_state) > + bus_format =3D MEDIA_BUS_FMT_FIXED; > + else > + bus_format =3D bridge_state->input_bus_cfg.format; > = > - /* If all else fails, default to RGB888_1X24 */ > - if (!bus_format) > + if (bus_format =3D=3D MEDIA_BUS_FMT_FIXED) { > + dev_warn_once(drm->dev, > + "Bridge does not provide bus format, = assuming > MEDIA_BUS_FMT_RGB888_1X24.\n" + "Please fix = bridge driver by > handling atomic_get_input_bus_fmts.\n"); bus_format =3D > MEDIA_BUS_FMT_RGB888_1X24; > + } > = > clk_set_rate(lcdif->clk, m->crtc_clock * 1000); LGTM. Reviewed-by: Alexander Stein -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel