From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E911C43387 for ; Mon, 14 Jan 2019 10:09:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70D722086D for ; Mon, 14 Jan 2019 10:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lkb7Dus3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70D722086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XX3QmfFuZWjm11ZQja914sUTX+zhQOZAUZu0RZ8vfEc=; b=Lkb7Dus3CVYv6S LufUKMk54EnjW+kRE1XCKRwIGOlHv0FIAVNthy+0q9Gdwzqnx4JEwoD5lY9FZBxqpNauULpVIAUKd Nx7WPm67FE5YVSQbm4zl8tMssR4YRsmNTgGyDF2G7R0N2R+sMye4jDCtxEML8Ov38+lHYPz5JxBhx U22SnXbC7kS7mQpl+RdNgHG+TT3Zlh2fqRlGGe0T7DOiRpDXxbcJucNVnNVtpASX74OwqD8Xf5N84 kz7zU+gwff/X0Lom37uulNDCMxoW3BnVv6TmlqAuFDp8M3fvvv9VCuf1IgxCqUJEmZ0GEgn+3J7Jk yjOlCEt441Vy7kQXdIdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gizBH-0002mI-71; Mon, 14 Jan 2019 10:09:19 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gizBC-0002lE-Ju; Mon, 14 Jan 2019 10:09:16 +0000 Received: from p5b1272c6.dip0.t-ipconnect.de ([91.18.114.198] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gizB4-0004xw-Hk; Mon, 14 Jan 2019 11:09:06 +0100 From: Heiko Stuebner To: Daniel Vetter Subject: Re: [PATCH 3/4] drm/rockchip: add missing of_node_put Date: Mon, 14 Jan 2019 11:09:05 +0100 Message-ID: <10335721.Px6jQUZGiA@phil> In-Reply-To: <20190114100556.GC10517@phenom.ffwll.local> References: <1547369264-24831-1-git-send-email-Julia.Lawall@lip6.fr> <3397932.PmTvevuZIG@phil> <20190114100556.GC10517@phenom.ffwll.local> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190114_020914_802962_F3EA4F55 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, David Airlie , kernel-janitors@vger.kernel.org, Sandy Huang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Julia Lawall , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 14. Januar 2019, 11:05:56 CET schrieb Daniel Vetter: > On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote: > > Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > > > The device node iterators perform an of_node_get on each iteration, so a > > > jump out of the loop requires an of_node_put. > > > > > > The semantic patch that fixes this problem is as follows > > > (http://coccinelle.lip6.fr): > > > > > > // > > > @@ > > > expression root,e; > > > local idexpression child; > > > iterator name for_each_child_of_node; > > > @@ > > > > > > for_each_child_of_node(root, child) { > > > ... when != of_node_put(child) > > > when != e = child > > > + of_node_put(child); > > > ? break; > > > ... > > > } > > > ... when != child > > > // > > > > > > Signed-off-by: Julia Lawall > > > > I've added a fixes+stable tag and applied it to drm-misc-fixes > > All of them or just this one here? These cleanup patches have a high > chance of falling through cracks, so taking them all usually works out > better ... That is the only one I got, so right now I only applied this one in my inbox. Weekend and such resulted in me not going looking for other ones. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel