From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CA8DC41535 for ; Tue, 19 Dec 2023 17:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LmEBQWEOZLK03q3tb+wffWHTxSrB51bmLVMAzfCPW2M=; b=QG/gunPXNwC3qN nuZxSbglPHj/pWEyKH6GZnRyOOSQLKyKwlQc8JHb5gynxONaI+3yFsHNOzG17/sK/nbF9HMtL6Y72 aDWimdUg4jspRgl3TGsMtU5Iy5fpcBGstXkcbNTC/XuKkJu32UTlYK/S+dJmje/fVEiwap1s92Epx Bht/visMivF1rMd5nSmg1mutDuvGQmJ1f1tkl1jrFg1pJKMxpypxlaE7UwtiSG6hOGn7F8ehLyUPb +nn2F/VAj7aQuOVupG4nAvyRjJ7uYviyr36b6g2uDMFoKNixAdpVmIM0ebuKRVPPYGhFC9Ylteq3x qll7sz1x2yJs6Xvpq3XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFdWe-00ErLa-2x; Tue, 19 Dec 2023 17:05:00 +0000 Received: from mail-il1-x135.google.com ([2607:f8b0:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFdWH-00Er9f-2d for linux-arm-kernel@lists.infradead.org; Tue, 19 Dec 2023 17:04:39 +0000 Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-35d74cf427cso18921555ab.1 for ; Tue, 19 Dec 2023 09:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703005476; x=1703610276; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R3vdGyZ+giFIRD6X/bv1+u6PRAF0RuL1pLhWZ53wREY=; b=CpBPoCuVfrCqIStuFWMT1fmHyeQ/7fWZCxeTskbGtBkTn59sqd9sKuS/3+0i8AvzVm aYPL/bMlZvUfER5WiV6qi23oKzJ+n08+bamcXRnEzEIw1CzL+Z88FrTcYAyTVKa2o4ey 5AUrxJHCKFH5FM2tV/dJ+mYBZatcxGZgFSXiYS+nuiKHGClhdqqJs/9QHge6lEED8Le3 q4l1hOgUbUkPE1/x2kVaha5Dqp48bOhgUuUGyeo6/A/rnqh3daLM37tkNKZSEcMy+FFn CPL73u0vj6L1u4ofStazgCNO3kN9LtHPkkaZeT9AXIi6UCfeA2MpY5V4kEgH9dN3AvKQ 8eQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703005476; x=1703610276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R3vdGyZ+giFIRD6X/bv1+u6PRAF0RuL1pLhWZ53wREY=; b=cIdYKFxghoOen+jFheEnxqh6cLEIam3oDgzz9AAKMtW6viPg3fPkjHe8Ywu6Gk5tCR YI4cTY0jDy13RCr4M0YcUdHsLFP0kscstry7c7N0ZtTIwFLRwiNUGx8Nd1nqPXvtkpC5 U8E0WSPdKpbrSw7tDG+4eLWDKPWrZuUJsE15+o2sZErGnxEohOV72Ovm9GlY0ix7d97o lXhtGS2A02RxEPnh8voPQ1UKzQpzyzR85dgFcHzCnuSCvJvJpMAoPlGgArp4MNxCdhWn yGTJnvR9NCq2Y6QSkPUT/6QEqnaf99G2YFin5mF/Q3V3npfniElCDkiUYDyOm5B2v7mr bjKg== X-Gm-Message-State: AOJu0YyYgk05SxYPjFYbFYcuyhmNlWJbht3LSY30rcFnH4X+y4hbOMRz LagoszL1XhE8GK3PJptv3TQ= X-Google-Smtp-Source: AGHT+IHTnWFbi3tnLUi55hj74IPei992iitC3hJxS75IRffKP/GDwsXkYn/gQjSWJRug8oGL8oZx1Q== X-Received: by 2002:a05:6e02:20e3:b0:35f:c6d4:5d59 with SMTP id q3-20020a056e0220e300b0035fc6d45d59mr273364ilv.43.1703005475772; Tue, 19 Dec 2023 09:04:35 -0800 (PST) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id w1-20020a056e021a6100b0035161817c37sm7488495ilv.1.2023.12.19.09.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 09:04:35 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?ISO-8859-1?Q?G=FCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Frank Oltmanns Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Frank Oltmanns Subject: Re: [PATCH 5/5] drm/panel: st7703: Drive XBD599 panel at higher clock rate Date: Tue, 19 Dec 2023 18:04:29 +0100 Message-ID: <10386431.nUPlyArG6x@jernej-laptop> In-Reply-To: <20231218-pinephone-pll-fixes-v1-5-e238b6ed6dc1@oltmanns.dev> References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-5-e238b6ed6dc1@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_090437_852012_A1A754A3 X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 18. december 2023 ob 14:35:23 CET je Frank Oltmanns napisal(a): > This panel is used in the pinephone that runs on a Allwinner A64 SOC. > Acoording to it's datasheet, the SOC requires PLL-MIPI to run at more > than 500 MHz. > > Therefore, change [hv]sync_(start|end) so that we reach a clock rate > that is high enough to drive PLL-MIPI within its limits. > > Signed-off-by: Frank Oltmanns I'm not too sure about this patch. I see that PLL_MIPI doesn't have set minimum frequency limit in clock driver. If you add it, clock framework should find rate that is high enough and divisible with target rate. Best regards, Jernej > --- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c > index b55bafd1a8be..6886fd7f765e 100644 > --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c > @@ -320,14 +320,14 @@ static int xbd599_init_sequence(struct st7703 *ctx) > > static const struct drm_display_mode xbd599_mode = { > .hdisplay = 720, > - .hsync_start = 720 + 40, > - .hsync_end = 720 + 40 + 40, > - .htotal = 720 + 40 + 40 + 40, > + .hsync_start = 720 + 65, > + .hsync_end = 720 + 65 + 65, > + .htotal = 720 + 65 + 65 + 65, > .vdisplay = 1440, > - .vsync_start = 1440 + 18, > - .vsync_end = 1440 + 18 + 10, > - .vtotal = 1440 + 18 + 10 + 17, > - .clock = 69000, > + .vsync_start = 1440 + 30, > + .vsync_end = 1440 + 30 + 22, > + .vtotal = 1440 + 30 + 22 + 29, > + .clock = (720 + 65 + 65 + 65) * (1440 + 30 + 22 + 29) * 60 / 1000, > .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > .width_mm = 68, > .height_mm = 136, > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel