Re: [PATCH v9 7/7] media: platform: mtk-mdp3: add Mediatek MDP3 driver

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Moudy Ho <moudy.ho@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Jernej Skrabec <jernej.skrabec@siol.net>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Rob Landley <rob@landley.net>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Alexandre Courbot <acourbot@chromium.org>,
	tfiga@chromium.org, drinkcat@chromium.org, pihsun@chromium.org,
	hsinyi@google.com, Maoguang Meng <maoguang.meng@mediatek.com>,
	daoyuan huang <daoyuan.huang@mediatek.com>,
	Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
	menghui.lin@mediatek.com, sj.huang@mediatek.com,
	allen-kh.cheng@mediatek.com, randy.wu@mediatek.com,
	jason-jh.lin@mediatek.com, roy-cw.yeh@mediatek.com,
	river.cheng@mediatek.com, srv_heupstream@mediatek.com
Subject: Re: [PATCH v9 7/7] media: platform: mtk-mdp3: add Mediatek MDP3 driver
Date: Wed, 1 Dec 2021 11:37:43 +0100	[thread overview]
Message-ID: <103b1664-d04c-c1fc-ff4c-e2c92ce45ee8@collabora.com> (raw)
In-Reply-To: <20211201095031.31606-8-moudy.ho@mediatek.com>

Il 01/12/21 10:50, Moudy Ho ha scritto:
> This patch adds driver for Mediatek's Media Data Path ver.3 (MDP3).
> It provides the following functions:
>    color transform, format conversion, resize, crop, rotate, flip
>    and additional image quality enhancement.
> 
> The MDP3 driver is mainly used for Google Chromebook products to
> import the new architecture to set the HW settings as shown below:
>    User -> V4L2 framework
>      -> MDP3 driver -> SCP (setting calculations)
>        -> MDP3 driver -> CMDQ (GCE driver) -> HW
> 
> Each modules' related operation control is sited in mtk-mdp3-comp.c
> Each modules' register table is defined in file with "mdp_reg_" prefix
> GCE related API, operation control  sited in mtk-mdp3-cmdq.c
> V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c
> Probe, power, suspend/resume, system level functions are defined in
> mtk-mdp3-core.c
> 
> Signed-off-by: Ping-Hsun Wu <ping-hsun.wu@mediatek.com>
> Signed-off-by: daoyuan huang <daoyuan.huang@mediatek.com>
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
>   drivers/media/platform/Kconfig                |   19 +
>   drivers/media/platform/Makefile               |    2 +
>   drivers/media/platform/mtk-mdp3/Makefile      |    6 +
>   .../media/platform/mtk-mdp3/mdp_reg_ccorr.h   |   19 +
>   drivers/media/platform/mtk-mdp3/mdp_reg_isp.h |   27 +
>   .../media/platform/mtk-mdp3/mdp_reg_rdma.h    |   65 +
>   drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h |   39 +
>   .../media/platform/mtk-mdp3/mdp_reg_wdma.h    |   47 +
>   .../media/platform/mtk-mdp3/mdp_reg_wrot.h    |   55 +
>   drivers/media/platform/mtk-mdp3/mtk-img-ipi.h |  280 ++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c   |  514 +++++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.h   |   46 +
>   .../media/platform/mtk-mdp3/mtk-mdp3-comp.c   | 1264 +++++++++++++++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-comp.h   |  147 ++
>   .../media/platform/mtk-mdp3/mtk-mdp3-core.c   |  338 +++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-core.h   |   76 +
>   .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c    |  789 ++++++++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-m2m.h    |   49 +
>   .../media/platform/mtk-mdp3/mtk-mdp3-regs.c   |  737 ++++++++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-regs.h   |  372 +++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-vpu.c    |  312 ++++
>   .../media/platform/mtk-mdp3/mtk-mdp3-vpu.h    |   78 +
>   22 files changed, 5281 insertions(+)
>   create mode 100644 drivers/media/platform/mtk-mdp3/Makefile
>   create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_ccorr.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_isp.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rdma.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wdma.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wrot.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.c
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.h
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c
>   create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.h
> 

snip...

> diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
> new file mode 100644
> index 000000000000..a643f3ee928b
> --- /dev/null
> +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
> @@ -0,0 +1,514 @@

Looks like you forgot to check my review comments to this entire file.
Can you please send a new version after applying the changes to this file
suggested in my review of series v8?

Thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel