From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3B6C43381 for ; Tue, 12 Mar 2019 14:08:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BECAB2087C for ; Tue, 12 Mar 2019 14:08:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KggxJa4V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BECAB2087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gn5EQrloTFnx6mmuHBw+/mDIucrIWvaPa2jlk6we8Y0=; b=KggxJa4VizsN9X dxb8MvvhAcs7I1c6VOXpwzn8k3P2B1cuIjqz6URr8XRtnIV8bKkD7BObNXloHbrRa7R6l27B1/F5y Fcf2sBchV0fDnHT/uq7kuF51alDsLaWSLLqDBcqYHr6/jy4cspDHBdBpWVFvAz4rFSNYRsAzRNH5j 3kTq23pwwPlU1k0mg+q0eYA5yDXCZD3b5xr9rjiKX6FhH23u75+jHRsNx9vmS/1AYAm3DEeeWaQpw qq8X6jxXh3DVS8XEerdACQSqVfFNmdnrVwimsmMcTMGipsOwx0sN6rygb4PaDexMr70yMNXkcnqD9 wIrSmvgA8gmZBqt6Si5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3i51-0002gn-Gz; Tue, 12 Mar 2019 14:08:31 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3i4w-0002g6-RD; Tue, 12 Mar 2019 14:08:28 +0000 Received: from we0652.dip.tu-dresden.de ([141.76.178.140] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3i4l-00021r-PW; Tue, 12 Mar 2019 15:08:15 +0100 From: Heiko Stuebner To: David Summers Subject: Re: [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Date: Tue, 12 Mar 2019 15:08:15 +0100 Message-ID: <10436027.DUyLE1RSiR@phil> In-Reply-To: <20190309153923.22806-1-beagleboard@davidjohnsummers.uk> References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-1-beagleboard@davidjohnsummers.uk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_070827_031715_BC6DAA13 X-CRM114-Status: GOOD ( 19.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, Robin Murphy , linux-mmc@vger.kernel.org, jh80.chung@samsung.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 9. M=E4rz 2019, 16:39:21 CET schrieb David Summers: > The Problem: > = > On ASUS Tinker Board S, when booting from the eMMC, and there is card > in the sd slot, there are constant errors. > = > Also when warm reboot, uboot can not access the sd slot > = > Cause: > = > Identified by Robin Murphy @ ARM. The Card Detect on rk3288 > devices is pulled up by vccio-sd; so when the regulator powers this > off, card detect gives spurious errors. A second problem, is during > power down, vccio-sd apprears to be powered down. This causes a > problem when warm rebooting from the sd card. This was identified by > Jonas Karlman. > = > History: > = > A common fault on these rk3288 board, which impliment the reference > design. > = > When this arose before: > = > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/281153.= html > = > And Ulf and Jaehoon clearly said this was a broken card detect design, > which should be solved via polling > = > Solution: > = > Hence broken-cd is set as a property. This cures the errors. The > powering down of vccio-sd during reboot is cured by adding > regulator-boot-on. > = > This solutions has been fairly widely reviewed and tested. > = > Signed-off-by: David Summers > Reviewed by: Robin Murphy > Reviewed by: Jonas Karlman > Test by: TheSaint @ ArchLinux Arm please follow patch submission guidelines, here it would be Tested-by: ... with an actual Name + mail address Also I did try to go through the way big mail thread but didn't find an actual "Reviewed-by" from Robin Murphy, similar to what he pointed out in patch2 Other than that and including the past discussions, this looks good. Heiko > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > = > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3= 288-tinker.dtsi > index aa107ee41b8b..ef653c3209bc 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -254,6 +254,7 @@ > }; > = > vccio_sd: LDO_REG5 { > + regulator-boot-on; > regulator-min-microvolt =3D <1800000>; > regulator-max-microvolt =3D <3300000>; > regulator-name =3D "vccio_sd"; > @@ -430,7 +431,7 @@ > bus-width =3D <4>; > cap-mmc-highspeed; > cap-sd-highspeed; > - card-detect-delay =3D <200>; > + broken-cd; > disable-wp; /* wp not hooked up */ > pinctrl-names =3D "default"; > pinctrl-0 =3D <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel