linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Add basic DVFS support for RK3368
@ 2017-08-18  7:50 Romain Perier
  2017-08-18  8:20 ` Heiko Stuebner
  0 siblings, 1 reply; 3+ messages in thread
From: Romain Perier @ 2017-08-18  7:50 UTC (permalink / raw)
  To: linux-arm-kernel

This adds and enable the operating points that have been tested and are
currently supported by the SoC.

Signed-off-by: Romain Perier <romain.perier@collabora.com>
---

Note: RK3288 is using operating-points binding v1, while RK3399 is using
binding v2. I can send another iteration for switching to binding v2,
if required.

 arch/arm64/boot/dts/rockchip/rk3368.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
index 6d5dc0587e59..f2ae3bf9377a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
@@ -113,8 +113,18 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x0>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKL>;
+			operating-points = <
+				/* KHz    uV */
+				312000 950000
+				408000 950000
+				600000 950000
+				816000 1025000
+				1008000 1125000
+			>;
 
 			#cooling-cells = <2>; /* min followed by max */
+			clock-latency = <40000>;
 		};
 
 		cpu_l1: cpu at 1 {
@@ -122,6 +132,7 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x1>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKL>;
 		};
 
 		cpu_l2: cpu at 2 {
@@ -129,6 +140,7 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x2>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKL>;
 		};
 
 		cpu_l3: cpu at 3 {
@@ -136,6 +148,7 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x3>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKL>;
 		};
 
 		cpu_b0: cpu at 100 {
@@ -143,8 +156,18 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x100>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKB>;
+			operating-points = <
+				/* KHz    uV */
+				312000 950000
+				408000 950000
+				600000 950000
+				816000 975000
+				1008000 1050000
+			>;
 
 			#cooling-cells = <2>; /* min followed by max */
+			clock-latency = <40000>;
 		};
 
 		cpu_b1: cpu at 101 {
@@ -152,6 +175,7 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x101>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKB>;
 		};
 
 		cpu_b2: cpu at 102 {
@@ -159,6 +183,7 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x102>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKB>;
 		};
 
 		cpu_b3: cpu at 103 {
@@ -166,9 +191,11 @@
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0x0 0x103>;
 			enable-method = "psci";
+			clocks = <&cru ARMCLKB>;
 		};
 	};
 
+
 	amba {
 		compatible = "simple-bus";
 		#address-cells = <2>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] arm64: dts: rockchip: Add basic DVFS support for RK3368
  2017-08-18  7:50 [PATCH] arm64: dts: rockchip: Add basic DVFS support for RK3368 Romain Perier
@ 2017-08-18  8:20 ` Heiko Stuebner
  2017-08-18  9:40   ` Romain Perier
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2017-08-18  8:20 UTC (permalink / raw)
  To: linux-arm-kernel

Am Freitag, 18. August 2017, 09:50:53 CEST schrieb Romain Perier:
> This adds and enable the operating points that have been tested and are
> currently supported by the SoC.
> 
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> ---
> 
> Note: RK3288 is using operating-points binding v1, while RK3399 is using
> binding v2. I can send another iteration for switching to binding v2,
> if required.

Yes please use v2 for _new_ operating points :-) .

One more thing down below.

> 
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index 6d5dc0587e59..f2ae3bf9377a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -113,8 +113,18 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x0>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKL>;
> +			operating-points = <
> +				/* KHz    uV */
> +				312000 950000
> +				408000 950000
> +				600000 950000
> +				816000 1025000
> +				1008000 1125000
> +			>;
>  
>  			#cooling-cells = <2>; /* min followed by max */
> +			clock-latency = <40000>;
>  		};
>  
>  		cpu_l1: cpu at 1 {
> @@ -122,6 +132,7 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x1>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKL>;
>  		};
>  
>  		cpu_l2: cpu at 2 {
> @@ -129,6 +140,7 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x2>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKL>;
>  		};
>  
>  		cpu_l3: cpu at 3 {
> @@ -136,6 +148,7 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x3>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKL>;
>  		};
>  
>  		cpu_b0: cpu at 100 {
> @@ -143,8 +156,18 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x100>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKB>;
> +			operating-points = <
> +				/* KHz    uV */
> +				312000 950000
> +				408000 950000
> +				600000 950000
> +				816000 975000
> +				1008000 1050000
> +			>;
>  
>  			#cooling-cells = <2>; /* min followed by max */
> +			clock-latency = <40000>;
>  		};
>  
>  		cpu_b1: cpu at 101 {
> @@ -152,6 +175,7 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x101>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKB>;
>  		};
>  
>  		cpu_b2: cpu at 102 {
> @@ -159,6 +183,7 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x102>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKB>;
>  		};
>  
>  		cpu_b3: cpu at 103 {
> @@ -166,9 +191,11 @@
>  			compatible = "arm,cortex-a53", "arm,armv8";
>  			reg = <0x0 0x103>;
>  			enable-method = "psci";
> +			clocks = <&cru ARMCLKB>;
>  		};
>  	};
>  
> +

unnecessary empty line

>  	amba {
>  		compatible = "simple-bus";
>  		#address-cells = <2>;
> 

Heiko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] arm64: dts: rockchip: Add basic DVFS support for RK3368
  2017-08-18  8:20 ` Heiko Stuebner
@ 2017-08-18  9:40   ` Romain Perier
  0 siblings, 0 replies; 3+ messages in thread
From: Romain Perier @ 2017-08-18  9:40 UTC (permalink / raw)
  To: linux-arm-kernel

Hello,


Le 18/08/2017 ? 10:20, Heiko Stuebner a ?crit :
> Am Freitag, 18. August 2017, 09:50:53 CEST schrieb Romain Perier:
>> This adds and enable the operating points that have been tested and are
>> currently supported by the SoC.
>>
>> Signed-off-by: Romain Perier <romain.perier@collabora.com>
>> ---
>>
>> Note: RK3288 is using operating-points binding v1, while RK3399 is using
>> binding v2. I can send another iteration for switching to binding v2,
>> if required.
> Yes please use v2 for _new_ operating points :-) .
>
> One more thing down below.

Ack, will do.

Thanks,
Romain

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-18  9:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-18  7:50 [PATCH] arm64: dts: rockchip: Add basic DVFS support for RK3368 Romain Perier
2017-08-18  8:20 ` Heiko Stuebner
2017-08-18  9:40   ` Romain Perier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).