From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: Komal Bajaj <quic_kbajaj@quicinc.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] arm64: defconfig: Enable secure QFPROM driver
Date: Wed, 19 Jun 2024 14:23:55 +0200 [thread overview]
Message-ID: <10568cd0-8005-4a8f-bb4c-03d33c87a15c@linaro.org> (raw)
In-Reply-To: <ZnLKwqENxC4wzrUm@hu-mojha-hyd.qualcomm.com>
On 19/06/2024 14:10, Mukesh Ojha wrote:
> On Wed, Jun 19, 2024 at 01:08:48PM +0200, Krzysztof Kozlowski wrote:
>> On 19/06/2024 12:56, Komal Bajaj wrote:
>>> Enable the secure QFPROM driver which is used by QDU1000
>>
>> Qualcomm QDU1000. You are changing kernel-wide defconfig, not some
>> Qualcomm downstream stuff.
>>
>>> platform for reading the secure qfprom region to get the
>>> DDR channel configuration.
>>>
>>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 838b4466d6f6..c940437ae1b3 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -1575,6 +1575,7 @@ CONFIG_NVMEM_LAYERSCAPE_SFP=m
>>> CONFIG_NVMEM_MESON_EFUSE=m
>>> CONFIG_NVMEM_MTK_EFUSE=y
>>> CONFIG_NVMEM_QCOM_QFPROM=y
>>> +CONFIG_NVMEM_QCOM_SEC_QFPROM=y
>>
>> Module
>
> Should not this be inline with what CONFIG_NVMEM_QCOM_QFPROM is having ?
> Either both CONFIG_NVMEM_QCOM_QFPROM and CONFIG_NVMEM_QCOM_SEC_QFPROM
> should be m or both y
Why? There is no dependency in Kconfig.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-19 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 10:56 [PATCH] arm64: defconfig: Enable secure QFPROM driver Komal Bajaj
2024-06-19 10:57 ` Dmitry Baryshkov
2024-06-19 11:08 ` Krzysztof Kozlowski
2024-06-19 12:10 ` Mukesh Ojha
2024-06-19 12:23 ` Krzysztof Kozlowski [this message]
2024-06-19 13:14 ` Dmitry Baryshkov
2024-06-19 16:38 ` Mukesh Ojha
2024-06-19 16:51 ` Bjorn Andersson
2024-06-19 18:46 ` Mukesh Ojha
2024-06-19 16:42 ` Bjorn Andersson
2024-06-20 9:43 ` Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10568cd0-8005-4a8f-bb4c-03d33c87a15c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_kbajaj@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).