From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Broadcom soc changes for v4.4
Date: Fri, 09 Oct 2015 17:46:46 +0200 [thread overview]
Message-ID: <10665189.Vh1KLFXpVv@wuerfel> (raw)
In-Reply-To: <1443824458-20799-4-git-send-email-f.fainelli@gmail.com>
On Friday 02 October 2015 15:20:58 Florian Fainelli wrote:
> This pull request contains the following Broadcom SoC platform and driver changes:
>
> - Brian Norris create a drivers/soc/brcmstb/ stub and then adds support for S2/S3/S5
> suspend/resume modes for the Broadcom BCM7xxx Set Top Box SoCs
I'm not overly happy with this part of the code (sorry Brian):
- it looks like it should be a cpuidle driver. Not completely sure about this,
but I'd like to see at least an Ack from the cpuidle maintainers to confirm
that they want it to be done in drivers/soc
- any code here that is not going into a cpuidle driver for this part looks
like it's better suited to go to arch/arm/mach-bcm, as the code doesn't
feel like a driver. This is of course a gray area, and can be debated.
- it's clearly not endian-safe. There really is no reason to use __raw
mmio accessors here, or to define the interface to the firmware in terms
of native endianess when the registers and firmware is known to be
little-endian.
Sorry for not noticing the driver earlier when it was discussed on the list,
but I think the above is reason enough to do another revision.
Can you submit a new pull request without the suspend/resume handling?
Arnd
next prev parent reply other threads:[~2015-10-09 15:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 22:20 [GIT PULL] Broadcom defconfig changes for v4.4 Florian Fainelli
2015-10-02 22:20 ` [GIT PULL] Broadcom devicetree " Florian Fainelli
2015-10-09 15:22 ` Arnd Bergmann
2015-10-02 22:20 ` [GIT PULL] Broadcom maintainers " Florian Fainelli
2015-10-09 15:24 ` Arnd Bergmann
2015-10-02 22:20 ` [GIT PULL] Broadcom soc " Florian Fainelli
2015-10-09 15:46 ` Arnd Bergmann [this message]
2015-10-09 17:01 ` Florian Fainelli
2015-10-09 18:23 ` Arnd Bergmann
2015-10-10 18:40 ` [GIT PULL] Broadcom soc changes for v4.4 (try 2) Florian Fainelli
2015-10-15 20:16 ` Arnd Bergmann
2015-10-15 20:23 ` Florian Fainelli
2015-10-06 14:04 ` [GIT PULL] Broadcom defconfig changes for v4.4 Arnd Bergmann
2015-10-08 17:23 ` Florian Fainelli
2015-10-08 18:38 ` Arnd Bergmann
2015-10-08 22:49 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10665189.Vh1KLFXpVv@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox