From: "Heiko Stübner" <heiko@sntech.de>
To: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Damon Ding <damon.ding@rock-chips.com>
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com,
andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com,
l.stach@pengutronix.de, dianders@chromium.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: Re: [PATCH v3 08/14] drm/bridge: analogix_dp: Apply drm_bridge_connector helper
Date: Thu, 24 Jul 2025 15:00:49 +0200 [thread overview]
Message-ID: <10694296.nUPlyArG6x@diego> (raw)
In-Reply-To: <20250724080304.3572457-9-damon.ding@rock-chips.com>
Hi Damon,
Am Donnerstag, 24. Juli 2025, 10:02:58 Mitteleuropäische Sommerzeit schrieb Damon Ding:
> Apply drm_bridge_connector helper for Analogix DP driver.
>
> The following changes have been made:
> - Apply drm_bridge_connector helper to get rid of &drm_connector_funcs
> and &drm_connector_helper_funcs.
> - Remove unnecessary parameter struct drm_connector* for callback
> &analogix_dp_plat_data.attach.
> - Remove &analogix_dp_device.connector.
> - Convert analogix_dp_atomic_check()/analogix_dp_detect() to
> &drm_bridge_funcs.atomic_check()/&drm_bridge_funcs.detect().
> - Split analogix_dp_get_modes() into &drm_bridge_funcs.get_modes() and
> &drm_bridge_funcs.edid_read().
>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> static enum drm_connector_status
> -analogix_dp_detect(struct drm_connector *connector, bool force)
> +analogix_dp_bridge_detect(struct drm_bridge *bridge)
> {
> - struct analogix_dp_device *dp = to_dp(connector);
> + struct analogix_dp_device *dp = to_dp(bridge);
> enum drm_connector_status status = connector_status_disconnected;
>
> if (dp->plat_data->panel)
this needs an update to
static enum drm_connector_status
-analogix_dp_bridge_detect(struct drm_bridge *bridge)
+analogix_dp_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector)
to follow Andy's patch [0] that got already applied to drm-misc-next
Heiko
[0] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/5d156a9c3d5ea3dbec192121259dee2c2f938fa1
next prev parent reply other threads:[~2025-07-24 15:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 8:02 [PATCH v3 00/14] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2025-07-24 8:02 ` [PATCH v3 01/14] drm/bridge: analogix_dp: Formalize the struct analogix_dp_device Damon Ding
2025-07-24 8:02 ` [PATCH v3 02/14] drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to &drm_bridge_funcs.atomic_enable Damon Ding
2025-07-24 8:02 ` [PATCH v3 03/14] drm/rockchip: analogix_dp: Apply drmm_encoder_init() instead of drm_simple_encoder_init() Damon Ding
2025-07-26 0:12 ` Dmitry Baryshkov
2025-07-29 3:22 ` Damon Ding
2025-07-24 8:02 ` [PATCH v3 04/14] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.bridge Damon Ding
2025-07-26 0:15 ` Dmitry Baryshkov
2025-07-29 7:30 ` Maxime Ripard
2025-07-29 8:31 ` Damon Ding
2025-07-24 8:02 ` [PATCH v3 05/14] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2025-07-26 0:15 ` Dmitry Baryshkov
2025-07-24 8:02 ` [PATCH v3 06/14] drm/bridge: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2025-07-26 0:14 ` Dmitry Baryshkov
2025-07-24 8:02 ` [PATCH v3 07/14] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2025-07-26 0:14 ` Dmitry Baryshkov
2025-07-24 8:02 ` [PATCH v3 08/14] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2025-07-24 13:00 ` Heiko Stübner [this message]
2025-07-25 1:47 ` Damon Ding
2025-07-25 2:26 ` kernel test robot
2025-07-24 8:02 ` [PATCH v3 09/14] drm/bridge: analogix_dp: Add support to find panel or bridge Damon Ding
2025-07-26 12:03 ` Dmitry Baryshkov
2025-07-29 3:09 ` Damon Ding
2025-07-24 8:03 ` [PATCH v3 10/14] drm/rockchip: analogix_dp: Apply analogix_dp_find_panel_or_bridge() Damon Ding
2025-07-26 12:03 ` Dmitry Baryshkov
2025-07-24 8:03 ` [PATCH v3 11/14] drm/exynos: exynos_dp: " Damon Ding
2025-07-26 12:05 ` Dmitry Baryshkov
2025-07-24 8:03 ` [PATCH v3 12/14] drm/bridge: analogix_dp: Remove panel disabling and enabling in analogix_dp_set_bridge() Damon Ding
2025-07-24 8:03 ` [PATCH v3 13/14] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2025-07-24 8:03 ` [PATCH v3 14/14] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2025-07-24 13:08 ` Heiko Stübner
2025-07-25 1:57 ` Damon Ding
2025-07-24 13:10 ` [PATCH v3 00/14] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Heiko Stübner
2025-07-25 2:15 ` Damon Ding
2025-07-25 19:45 ` Heiko Stübner
2025-07-29 3:02 ` Damon Ding
2025-07-29 3:16 ` Damon Ding
2025-08-06 19:54 ` Heiko Stübner
2025-08-07 1:31 ` Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10694296.nUPlyArG6x@diego \
--to=heiko@sntech.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=damon.ding@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=sw0312.kim@samsung.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).