From: David Woodhouse <dwmw2@infradead.org>
To: Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Raghavendra Rao Ananta <rananta@google.com>,
Eric Auger <eric.auger@redhat.com>, Kees Cook <kees@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <nathan@kernel.org>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: (subset) [PATCH 1/3] KVM: arm64: vgic: Fix IIDR revision field extracted from wrong value
Date: Fri, 24 Apr 2026 13:24:49 +0100 [thread overview]
Message-ID: <106addd3f78918a9a584c43c181a9609aef1ceca.camel@infradead.org> (raw)
In-Reply-To: <177702878141.537738.13460155220731277452.b4-ty@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
On Fri, 2026-04-24 at 12:07 +0100, Marc Zyngier wrote:
> On Tue, 07 Apr 2026 21:27:02 +0100, David Woodhouse wrote:
> > The uaccess write handlers for GICD_IIDR in both GICv2 and GICv3
> > extract the revision field from 'reg' (the current IIDR value read back
> > from the emulated distributor) instead of 'val' (the value userspace is
> > trying to write). This means userspace can never actually change the
> > implementation revision — the extracted value is always the current one.
> >
> > Fix the FIELD_GET to use 'val' so that userspace can select a different
> > revision for migration compatibility.
> >
> > [...]
>
> Applied to fixes, thanks!
>
> [1/3] KVM: arm64: vgic: Fix IIDR revision field extracted from wrong value
> commit: a0e6ae45af17e8b27958830595799c702ffbab8d
There was a v2 of this series which also cleaned up the weird
inconsistency of the IIDR value with the actual behaviour, and which
fixed the fact that it's currently not possible to maintain guest
compatibility when upgrading from a pre-d53c2c29ae0d kernel to a new
one — despite the fact that that kind of compatibility is *precisely*
what the revision field in the IIDR is designed for.
https://lore.kernel.org/all/20260408113256.2095505-1-dwmw2@infradead.org/
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
next prev parent reply other threads:[~2026-04-24 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 20:27 [PATCH 0/3] KVM: arm64: vgic: Fix IIDR revision handling and add revision 1 David Woodhouse
2026-04-07 20:27 ` [PATCH 1/3] KVM: arm64: vgic: Fix IIDR revision field extracted from wrong value David Woodhouse
2026-04-24 11:07 ` (subset) " Marc Zyngier
2026-04-24 12:24 ` David Woodhouse [this message]
2026-05-10 21:28 ` David Woodhouse
2026-04-07 20:27 ` [PATCH 2/3] KVM: arm64: vgic: Allow userspace to set IIDR revision 1 David Woodhouse
2026-04-08 7:54 ` Marc Zyngier
2026-04-08 8:39 ` Woodhouse, David
2026-04-09 13:45 ` Marc Zyngier
2026-04-09 15:01 ` [EXTERNAL] " David Woodhouse
2026-04-08 10:32 ` David Woodhouse
2026-04-07 20:27 ` [PATCH 3/3] KVM: arm64: selftests: Add vgic IIDR revision test David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106addd3f78918a9a584c43c181a9609aef1ceca.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=eric.auger@redhat.com \
--cc=joey.gouly@arm.com \
--cc=kees@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=nathan@kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rananta@google.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox