From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "jia-wei.chang" <jia-wei.chang@mediatek.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hector Yuan <hector.yuan@mediatek.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
hsinyi@google.com
Subject: Re: [PATCH 1/2] dt-bindings: cpufreq: add mt8188 cpufreq hw dt-bindings
Date: Fri, 5 Aug 2022 11:18:47 +0200 [thread overview]
Message-ID: <106e443a-e765-51fe-b556-e4e7e2aa771c@linaro.org> (raw)
In-Reply-To: <20220805091211.2791-2-jia-wei.chang@mediatek.com>
On 05/08/2022 11:12, jia-wei.chang wrote:
> From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
>
> Add mt8188 cpufreq hw compatible in dt-bindings.
>
> Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> index 9cd42a64b13e..b56d36224612 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> @@ -16,7 +16,9 @@ description:
>
> properties:
> compatible:
> - const: mediatek,cpufreq-hw
> + enum:
> + - mediatek,cpufreq-hw
Can you add a comment mentioning for which SoCs this is? Someone added a
generic compatible covering all MediaTek cpufreq-hw (all!) and now you
say it does not cover all?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-05 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 9:12 [PATCH 0/2] cpufreq: mediatek-hw: add support for mt8188 jia-wei.chang
2022-08-05 9:12 ` [PATCH 1/2] dt-bindings: cpufreq: add mt8188 cpufreq hw dt-bindings jia-wei.chang
2022-08-05 9:18 ` Krzysztof Kozlowski [this message]
2022-08-19 9:21 ` Jia-Wei Chang
2022-08-05 9:12 ` [PATCH 2/2] cpufreq: mediatek-hw: add support for mt8188 jia-wei.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106e443a-e765-51fe-b556-e4e7e2aa771c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hector.yuan@mediatek.com \
--cc=hsinyi@google.com \
--cc=jia-wei.chang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox